Unhold nginx after apt-get upgrade in PHP-FPM Dockerfiles#2927
Merged
Saipriya-1144 merged 1 commit intoMay 18, 2026
Conversation
sarsharma
approved these changes
May 18, 2026
Shi1810
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nginx is currently held (apt-mark hold) to prevent it from being upgraded during image build, but the hold is never released. This causes customer apt-get install nginx commands to fail at container runtime.
Changes:
Add apt-mark unhold nginx after the final apt-get upgrade step so customers can install/reinstall nginx at runtime
Remove dead if/else version-check branches in PHP
8.1–8.3 Dockerfiles (the else path for older --with-png-dir style config is never reached for these versions)
The purpose of this PR is explained in this message or in an issue. If an issue please include a reference as #<issue_number>.
Tests are included and/or updated for code changes.
Proper license headers are included in each file.