Minor updates (#74)

* Addressed build warnings with the PowerShell project.

* Addressing build warnings with the Partner Center project.

* Performed minor code cleanup

* Performed minor code cleanup and updated the documentation

Author: idwilliams-2

docs/help/Connect-PartnerCenter.md

@@ -136,7 +136,7 @@ The environment use for authentication.
 ```yaml
 Type: EnvironmentName
 Parameter Sets: (All)
-Aliases:
+Aliases: EnvironmentName
 Accepted values: GlobalCloud, ChinaCloud, GermanCloud, USGovernment
 
 Required: False

docs/help/Get-PartnerCustomerServiceCostsSummary.md

@@ -2,7 +2,7 @@
 content_git_url: https://github.com/Microsoft/Partner-Center-PowerShell/blob/master/docs/help/Get-PartnerCustomerServiceCostsSummary.md
 external help file: Microsoft.Store.PartnerCenter.PowerShell.dll-Help.xml
 Module Name: PartnerCenter
-online version:
+online version: https://go.microsoft.com/fwlink/?linkid=2072712
 original_content_git_url: https://github.com/Microsoft/Partner-Center-PowerShell/blob/master/docs/help/Get-PartnerCustomerServiceCostsSummary.md
 schema: 2.0.0
 ---
@@ -14,7 +14,7 @@ Gets a customer's service costs for the specified billing period.
 
 ## SYNTAX
 
-```
+```powershell
 Get-PartnerCustomerServiceCostsSummary -BillingPeriod <ServiceCostsBillingPeriod> -CustomerId <String>
  [<CommonParameters>]
 ```
@@ -40,7 +40,7 @@ An indicator that represents the billing period.
 Type: ServiceCostsBillingPeriod
 Parameter Sets: (All)
 Aliases:
-Accepted values: Current, MostRecent
+Accepted values: MostRecent
 
 Required: True
 Position: Named

src/PartnerCenter.TestFramework/PartnerCenter.TestFramework.csproj

@@ -16,6 +16,13 @@
     <NeutralLanguage>en-US</NeutralLanguage>
   </PropertyGroup>
 
+  <ItemGroup>
+    <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.6.3">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
+    </PackageReference>
+  </ItemGroup>
+
   <ItemGroup>
     <ProjectReference Include="..\PartnerCenter\PartnerCenter.csproj" />
   </ItemGroup>

src/PartnerCenter/Carts/CartOperations.cs

@@ -21,7 +21,7 @@ internal class CartOperations : BasePartnerComponent<Tuple<string, string>>, ICa
         /// <summary>
         /// Content used when checking out a cart.
         /// </summary>
-        private const string Success = "success"; 
+        private const string Success = "success";
 
         /// <summary>
         /// Initializes a new instance of the <see cref="CartOperations" /> class.

src/PartnerCenter/IPartner.cs

@@ -9,12 +9,12 @@ namespace Microsoft.Store.PartnerCenter
     using Agreements;
     using Analytics;
     using Auditing;
-    using CountryValidationRules;
     using Customers;
     using Domains;
     using Enumerators;
     using Extensions;
     using GenericOperations;
+    using Incidents;
     using Invoices;
     using Network;
     using Offers;
@@ -23,9 +23,9 @@ namespace Microsoft.Store.PartnerCenter
     using RateCards;
     using Relationships;
     using RequestContext;
-    using ServiceIncidents;
     using ServiceRequests;
     using Usage;
+    using ValidationRules;
     using Validations;
 
     /// <summary>

…eIncidents/IServiceIncidentCollection.cs …/Incidents/IServiceIncidentCollection.cssrc/PartnerCenter/ServiceIncidents/IServiceIncidentCollection.cs renamed to src/PartnerCenter/Incidents/IServiceIncidentCollection.cs src/PartnerCenter/ServiceIncidents/IServiceIncidentCollection.cs renamed to src/PartnerCenter/Incidents/IServiceIncidentCollection.cs

@@ -4,14 +4,14 @@
 // </copyright>
 // -----------------------------------------------------------------------
 
-namespace Microsoft.Store.PartnerCenter.ServiceIncidents
+namespace Microsoft.Store.PartnerCenter.Incidents
 {
     using System.Threading;
     using System.Threading.Tasks;
     using GenericOperations;
     using Models;
     using Models.Query;
-    using Models.ServiceIncidents;
+    using Models.Incidents;
 
     /// <summary>
     /// Defines the operations available on service incidents.

…s/ServiceIncidentCollectionOperations.cs …s/ServiceIncidentCollectionOperations.cssrc/PartnerCenter/ServiceIncidents/ServiceIncidentCollectionOperations.cs renamed to src/PartnerCenter/Incidents/ServiceIncidentCollectionOperations.cs src/PartnerCenter/ServiceIncidents/ServiceIncidentCollectionOperations.cs renamed to src/PartnerCenter/Incidents/ServiceIncidentCollectionOperations.cs

@@ -4,7 +4,7 @@
 // </copyright>
 // -----------------------------------------------------------------------
 
-namespace Microsoft.Store.PartnerCenter.ServiceIncidents
+namespace Microsoft.Store.PartnerCenter.Incidents
 {
     using System;
     using System.Collections.Generic;
@@ -13,7 +13,7 @@ namespace Microsoft.Store.PartnerCenter.ServiceIncidents
     using Models;
     using Models.JsonConverters;
     using Models.Query;
-    using Models.ServiceIncidents;
+    using Models.Incidents;
 
     /// <summary>
     /// Service incident collection operations implementation class.

src/PartnerCenter/Models/Authentication/DeviceCodeResponse.cs

@@ -1,5 +1,5 @@
 // -----------------------------------------------------------------------
-// <copyright file="DeviceCodeResult.cs" company="Microsoft">
+// <copyright file="DeviceCodeResponse.cs" company="Microsoft">
 //     Copyright (c) Microsoft Corporation. All rights reserved.
 // </copyright>
 // -----------------------------------------------------------------------
@@ -62,7 +62,7 @@ internal sealed class DeviceCodeResponse
         /// Verification URL where the user must navigate to authenticate using the device code and credentials.
         /// </summary>
         [DataMember(IsRequired = false, Name = "verification_url")]
-        public string VerificationUrl { get; internal set; }
+        public Uri VerificationUrl { get; internal set; }
 
         /// <summary>
         /// Get an instance of the <see cref="DeviceCodeResult" /> class based on this instnace of <see cref="DeviceCodeResponse" />.

src/PartnerCenter/Models/Authentication/DeviceCodeResult.cs

@@ -58,6 +58,6 @@ internal DeviceCodeResult()
         /// <summary>
         /// Verification URL where the user must navigate to authenticate using the device code and credentials.
         /// </summary>
-        public string VerificationUrl { get; internal set; }
+        public Uri VerificationUrl { get; internal set; }
     }
 }

src/PartnerCenter/Models/Carts/CartLineItem.cs

@@ -14,6 +14,14 @@ namespace Microsoft.Store.PartnerCenter.Models.Carts
     /// </summary>
     public sealed class CartLineItem
     {
+        /// <summary>
+        /// Initializes a new instance of the <see cref="CartLineItem" />
+        /// </summary>
+        public CartLineItem()
+        {
+            ProvisioningContext = new Dictionary<string, string>();
+        }
+
         /// <summary>
         /// Gets or sets a list of items that depend on this one, so they have to be purchased subsequently.
         /// </summary>
@@ -58,11 +66,11 @@ public sealed class CartLineItem
         /// Gets or sets a collection of participants on this purchase.
         /// </summary>
         public IEnumerable<KeyValuePair<ParticipantType, string>> Participants { get; set; }
-        
+
         /// <summary>
-        /// Gets or sets a context that will be used for provisioning of the catalog item.
+        /// Gets a context that will be used for provisioning of the catalog item.
         /// </summary>
-        public Dictionary<string, string> ProvisioningContext { get; set; }
+        public Dictionary<string, string> ProvisioningContext { get; }
 
         /// <summary>
         /// Gets or sets the product quantity.