Addressing device code flow issue and performing minor code cleanup (#187)

Author: Isaiah Williams

ChangeLog.md

@@ -24,6 +24,7 @@
 
 * Authentication
   * Addressed issue preventing the [Test-PartnerSecurityRequirement](https://docs.microsoft.com/powershell/module/partnercenter/test-partnersecurityrequirement) command from working as expected
+  * Addressed issue [#186](https://github.com/microsoft/Partner-Center-PowerShell/issues/186) that was preventing access token from being generated when using the device code flow
 
 ## 2.0.1911.2
 

src/PowerShell/Authenticators/DeviceCodeAuthenticator.cs

@@ -4,7 +4,6 @@
 namespace Microsoft.Store.PartnerCenter.PowerShell.Authenticators
 {
     using System;
-    using System.Collections.Generic;
     using System.Threading;
     using System.Threading.Tasks;
     using Extensions;
@@ -28,17 +27,11 @@ public override Task<AuthenticationResult> AuthenticateAsync(AuthenticationParam
         {
             IPublicClientApplication app = GetClient(parameters.Account, parameters.Environment).AsPublicClient();
 
-            return GetResponseAsync(app, parameters.Scopes, promptAction, cancellationToken);
-        }
-
-        private async Task<AuthenticationResult> GetResponseAsync(IPublicClientApplication app, IEnumerable<string> scopes, Action<string> promptAction = null, CancellationToken cancellationToken = default)
-        {
-            return await app.AcquireTokenWithDeviceCode(scopes, deviceCodeResult =>
+            return app.AcquireTokenWithDeviceCode(parameters.Scopes, deviceCodeResult =>
             {
-                promptAction(deviceCodeResult.Message);
+                Console.WriteLine(deviceCodeResult.Message);
                 return Task.CompletedTask;
             }).ExecuteAsync(cancellationToken);
-
         }
 
         /// <summary>

src/PowerShell/Commands/GetPartnerUser.cs

@@ -4,8 +4,8 @@
 namespace Microsoft.Store.PartnerCenter.PowerShell.Commands
 {
     using System.Management.Automation;
-    using Models.Authentication;
     using Models;
+    using Models.Authentication;
 
     [Cmdlet(VerbsCommon.Get, "PartnerUser"), OutputType(typeof(Microsoftgraphuser))]
     public class GetPartnerUser : PartnerCmdlet

src/PowerShell/Commands/TestPartnerSecurityRequirement.cs

@@ -69,7 +69,7 @@ protected override void ProcessRecord()
                 environment,
                 new[] { $"{environment.PartnerCenterEndpoint}/user_impersonation" },
                 Message,
-                WriteWarning, 
+                WriteWarning,
                 CancellationToken);