Release update (#250)

Author: Isaiah Williams

CHANGELOG.md

@@ -20,7 +20,7 @@
 
 # Change Log
 
-## Upcoming Release
+## 3.0.4 January 2020
 
 * Authentication
   * Addressed an issue where NullReferenceException exception was being encountered when invoking [Connect-PartnerCenter](https://docs.microsoft.com/powershell/module/partnercenter/Connect-PartnerCenter) using a certificate

src/PowerShell/Authenticators/AccessTokenAuthenticator.cs

@@ -7,11 +7,11 @@ namespace Microsoft.Store.PartnerCenter.PowerShell.Authenticators
     using System.Security.Claims;
     using System.Threading;
     using System.Threading.Tasks;
+    using Exceptions;
     using Extensions;
     using Identity.Client;
     using IdentityModel.JsonWebTokens;
     using Models.Authentication;
-    using PartnerCenter.Exceptions;
     using Rest;
 
     /// <summary>
@@ -38,7 +38,7 @@ public override async Task<AuthenticationResult> AuthenticateAsync(Authenticatio
 
             if (DateTimeOffset.UtcNow > token.ValidTo)
             {
-                throw new PartnerException("The access token has expired. Generate a new one and try again.");
+                throw new PartnerPowerShellException("The access token has expired. Generate a new one and try again.", PartnerPowerShellErrorCategory.TokenExpired);
             }
 
             await Task.CompletedTask.ConfigureAwait(false);

src/PowerShell/Authenticators/DefaultAuthenticatorBuilder.cs

@@ -44,14 +44,11 @@ public void AppendAuthenticator(Func<IAuthenticator> constructor)
 
             IAuthenticator current;
 
-
-            for (current = Authenticator; current != null && current.Next != null; current = current.Next)
+            for (current = Authenticator; current != null && current.NextAuthenticator != null; current = current.NextAuthenticator)
             {
-                ;
             }
 
-            current.Next = constructor();
-            return;
+            current.NextAuthenticator = constructor();
         }
     }
 }

src/PowerShell/Authenticators/DelegatingAuthenticator.cs

@@ -19,7 +19,7 @@ internal abstract class DelegatingAuthenticator : IAuthenticator
         /// <summary>
         /// Gets or sets the next authenticator in the chain.
         /// </summary>
-        public IAuthenticator Next { get; set; }
+        public IAuthenticator NextAuthenticator { get; set; }
 
         /// <summary>
         /// Apply this authenticator to the given authentication parameters.
@@ -84,9 +84,9 @@ public async Task<AuthenticationResult> TryAuthenticateAsync(AuthenticationParam
                 return await AuthenticateAsync(parameters, cancellationToken).ConfigureAwait(false);
             }
 
-            if (Next != null)
+            if (NextAuthenticator != null)
             {
-                return await Next.TryAuthenticateAsync(parameters, cancellationToken).ConfigureAwait(false);
+                return await NextAuthenticator.TryAuthenticateAsync(parameters, cancellationToken).ConfigureAwait(false);
             }
 
             return null;

src/PowerShell/Authenticators/IAuthenticator.cs

@@ -15,7 +15,7 @@ public interface IAuthenticator
         /// <summary>
         /// Gets or sets the next authenticator in the chain.
         /// </summary>
-        IAuthenticator Next { get; set; }
+        IAuthenticator NextAuthenticator { get; set; }
 
         /// <summary>
         /// Apply this authenticator to the given authentication parameters.

src/PowerShell/Commands/ConnectPartnerCenter.cs

@@ -8,10 +8,10 @@ namespace Microsoft.Store.PartnerCenter.PowerShell.Commands
     using System.Management.Automation;
     using System.Reflection;
     using System.Text.RegularExpressions;
-    using Exceptions;
     using Extensions;
     using Factories;
     using Models.Authentication;
+    using PartnerCenter.Exceptions;
     using PartnerCenter.Models.Partners;
     using Utilities;
 

src/PowerShell/Commands/DisconnectPartnerCenter.cs

@@ -18,7 +18,6 @@ protected override void ProcessRecord()
             if (ShouldProcess(Resources.DisconnectWhatIf))
             {
                 PartnerSession.Instance.Context = null;
-                PartnerService.Instance.EnforceMfa = false;
             }
         }
     }

src/PowerShell/Commands/GetPartnerInvoiceLineItem.cs

@@ -11,6 +11,7 @@ namespace Microsoft.Store.PartnerCenter.PowerShell.Commands
     using PartnerCenter.Enumerators;
     using PartnerCenter.Models;
     using PartnerCenter.Models.Invoices;
+    using RequestContext;
 
     /// <summary>
     /// Gets a list of line items for the specified invoice from Partner Center.
@@ -78,7 +79,7 @@ public override void ExecuteCmdlet()
                 while (enumerator.HasValue)
                 {
                     items.AddRange(enumerator.Current.Items);
-                    await enumerator.NextAsync(null, CancellationToken).ConfigureAwait(false);
+                    await enumerator.NextAsync(RequestContextFactory.Create(CorrelationId), CancellationToken).ConfigureAwait(false);
                 }
 
                 if (LineItemType == InvoiceLineItemType.BillingLineItems)

src/PowerShell/Commands/NewPartnerAccessToken.cs

@@ -312,7 +312,7 @@ private static string ExtractExistingOrEmptyString(JObject json, string key)
             if (json.TryGetValue(key, out JToken val))
             {
                 json.Remove(key);
-                return val.ToObject<string>(); ;
+                return val.ToObject<string>();
             }
 
             return string.Empty;

src/PowerShell/Commands/NewPartnerCustomer.cs

@@ -7,9 +7,9 @@ namespace Microsoft.Store.PartnerCenter.PowerShell.Commands
     using System.Globalization;
     using System.Management.Automation;
     using System.Text.RegularExpressions;
+    using Exceptions;
     using Models.Authentication;
     using Models.Customers;
-    using PartnerCenter.Exceptions;
     using PartnerCenter.Models;
     using Properties;
     using Validations;
@@ -212,7 +212,7 @@ public override void ExecuteCmdlet()
 
                         if (!await validator.IsValidAsync(customer.BillingProfile.DefaultAddress, CancellationToken).ConfigureAwait(false))
                         {
-                            throw new PartnerException("The address for the customer is not valid.");
+                            throw new PartnerPowerShellException("The address for the customer is not valid.", PartnerPowerShellErrorCategory.Validation);
                         }
                     }