Auditing and utilization feature update (#111)

* Auditing feature update and added PowerShell tasks to the build process

Author: idwilliams-2

ChangeLog.md

@@ -22,16 +22,18 @@
 
 ## Upcoming Release
 
-* Invoices 
+* Auditing
+  * Renamed the CreateInvoice operation type to ReadyInvoice.
+* Invoices
   * Renamed the reconciliation line item objects
 * Users
-  * No longer throw an error when searching for a user with UPN that does not exists. 
-* Utilization 
+  * No longer throw an error when searching for a user with UPN that does not exists.
+* Utilization
   * Modified the default end date value for the Get-PartnerCustomerSubscriptionUtilization command to use UTC time.
 
 ## 1.5.1903.6
 
-* Products 
+* Products
   * Addressed an issue with requesting products
 
 ## 1.5.1903.5

azure-pipelines.yml

@@ -1,17 +1,26 @@
-# .NET Desktop
-# Build and run tests for .NET Desktop or Windows classic desktop solutions.
-# Add steps that publish symbols, save build artifacts, and more:
-# https://docs.microsoft.com/azure/devops/pipelines/apps/windows/dot-net
+strategy:
+  matrix:
+    Windows:
+      imageName: 'Windows-2019'
 
 trigger:
 - master
 
 pool:
-  vmImage: 'Windows-2019'
+  vmImage: $(imageName)
 
 variables:
   buildConfiguration: 'Release'
 
 steps:
 - script: dotnet build --configuration $(buildConfiguration)
-  displayName: 'dotnet build $(buildConfiguration)'
+  displayName: 'dotnet build $(buildConfiguration)'
+
+- pwsh: 'Install-Module platyPS -Force -Confirm:$false -Scope CurrentUser'
+  displayName: 'Install platyPS'
+
+- pwsh: 'New-ExternalHelp -Path .\docs\help\ -OutputPath .\src\PowerShell\bin\Release\netstandard2.0'
+  displayName: 'Generate MAML'
+
+- pwsh: 'Test-ModuleManifest .\src\PowerShell\bin\Release\net461\PartnerCenter.psd1'
+  displayName: 'Validate Manifest (.NET Framework)'

build/PartnerCenter.NetCore.nuspec

@@ -2,7 +2,7 @@
 <package>
 <metadata>
   <id>PartnerCenter.NetCore</id>
-  <version>1.5.1903.2</version>
+  <version>1.5.1904.1</version>
   <authors>Microsoft Corporation</authors>
   <owners>Microsoft</owners>
   <requireLicenseAcceptance>false</requireLicenseAcceptance>

build/PartnerCenter.nuspec

@@ -2,7 +2,7 @@
 <package>
 <metadata>
   <id>PartnerCenter</id>
-  <version>1.5.1903.2</version>
+  <version>1.5.1904.1</version>
   <authors>Microsoft Corporation</authors>
   <owners>Microsoft</owners>
   <requireLicenseAcceptance>false</requireLicenseAcceptance>

src/PartnerCenter.TestFramework/GlobalSuppressions.cs

@@ -0,0 +1,11 @@
+
+// This file is used by Code Analysis to maintain SuppressMessage 
+// attributes that are applied to this project.
+// Project-level suppressions either have no target or are given 
+// a specific target and scoped to a namespace, type, member, etc.
+
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "Used to detect the content type.", Scope = "member", Target = "~M:Microsoft.Store.PartnerCenter.TestFramework.Network.HttpUtilities.IsXml(System.String)~System.Boolean")]
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "Used to detect the content type.", Scope = "member", Target = "~M:Microsoft.Store.PartnerCenter.TestFramework.Network.HttpUtilities.TryFormatJson(System.String)~System.String")]
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "Used to detect the content type.", Scope = "member", Target = "~M:Microsoft.Store.PartnerCenter.TestFramework.Network.HttpUtilities.CreateHttpContent(System.String)~System.Net.Http.HttpContent")]
+[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "When an exception is encountered the unmodified content should be returned.", Scope = "member", Target = "~M:Microsoft.Store.PartnerCenter.TestFramework.Network.HttpUtilities.TryFormatXml(System.String)~System.String")]
+

src/PartnerCenter.TestFramework/Network/HttpUtilities.cs

@@ -148,7 +148,7 @@ public static bool IsXml(string content)
                 XDocument.Parse(content);
                 return true;
             }
-            catch (Exception)
+            catch
             {
                 return false;
             }

src/PartnerCenter.TestFramework/PartnerCenter.TestFramework.csproj

@@ -12,12 +12,12 @@
     <PackageProjectUrl>https://github.com/Microsoft/Partner-Center-PowerShell</PackageProjectUrl>
     <RepositoryUrl>https://github.com/Microsoft/Partner-Center-PowerShell.git</RepositoryUrl>
     <RepositoryType>git</RepositoryType>
-    <Version>1.5.1903.7</Version>
+    <Version>1.5.1904.1</Version>
     <NeutralLanguage>en-US</NeutralLanguage>
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.9.0">
+    <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.9.1">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
     </PackageReference>

src/PartnerCenter/Models/Auditing/OperationType.cs

@@ -202,8 +202,8 @@ public enum OperationType
         IncreaseCreditLimit = 36,
 
         /// <summary>
-        /// Create invoice
+        /// An invoice is ready
         /// </summary>
-        CreateInvoice = 37
+        ReadyInvoice = 37
     }
 }

src/PartnerCenter/PartnerCenter.csproj

@@ -9,7 +9,7 @@
     <Copyright>Copyright ©  2019</Copyright>
     <NeutralLanguage>en-US</NeutralLanguage>
     <Product>Microsoft Partner Center</Product>
-    <Version>1.5.1903.7</Version>
+    <Version>1.5.1904.1</Version>
     <PackageLicenseUrl>https://github.com/Microsoft/Partner-Center-PowerShell/blob/master/LICENSE</PackageLicenseUrl>
     <PackageProjectUrl>https://github.com/Microsoft/Partner-Center-PowerShell</PackageProjectUrl>
     <RepositoryUrl>https://github.com/Microsoft/Partner-Center-PowerShell.git</RepositoryUrl>
@@ -48,7 +48,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.9.0">
+    <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.9.1">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
     </PackageReference>

src/PowerShell/Commands/GetPartnerCustomerSubscriptionUtilization.cs

@@ -81,7 +81,7 @@ public override void ExecuteCmdlet()
                     StartDate,
                     EndDate ?? DateTimeOffset.UtcNow,
                     Granularity ?? AzureUtilizationGranularity.Daily,
-                    (!ShowDetails.IsPresent) || ShowDetails.ToBool()).GetAwaiter().GetResult();
+                    (!ShowDetails.IsPresent) || ShowDetails.ToBool()).ConfigureAwait(false).GetAwaiter().GetResult();
 
             if (utilizationRecords?.TotalCount > 0)
             {
@@ -92,7 +92,7 @@ public override void ExecuteCmdlet()
                 while (enumerator.HasValue)
                 {
                     records.AddRange(enumerator.Current.Items.Select(r => new PSAzureUtilizationRecord(r)));
-                    enumerator.NextAsync().GetAwaiter().GetResult();
+                    enumerator.NextAsync().ConfigureAwait(false).GetAwaiter().GetResult();
                 }
 
                 WriteObject(records, true);