CmdPal: Update the shell provider to be run (#47642)

This PR updates the shell command provider to work (almost) exactly like
run. The current shell provider is close, but not technically correct.
It does enumerate files. Sure. But as it turns out, it doesn't enumerate
things **exactly** correctly. It doesn't handle network paths super
well. It doesn't handle NTFS file paths. Basically, there's a lot of
weird edge cases in the way the run dialog enumerates file paths for
suggestions. And the only way to match that is to just use the code from
the old run dialog.

This is code that is taken pretty verbatim from the new run dialog.
Instead of trying to enumerate paths manually and shellexecuting command
lines, We're using the actual APIs that the original run dialog used,
more or less. They've been pretty much ported to C#.

This should make us feel just as correct as the original run dialog did.
And exactly the same as the new Run dialog.

The one major change is the introduction of a static item at the top of
the list for running the command that the user typed. This command is
used to just immediately take whatever is in the search box and fire it
off as the command the user typed. This is essentially what happens with
the run dialog. When you press the button, we run the command in the
text box.

See: [The new Run dialog: faster, cleaner, and more capable - Windows
Command
Line](https://devblogs.microsoft.com/commandline/the-new-run-dialog-faster-cleaner-and-more-capable/)

Honestly, most of this PR is just deleting the files we no longer need
from the shell list provider and adding the tests from the OS side here.

I also had to update CsWinRT for this.

Author: zadjii-msft

.github/actions/spell-check/allow/code.txt

@@ -353,8 +353,15 @@ WINDOWPOS
 WINEVENTPROC
 WORKERW
 FULLSCREENAPP
+ACLO
+CACLI
+DOENVSUBST
+FILESYSONLY
+URLIS
+WAITTIMEOUT
 DEFAULTTONEAREST
 
+
 # COM/WinRT interface prefixes and type fragments
 BAlt
 BShift

Directory.Packages.props

@@ -1,4 +1,4 @@
-<Project>
+<Project>
   <PropertyGroup>
     <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
     <CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
@@ -69,7 +69,7 @@
     <PackageVersion Include="Microsoft.Win32.SystemEvents" Version="10.0.7" />
     <PackageVersion Include="Microsoft.WindowsPackageManager.ComInterop" Version="1.10.340" />
     <PackageVersion Include="Microsoft.Windows.Compatibility" Version="10.0.7" />
-    <PackageVersion Include="Microsoft.Windows.CsWin32" Version="0.3.183" />
+    <PackageVersion Include="Microsoft.Windows.CsWin32" Version="0.3.269" />
     <!-- CsWinRT version needs to be set to have a WinRT.Runtime.dll at the same version contained inside the NET SDK we're currently building on CI. -->
     <!-- 
       TODO: in Common.Dotnet.CsWinRT.props, on upgrade, verify RemoveCsWinRTPackageAnalyzer is no longer needed.  

src/modules/cmdpal/Microsoft.CmdPal.Common/Services/IRunHistoryService.cs

@@ -6,6 +6,8 @@ namespace Microsoft.CmdPal.Common.Services;
 
 public interface IRunHistoryService
 {
+    long RunCommand(string commandLine, string workingDir, bool asAdmin, ulong hwnd);
+
     /// <summary>
     /// Gets the run history.
     /// </summary>
@@ -22,6 +24,13 @@ public interface IRunHistoryService
     /// </summary>
     /// <param name="item">The run history item to add.</param>
     void AddRunHistoryItem(string item);
+
+    /// <summary>
+    /// Parses a command line into its components.
+    /// </summary>
+    ParseCommandlineResult ParseCommandline(string commandLine, string workingDirectory);
+
+    string QualifyCommandLineDirectory(string commandLine, string fullFilePath, string defaultDirectory);
 }
 
 public interface ITelemetryService
@@ -31,4 +40,16 @@ public interface ITelemetryService
     void LogRunCommand(string command, bool asAdmin, bool success);
 
     void LogOpenUri(string uri, bool isWeb, bool success);
+
+    void LogEvent(string eventName, IDictionary<string, object>? properties = null);
+}
+
+public struct ParseCommandlineResult
+{
+    public int Result; // HRESULT
+    public bool IsUri;
+    public string FilePath;
+    public string Arguments;
+
+    public bool Success => Result == 0;
 }

src/modules/cmdpal/Microsoft.CmdPal.Common/Services/Sanitizer/ErrorReportSanitizer.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation
+// Copyright (c) Microsoft Corporation
 // The Microsoft Corporation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
@@ -22,8 +22,7 @@ private static void OnGuardrailTriggered(GuardrailEventArgs eventArgs)
     private static IEnumerable<ISanitizationRuleProvider> BuildProviders()
     {
         // Order matters
-        return
-        [
+        return (ISanitizationRuleProvider[])[
             new PiiRuleProvider(),
             new UrlRuleProvider(),
             new NetworkRuleProvider(),

src/modules/cmdpal/Microsoft.CmdPal.UI.ViewModels/Models/ExtensionWrapper.cs

@@ -192,7 +192,7 @@ public async Task<IEnumerable<T>> GetListOfProvidersAsync<T>()
         }
         else if (supportedProviders is T singleProviderSupported)
         {
-            return [singleProviderSupported];
+            return (T[])[singleProviderSupported];
         }
 
         return Enumerable.Empty<T>();

src/modules/cmdpal/Microsoft.CmdPal.UI/Events/RunEvents.cs

@@ -76,5 +76,210 @@ public CmdPalOpenUri(string uri, bool isWeb, bool success)
     }
 }
 
+[EventData]
+[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)]
+public class CmdPalRunBuildListPathResolution : EventBase, IEvent
+{
+    public PartA_PrivTags PartA_PrivTags => PartA_PrivTags.ProductAndServiceUsage;
+
+    public string NewSearch { get; set; }
+
+    public string CorrectedSearchText { get; set; }
+
+    public string Expanded { get; set; }
+
+    public bool WithLeadingTilde { get; set; }
+
+    public bool CouldResolvePath { get; set; }
+
+    public bool IsFile { get; set; }
+
+    public long DurationMs { get; set; }
+
+    public int Result { get; set; }
+
+    public CmdPalRunBuildListPathResolution(
+        string newSearch,
+        string correctedSearchText,
+        string expanded,
+        bool withLeadingTilde,
+        bool couldResolvePath,
+        bool isFile,
+        long durationMs,
+        int result)
+    {
+        EventName = "CmdPal_Run_BuildListPathResolution";
+        NewSearch = newSearch;
+        CorrectedSearchText = correctedSearchText;
+        Expanded = expanded;
+        WithLeadingTilde = withLeadingTilde;
+        CouldResolvePath = couldResolvePath;
+        IsFile = isFile;
+        DurationMs = durationMs;
+        Result = result;
+    }
+}
+
+[EventData]
+[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)]
+public class CmdPalRunCreatePathItemsResolvedPath : EventBase, IEvent
+{
+    public PartA_PrivTags PartA_PrivTags => PartA_PrivTags.ProductAndServiceUsage;
+
+    public string FullFilePath { get; set; }
+
+    public string SearchText { get; set; }
+
+    public string DirectoryPath { get; set; }
+
+    public CmdPalRunCreatePathItemsResolvedPath(string fullFilePath, string searchText, string directoryPath)
+    {
+        EventName = "CmdPal_Run_CreatePathItemsResolvedPath";
+        FullFilePath = fullFilePath;
+        SearchText = searchText;
+        DirectoryPath = directoryPath;
+    }
+}
+
+[EventData]
+[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)]
+public class CmdPalRunCreatePathItemsFiltered : EventBase, IEvent
+{
+    public PartA_PrivTags PartA_PrivTags => PartA_PrivTags.ProductAndServiceUsage;
+
+    public string Dir { get; set; }
+
+    public string FuzzyString { get; set; }
+
+    public int FilteredCount { get; set; }
+
+    public CmdPalRunCreatePathItemsFiltered(string dir, string fuzzyString, int filteredCount)
+    {
+        EventName = "CmdPal_Run_CreatePathItemsFiltered";
+        Dir = dir;
+        FuzzyString = fuzzyString;
+        FilteredCount = filteredCount;
+    }
+}
+
+[EventData]
+[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)]
+public class CmdPalRunCreatePathItemsChangedDirectory : EventBase, IEvent
+{
+    public PartA_PrivTags PartA_PrivTags => PartA_PrivTags.ProductAndServiceUsage;
+
+    public string OldDir { get; set; }
+
+    public string NewDir { get; set; }
+
+    public CmdPalRunCreatePathItemsChangedDirectory(string oldDir, string newDir)
+    {
+        EventName = "CmdPal_Run_CreatePathItemsChangedDirectory";
+        OldDir = oldDir;
+        NewDir = newDir;
+    }
+}
+
+[EventData]
+[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)]
+public class CmdPalRunBuildItemsForDirectory : EventBase, IEvent
+{
+    public PartA_PrivTags PartA_PrivTags => PartA_PrivTags.ProductAndServiceUsage;
+
+    public string Dir { get; set; }
+
+    public int FileCount { get; set; }
+
+    public CmdPalRunBuildItemsForDirectory(string dir, int fileCount)
+    {
+        EventName = "CmdPal_Run_BuildItemsForDirectory";
+        Dir = dir;
+        FileCount = fileCount;
+    }
+}
+
+[EventData]
+[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)]
+public class CmdPalRunLoadHistory : EventBase, IEvent
+{
+    public PartA_PrivTags PartA_PrivTags => PartA_PrivTags.ProductAndServiceUsage;
+
+    public int ItemsToLoad { get; set; }
+
+    public int ItemsLoaded { get; set; }
+
+    public long DurationMs { get; set; }
+
+    public CmdPalRunLoadHistory(int itemsToLoad, int itemsLoaded, long durationMs)
+    {
+        EventName = "CmdPal_Run_LoadHistory";
+        ItemsToLoad = itemsToLoad;
+        ItemsLoaded = itemsLoaded;
+        DurationMs = durationMs;
+    }
+}
+
+[EventData]
+[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)]
+public class CmdPalRunLoadHistoryItem : EventBase, IEvent
+{
+    public PartA_PrivTags PartA_PrivTags => PartA_PrivTags.ProductAndServiceUsage;
+
+    public string Type { get; set; }
+
+    public bool TimedOut { get; set; }
+
+    public long TotalMs { get; set; }
+
+    public long ParseMs { get; set; }
+
+    public bool IsUri { get; set; }
+
+    public string Target { get; set; }
+
+    public string Args { get; set; }
+
+    public int ParseResult { get; set; }
+
+    public CmdPalRunLoadHistoryItem(
+        string type,
+        bool timedOut,
+        long totalMs,
+        long parseMs,
+        bool isUri,
+        string target,
+        string args,
+        int parseResult)
+    {
+        EventName = "CmdPal_Run_LoadHistoryItem";
+        Type = type;
+        TimedOut = timedOut;
+        TotalMs = totalMs;
+        ParseMs = parseMs;
+        IsUri = isUri;
+        Target = target;
+        Args = args;
+        ParseResult = parseResult;
+    }
+}
+
+[EventData]
+[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)]
+public class CmdPalGenericLogEvent : EventBase, IEvent
+{
+    public PartA_PrivTags PartA_PrivTags => PartA_PrivTags.ProductAndServiceUsage;
+
+    public string Name { get; set; }
+
+    public string Message { get; set; }
+
+    public CmdPalGenericLogEvent(string name, string message)
+    {
+        EventName = "CmdPal_GenericLogEvent";
+        Name = name;
+        Message = message;
+    }
+}
+
 #pragma warning restore SA1649 // File name should match first type name
 #pragma warning restore SA1402 // File may only contain a single type