Skip to content

Fix VS Code Workspaces shared storage lookup#47505

Open
MardSilva wants to merge 1 commit into
microsoft:mainfrom
MardSilva:BugFix-47445
Open

Fix VS Code Workspaces shared storage lookup#47505
MardSilva wants to merge 1 commit into
microsoft:mainfrom
MardSilva:BugFix-47445

Conversation

@MardSilva
Copy link
Copy Markdown

Summary

Fixes VS Code Workspaces recent entries discovery after VS Code 1.118 moved history.recentlyOpenedPathsList to the shared application storage database.

The plugin now probes both the legacy User/globalStorage/state.vscdb database and the new shared storage database for VS Code Stable, Insiders, Exploration, VSCodium, VSCodium Insiders, and portable installs.

It also deduplicates results that may appear in both locations.

Fixes #47445

Validation

  • Reviewed the change against the issue's documented VS Code 1.118 storage paths.
  • Attempted local focused build from src/modules/launcher/Plugins/Community.PowerToys.Run.Plugin.VSCodeWorkspaces with tools/build/build.cmd -Platform x64 -Configuration Debug.
  • Build was blocked by local environment/tooling issues unrelated to this C# change: missing/invalid VC tooling/Windows SDK.

Read recently opened VS Code workspaces from the shared storage database introduced in VS Code 1.118 while keeping the legacy storage fallback.

Fixes microsoft#47445
@MardSilva
Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

Copy link
Copy Markdown
Collaborator

@davidegiacometti davidegiacometti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! The number of projects has grown a lot since my last PowerToys build! 😄

It also looks like the workspace path changed in the latest VS Code updates.
Even though I wasn’t able to test it with all VS Code editions, I can confirm I am able to reproduce the issue with PowerToys 0.99.1 and VS Code 1.121.0, and this PR fixes it.

The changes look good to me and the introduced code also looks very safe.
LGTM 👍

Thanks for the fix @MardSilva

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PowerToys Run VS Code plugin - No results since vscode 1.118

2 participants