Skip to content

Move from testing to final for telemetry PR detection workflow#47993

Open
chatasweetie wants to merge 4 commits into
mainfrom
jearleycha/telemetry-pr-check-complete
Open

Move from testing to final for telemetry PR detection workflow#47993
chatasweetie wants to merge 4 commits into
mainfrom
jearleycha/telemetry-pr-check-complete

Conversation

@chatasweetie
Copy link
Copy Markdown
Contributor

Summary of the Pull Request

Transitions the telemetry PR detection workflow from testing phase to ready status. All components are now fully functional and automatically triggered on every new PR.

  • Skips checks on draft PRs to avoid noise
  • Prevents multiple concurrent runs per PR
  • Safely requests @chatasweetie as reviewer on telemetry changes
  • update commit messages

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end-user-facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@chatasweetie chatasweetie requested a review from a team as a code owner May 19, 2026 22:09
@chatasweetie chatasweetie requested review from Copilot and niels9001 May 19, 2026 22:09
@niels9001 niels9001 requested a review from carlos-zamora May 19, 2026 22:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Moves the telemetry PR detection workflow messaging from “test” language to final guidance and adds automatic reviewer requesting for telemetry-related PRs.

Changes:

  • Updates the bot comment bodies to remove “test” messaging and provide actionable checklists.
  • Adds helper functions to fetch PR details and request a specific reviewer when needed.
  • Centralizes reviewer login in a constant.

Comment thread .github/scripts/telemetry-pr-check.js Outdated
Comment thread .github/scripts/telemetry-pr-check.js Outdated
Comment thread .github/scripts/telemetry-pr-check.js Outdated
Comment thread .github/scripts/telemetry-pr-check.js
Comment thread .github/scripts/telemetry-pr-check.js Outdated
Comment thread .github/scripts/telemetry-pr-check.js Outdated
Comment thread .github/scripts/telemetry-pr-check.js Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants