warn instead of raise on schema mismatch

Author: jsong468

pyrit/memory/azure_sql_memory.py

@@ -120,7 +120,8 @@ def __init__(
         if not skip_schema_migration:
             if self._connection_string == prod_connection_string:
                 # Production guard: verify schema compatibility without modifying the database.
-                # This allows normal usage when schemas match, but raises early if there's a mismatch.
+                # Logs a warning on mismatch but does not block startup, so developers on
+                # newer code can still query prod data.
                 self._check_schema_migration(silent=silent)
             else:
                 # For non-production databases, run normal schema migration which will create/update tables as needed.

pyrit/memory/memory_interface.py

@@ -1438,19 +1438,30 @@ def _check_schema_migration(self, *, silent: bool = False) -> None:
         """
         Verify that the current database schema matches the models without modifying the database.
 
+        Logs a warning if the schema does not match, but does not raise or block startup.
+
         Args:
             silent (bool): If True, suppresses Alembic console output. Defaults to False.
 
         Raises:
             RuntimeError: If the engine is not initialized.
-            AutogenerateDiffsDetected: If the schema does not match the models.
         """
+        from alembic.util.exc import AutogenerateDiffsDetected
+
         from pyrit.memory.migration import check_schema_migrations
 
         logger.info("Checking schema migration compatibility.")
         if self.engine is None:
             raise RuntimeError("Engine must be initialized to check schema migrations.")
-        check_schema_migrations(engine=self.engine, silent=silent)
+        try:
+            check_schema_migrations(engine=self.engine, silent=silent)
+        except AutogenerateDiffsDetected:
+            logger.warning(
+                "Schema mismatch detected on production database. "
+                "Your code models differ from the database schema. "
+                "This may cause errors if your code references columns or tables that don't exist. "
+                "Schema was NOT modified."
+            )
 
     def reset_database(self) -> None:
         """

tests/unit/memory/test_azure_sql_memory.py

@@ -653,10 +653,8 @@ def test_init_prod_connection_runs_check_only_not_migration():
         Singleton._instances.update(saved)
 
 
-def test_init_prod_connection_raises_when_schema_mismatches():
-    """When connection matches prod and schema doesn't match models, the check raises."""
-    from alembic.util.exc import AutogenerateDiffsDetected
-
+def test_init_prod_connection_warns_on_schema_mismatch():
+    """When connection matches prod and schema doesn't match, startup succeeds with a warning (no raise)."""
     prod_conn = "Server=tcp:prod.database.windows.net;Database=prod_db;"
     saved = Singleton._instances.copy()
     Singleton._instances.clear()
@@ -665,15 +663,7 @@ def test_init_prod_connection_raises_when_schema_mismatches():
             patch("pyrit.memory.AzureSQLMemory._create_engine"),
             patch("pyrit.memory.AzureSQLMemory._create_auth_token"),
             patch("pyrit.memory.AzureSQLMemory._enable_azure_authorization"),
-            patch.object(
-                AzureSQLMemory,
-                "_check_schema_migration",
-                side_effect=AutogenerateDiffsDetected(
-                    "New upgrade operations detected",
-                    revision_context=MagicMock(),
-                    diffs=[],
-                ),
-            ),
+            patch.object(AzureSQLMemory, "_check_schema_migration") as mock_check,
             patch.dict(
                 "os.environ",
                 {
@@ -683,12 +673,13 @@ def test_init_prod_connection_raises_when_schema_mismatches():
                 },
             ),
         ):
-            with pytest.raises(AutogenerateDiffsDetected):
-                AzureSQLMemory(
-                    connection_string=prod_conn,
-                    results_container_url="https://test.blob.core.windows.net/test",
-                    results_sas_token="valid_sas_token",
-                )
+            # Should not raise — _check_schema_migration warns internally on mismatch
+            AzureSQLMemory(
+                connection_string=prod_conn,
+                results_container_url="https://test.blob.core.windows.net/test",
+                results_sas_token="valid_sas_token",
+            )
+            mock_check.assert_called_once()
     finally:
         Singleton._instances.clear()
         Singleton._instances.update(saved)

tests/unit/memory/test_migration.py

@@ -618,6 +618,35 @@ def test_memory_interface_check_schema_migration_calls_check():
         mock_check.assert_called_once_with(engine=obj.engine, silent=True)
 
 
+def test_memory_interface_check_schema_migration_warns_on_mismatch(caplog):
+    """_check_schema_migration logs a warning instead of raising when schema mismatches."""
+    import logging
+    from unittest.mock import MagicMock, patch
+
+    from alembic.util.exc import AutogenerateDiffsDetected
+
+    from pyrit.memory.memory_interface import MemoryInterface
+
+    obj = MagicMock(spec=MemoryInterface)
+    obj.engine = MagicMock()
+
+    with (
+        patch(
+            "pyrit.memory.migration.check_schema_migrations",
+            side_effect=AutogenerateDiffsDetected(
+                "diffs detected",
+                revision_context=MagicMock(),
+                diffs=[],
+            ),
+        ),
+        caplog.at_level(logging.WARNING),
+    ):
+        # Should NOT raise
+        MemoryInterface._check_schema_migration(obj, silent=True)
+
+    assert "Schema mismatch detected on production database" in caplog.text
+
+
 def test_memory_interface_check_schema_migration_raises_without_engine():
     """_check_schema_migration raises RuntimeError when engine is None."""
     from unittest.mock import MagicMock