MAINT: fix remaining pre-commit failures on main (ty + reST roles) (#1938)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: romanlutz

pyrit/auth/copilot_authenticator.py

@@ -380,6 +380,7 @@ async def _run_playwright_browser_automation_async(self) -> Optional[str]:
         async with async_playwright() as playwright:
             browser = None
             context = None
+            page = None
 
             try:
                 logger.info(f"Launching browser for authentication (headless={self._headless})...")

pyrit/auxiliary_attacks/gcg/data.py

@@ -3,7 +3,7 @@
 
 """CSV → goals/targets loader for the GCG attack.
 
-Decoupled from :class:`GCGGenerator` so that callers with goals and targets
+Decoupled from ``GCGGenerator`` so that callers with goals and targets
 already in memory can pass them straight into ``execute_async`` without going
 through ``pandas`` or any filesystem access.
 """
@@ -34,7 +34,7 @@ def load_goals_and_targets(
             ``train_data`` falls back to whatever default the legacy loader
             returns (an empty list today).
         random_seed (int): Seed used to shuffle the training rows. Defaults
-            to ``42`` to match :class:`GCGAlgorithmConfig`'s default.
+            to ``42`` to match ``GCGAlgorithmConfig``'s default.
 
     Returns:
         tuple[list[str], list[str], list[str], list[str]]:

pyrit/auxiliary_attacks/gcg/experiments/run.py

@@ -1,10 +1,10 @@
 # Copyright (c) Microsoft Corporation.
 # Licensed under the MIT license.
 
-"""Thin CLI wrapper around :meth:`GCGGenerator.execute_async` for AzureML jobs.
+"""Thin CLI wrapper around ``GCGGenerator.execute_async`` for AzureML jobs.
 
-The notebook (or any user) builds a :class:`GCGConfig` (strategy) and a
-:class:`GCGDataConfig` (data) locally, serializes both with their respective
+The notebook (or any user) builds a ``GCGConfig`` (strategy) and a
+``GCGDataConfig`` (data) locally, serializes both with their respective
 ``to_json_file`` methods, ships them to Azure ML as job inputs, and the job's
 command line is::
 
@@ -14,7 +14,7 @@
         --output-dir ${{outputs.results}}
 
 This file deserializes both configs inside the job, loads goals/targets from
-the configured CSV, and runs the attack via a fresh :class:`GCGGenerator`.
+the configured CSV, and runs the attack via a fresh ``GCGGenerator``.
 """
 
 import argparse

pyrit/cli/pyrit_shell.py

@@ -572,7 +572,7 @@ def do_clear(self, arg: str) -> None:
         """Clear the screen."""
         import os
 
-        os.system("cls" if os.name == "nt" else "clear")
+        os.system("cls" if os.name == "nt" else "clear")  # type: ignore[ty:deprecated]
 
     # Shortcuts and aliases
     do_quit = do_exit

pyrit/output/score/pretty.py

@@ -65,7 +65,7 @@ def _render_score(self, score: Score, indent_level: int = 3) -> str:
         """
         lines: list[str] = []
         indent = self._indent * indent_level
-        scorer_name = score.scorer_class_identifier.class_name
+        scorer_name = (score.scorer_class_identifier.class_name if score.scorer_class_identifier else None) or "Unknown"
         lines.append(f"{indent}Scorer: {scorer_name}\n")
         lines.append(self._format_colored(f"{indent}• Category: {score.score_category or 'N/A'}", Fore.LIGHTMAGENTA_EX))
         lines.append(self._format_colored(f"{indent}• Type: {score.score_type}", Fore.CYAN))

pyrit/scenario/scenarios/adaptive/text_adaptive.py

@@ -94,7 +94,7 @@ class TextAdaptive(AdaptiveScenario):
 
     _cached_strategy_class: ClassVar[type[ScenarioStrategy] | None] = None
 
-    VERSION: int = 1
+    VERSION: ClassVar[int] = 1
 
     @classmethod
     def _atomic_attack_prefix(cls) -> str:

pyrit/setup/initializers/components/scenario_techniques.py

@@ -5,9 +5,9 @@
 Scenario technique initializer.
 
 This module owns the canonical catalog of scenario attack techniques as a
-flat list of self-describing :class:`AttackTechniqueFactory` instances and
-registers them into the singleton :class:`AttackTechniqueRegistry` via
-:class:`ScenarioTechniqueInitializer`.
+flat list of self-describing ``AttackTechniqueFactory`` instances and
+registers them into the singleton ``AttackTechniqueRegistry`` via
+``ScenarioTechniqueInitializer``.
 
 Per-name registration is idempotent: pre-existing entries in the registry are
 not overwritten.
@@ -41,14 +41,14 @@ def build_scenario_technique_factories() -> list[AttackTechniqueFactory]:
 
     Factories that need an adversarial chat target do not bake one in; the
     default adversarial target is resolved lazily inside
-    :meth:`AttackTechniqueFactory.create` via
+    ``AttackTechniqueFactory.create`` via
     ``get_default_adversarial_target()``. Scenarios may also pass
     ``attack_adversarial_config_override`` at create time (but only when the
     factory did not bake one in at construction).
 
     A bare ``PromptSendingAttack`` factory is intentionally omitted from the
     catalog: every scenario whose ``BASELINE_ATTACK_POLICY`` is
-    :attr:`BaselineAttackPolicy.Enabled` already auto-prepends an equivalent
+    ``BaselineAttackPolicy.Enabled`` already auto-prepends an equivalent
     baseline atomic attack via ``Scenario._build_baseline_atomic_attack``.
 
     Returns:
@@ -120,7 +120,7 @@ class ScenarioTechniqueInitializer(PyRITInitializer):
     ``Scenario._build_baseline_atomic_attack``) already covers that case.
 
     Registration is per-name idempotent: pre-existing entries in
-    :class:`AttackTechniqueRegistry` are not overwritten.
+    ``AttackTechniqueRegistry`` are not overwritten.
     """
 
     async def initialize_async(self) -> None: