FIX: Coerce typed scenario parameters in scan CLI#2092
Merged
romanlutz merged 3 commits intoJun 29, 2026
Conversation
romanlutz
reviewed
Jun 28, 2026
Replace the bespoke _SCALAR_TYPE_COERCERS / _coerce_bool table in pyrit_scan with the canonical pyrit.models.parameter.Parameter.coerce_value, reached via the shared build_parameters_from_api helper that the shell front-end already uses. This removes a duplicate coercion vocabulary and fixes a cross-CLI divergence: scan previously accepted y/n/on/off boolean tokens that pyrit_shell and the backend reject, so the same scenario flag behaved differently depending on entry point. Scalars, list elements, and Literal choice membership now all go through one code path. Tests updated: choice errors now surface as 'invalid value' (coerce_value) instead of argparse 'invalid choice', and bool typos like 'on' are asserted rejected. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
romanlutz
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tests and Documentation
Documentation changes are not needed for this CLI bug fix.