Fix chat UI stuck loading after first message send failure#2110
Open
romanlutz wants to merge 2 commits into
Open
Fix chat UI stuck loading after first message send failure#2110romanlutz wants to merge 2 commits into
romanlutz wants to merge 2 commits into
Conversation
Ensure ChatWindow marks the active conversation loaded when a send fails after attack creation, preventing indefinite 'Loading conversation...' state. Add an E2E regression covering first-send 500 failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the first message send fails with an HTTP 500 error, the chat UI gets stuck on 'Loading conversation...' indefinitely instead of displaying the error to the user. Users cannot recover or retry.
Root Cause
In ChatWindow.tsx, the send error handler wasn't marking the failed conversation as 'loaded', leaving awaitingConversationLoad in a truthy state. This caused MessageList to render the loading placeholder instead of the error message bubble.
Solution
Modified the send error handler in ChatWindow.tsx to explicitly mark the conversation as loaded before showing the error bubble.
Changes
Testing
✅ Unit tests: 63 pass
✅ Lint: 0 warnings
✅ Build: successful
✅ E2E regression test: passes