Implement B009

Author: jenshnielsen

pyproject.toml

@@ -262,7 +262,7 @@ extend-select = [
 # it may be worth fixing some or these in the future
 # PYI036 disable until https://github.com/astral-sh/ruff/issues/9794 is fixed
 ignore = ["E501", "G004", "PLR2004", "PLR0913", "PLR0911", "PLR0912", "PLR0915", "PLW0602", "PLW0603", "PLW2901", "PYI036",
-    "B018", "B017", "B009","SIM118", "PT014", "LOG015", "PT031",
+    "B018", "B017","SIM118", "PT014", "LOG015", "PT031",
     "DTZ007", "DTZ005", "BLE001", "S110",
     "PIE790", "N999", "PIE804",
     "DTZ006",

src/qcodes/instrument_drivers/stanford_research/SR86x.py

@@ -1292,7 +1292,7 @@ def get_data_channels_parameters(
             method_name = "get_latest"
 
         return tuple(
-            getattr(getattr(self.data_channels[i], "assigned_parameter"), method_name)()
+            getattr(self.data_channels[i].assigned_parameter, method_name)()
             for i in range(self._N_DATA_CHANNELS)
         )
 

src/qcodes/utils/json_utils.py

@@ -61,7 +61,7 @@ def default(self, o: Any) -> Any:
             }
         elif hasattr(o, "_JSONEncoder"):
             # Use object's custom JSON encoder
-            jsosencode = getattr(o, "_JSONEncoder")
+            jsosencode = o._JSONEncoder
             return jsosencode()
         else:
             try:
@@ -82,7 +82,7 @@ def default(self, o: Any) -> Any:
                 ):
                     return {
                         "__class__": type(o).__name__,
-                        "__args__": getattr(o, "__getnewargs__")(),
+                        "__args__": o.__getnewargs__(),
                     }
                 else:
                     # we cannot convert the object to JSON, just take a string

tests/drivers/test_lakeshore_372.py

@@ -62,9 +62,9 @@ def __init__(self, *args, **kwargs) -> None:
                 f = getattr(self, func_name)
                 # only add for methods that have such an attribute
                 with suppress(AttributeError):
-                    self.queries[getattr(f, "query_name")] = f
+                    self.queries[f.query_name] = f
                 with suppress(AttributeError):
-                    self.cmds[getattr(f, "command_name")] = f
+                    self.cmds[f.command_name] = f
 
     def write_raw(self, cmd) -> None:
         cmd_parts = cmd.split(" ")

tests/test_station.py

@@ -619,7 +619,7 @@ def test_setup_alias_parameters() -> None:
     """
     )
     mock = st.load_instrument("mock")
-    p = getattr(mock, "gate_a")
+    p = mock.gate_a
     assert isinstance(p, Parameter)
     assert p.unit == "mV"
     assert p.label == "main gate"
@@ -665,7 +665,7 @@ def test_setup_delegate_parameters() -> None:
     """
     )
     mock = st.load_instrument("mock")
-    p = getattr(mock, "gate_a")
+    p = mock.gate_a
     assert isinstance(p, DelegateParameter)
     assert p.unit == "mV"
     assert p.label == "main gate"