Skip to content

Commit 6482ff0

Browse files
authored
Merge pull request #7644 from hbeukers/add/Keysight33611A_driver
Add Keysight 33611A driver.
2 parents 24202e1 + 94408b2 commit 6482ff0

5 files changed

Lines changed: 18 additions & 1 deletion

File tree

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Added Keysight 33611A driver. (:pr:`7644`)

src/qcodes/instrument_drivers/Keysight/KeysightAgilent_33XXX.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -406,6 +406,7 @@ def __init__(
406406
"33511B": 1,
407407
"33512B": 2,
408408
"33522B": 2,
409+
"33611A": 1,
409410
"33622A": 2,
410411
"33510B": 2,
411412
}
@@ -416,6 +417,7 @@ def __init__(
416417
"33512B": 20e6,
417418
"33250A": 80e6,
418419
"33522B": 30e6,
420+
"33611A": 80e6,
419421
"33622A": 120e6,
420422
"33510B": 20e6,
421423
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
from .KeysightAgilent_33XXX import Keysight33xxxSingleChannel
2+
3+
4+
class Keysight33611A(Keysight33xxxSingleChannel):
5+
"""
6+
QCoDeS driver for the Keysight 33611A waveform generator.
7+
"""

src/qcodes/instrument_drivers/Keysight/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
from .Keysight_33511b import Keysight33511B
1212
from .Keysight_33512b import Keysight33512B
1313
from .Keysight_33522b import Keysight33522B
14+
from .Keysight_33611a import Keysight33611A
1415
from .Keysight_33622a import Keysight33622A
1516
from .Keysight_34410A_submodules import Keysight34410A
1617
from .Keysight_34411A_submodules import Keysight34411A
@@ -88,6 +89,7 @@
8889
"Keysight33511B",
8990
"Keysight33512B",
9091
"Keysight33522B",
92+
"Keysight33611A",
9193
"Keysight33622A",
9294
"Keysight34410A",
9395
"Keysight34411A",

tests/drivers/test_Keysight_33XXX.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
Keysight33511B,
99
Keysight33512B,
1010
Keysight33522B,
11+
Keysight33611A,
1112
Keysight33622A,
1213
)
1314

@@ -75,6 +76,7 @@ def test_wrong_model_warns(
7576
request.addfinalizer(caplog.clear)
7677
request.addfinalizer(Keysight33511B.close_all)
7778
request.addfinalizer(Keysight33512B.close_all)
79+
request.addfinalizer(Keysight33611A.close_all)
7880
request.addfinalizer(Keysight33622A.close_all)
7981

8082
_ = Keysight33511B(
@@ -83,12 +85,15 @@ def test_wrong_model_warns(
8385
_ = Keysight33512B(
8486
"kw_sim_33512b", address="GPIB::1::INSTR", pyvisa_sim_file="Keysight_33xxx.yaml"
8587
)
88+
_ = Keysight33611A(
89+
"kw_sim_33611a", address="GPIB::1::INSTR", pyvisa_sim_file="Keysight_33xxx.yaml"
90+
)
8691
_ = Keysight33622A(
8792
"kw_sim_33622a", address="GPIB::1::INSTR", pyvisa_sim_file="Keysight_33xxx.yaml"
8893
)
8994

9095
warns = [record for record in caplog.records if record.levelname == "WARNING"]
91-
assert len(warns) == 3
96+
assert len(warns) == 4
9297
assert all(
9398
"The driver class name" in record.msg and "does not match the detected model"
9499
for record in warns

0 commit comments

Comments
 (0)