Export inferred parameters related to dependencies#7432
Merged
jenshnielsen merged 15 commits intoSep 24, 2025
Conversation
jenshnielsen
force-pushed
the
add_interdeps_to_xarray
branch
from
4fd8248 to
4616cb2
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7432 +/- ##
==========================================
- Coverage 59.94% 59.93% -0.01%
==========================================
Files 347 347
Lines 31117 31168 +51
==========================================
+ Hits 18653 18681 +28
- Misses 12464 12487 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jenshnielsen
force-pushed
the
add_interdeps_to_xarray
branch
2 times, most recently
from
b8cde31 to
38abf50
Compare
astafan8
approved these changes
Sep 1, 2025
Contributor
astafan8
left a comment
astafan8
left a comment
There was a problem hiding this comment.
pinging @samantha-ho for review as well :)
jenshnielsen
force-pushed
the
add_interdeps_to_xarray
branch
3 times, most recently
from
2965bb2 to
1d6e8e5
Compare
jenshnielsen
commented
Sep 3, 2025
jenshnielsen
force-pushed
the
add_interdeps_to_xarray
branch
from
1d6e8e5 to
49073aa
Compare
jenshnielsen
commented
Sep 3, 2025
jenshnielsen
force-pushed
the
add_interdeps_to_xarray
branch
2 times, most recently
from
8fb3820 to
0856fba
Compare
jenshnielsen
force-pushed
the
add_interdeps_to_xarray
branch
2 times, most recently
from
7e15907 to
1f7fce5
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the xarray export functionality to include inferred parameters related to dependencies. The changes add support for exporting inferred parameters that have the same shape as setpoints as coordinates, and inferred parameters related to data parameters as data variables.
- Adds new method
to_xarray_dataset_dictto replace the deprecatedto_xarray_dataarray_dict - Updates the xarray export logic to include inferred parameters based on their relationships in the dependency graph
- Adds comprehensive test coverage for the new functionality with various parameter relationship scenarios
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/dataset/test_dataset_export.py | Adds type annotations and comprehensive tests for inferred parameter export functionality |
| tests/dataset/measurement/test_inferred_parameters_fix.py | Updates existing tests to verify inferred parameters are now exported as coordinates |
| src/qcodes/dataset/exporters/export_to_xarray.py | Implements core logic for exporting inferred parameters and adds new to_xarray_dataset_dict method |
| src/qcodes/dataset/data_set_protocol.py | Adds protocol definition for new to_xarray_dataset_dict method |
| src/qcodes/dataset/data_set_in_memory.py | Implements to_xarray_dataset_dict method and deprecates old method |
| src/qcodes/dataset/data_set_cache.py | Adds cache support for new dataset dict export method |
| src/qcodes/dataset/data_set.py | Implements to_xarray_dataset_dict method in main DataSet class |
jenshnielsen
force-pushed
the
add_interdeps_to_xarray
branch
from
defc83b to
9dd5a92
Compare
jenshnielsen
force-pushed
the
add_interdeps_to_xarray
branch
from
9dd5a92 to
946f52a
Compare
samantha-ho
approved these changes
Sep 23, 2025
Contributor
samantha-ho
left a comment
samantha-ho
left a comment
There was a problem hiding this comment.
Everything here looks good to me. Nice job!
jenshnielsen
force-pushed
the
add_interdeps_to_xarray
branch
from
5a92f47 to
d0d790e
Compare
jenshnielsen
force-pushed
the
add_interdeps_to_xarray
branch
from
d0d790e to
2a30214
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Export inferred to and from parameters related to setpoints with the same shape as the setpoints when exporting to xarray and the shape is known. Export inferred related to data parameters as data parameters.
TODO