Fix typo in RVA callstack module info extraction (#99)

Author: arvindsh

Engine/StackResolver.cs

@@ -320,7 +320,7 @@ public async Task<string> ResolveCallstacksAsync(List<StackDetails> listOfCallSt
 
                 this.StatusMessage = "Checking for embedded symbol information...";
                 var syms = await ModuleInfoHelper.ParseModuleInfoAsync(listOfCallStacks, cts);
-                if (syms == null) return "Unable to determine symbol information from XML frames - this may be caused by multiple PDB versions in the same input.";
+                if (syms == null) return "Unable to determine symbol information (non-XML frames) - this may be caused by multiple PDB versions in the same input.";
                 if (cts.IsCancellationRequested) { StatusMessage = OperationCanceled; PercentComplete = 0; return OperationCanceled; }
 
                 var symSrvSymPath = string.Empty;
@@ -332,7 +332,7 @@ public async Task<string> ResolveCallstacksAsync(List<StackDetails> listOfCallSt
                     this.StatusMessage = "Looking for embedded XML-formatted frames and symbol information...";
                     // attempt to check if there are XML-formatted frames each with the related PDB attributes and if so replace those lines with the normalized versions
                     (syms, listOfCallStacks) = await ModuleInfoHelper.ParseModuleInfoXMLAsync(listOfCallStacks, cts);
-                    if (syms == null) return "Unable to determine symbol information from XML frames - this may be caused by multiple PDB versions in the same input.";
+                    if (syms == null) return "Unable to determine symbol information from XML frames - this may be caused by incomplete or malformed frames.";
                     if (cts.IsCancellationRequested) { StatusMessage = OperationCanceled; PercentComplete = 0; return OperationCanceled; }
                     if (syms.Count() > 0) {
                         // if the user has provided such a list of module info, proceed to actually use dbghelp.dll / symsrv.dll to download thos PDBs and get local paths for them

Tests/Tests.cs

@@ -599,6 +599,10 @@ private string PrepareLargeXEventInput() {
             var ret = await csr.ResolveCallstacksAsync(await csr.GetListofCallStacksAsync(input, false, cts), pdbPath, false, null, false, true, false, true, false, false, null, cts);
             var expected = "02 sqldk!MemoryClerkInternal::AllocatePagesWithFailureMode+644\r\n03 sqldk!Spinlock<244,2,1>::SpinToAcquireWithExponentialBackoff+349";
             Assert.AreEqual(expected.Trim(), ret.Trim());
+            // modify the input to not have any prior PDB info - this will be an "error" case
+            input = "Frame = <frame id=\"02\" name=\"sqldk.dll\" address = \"0x100440609\"/>\r\n<frame id=\"03\" name=\"sqldk.dll\" address=\"0x10042249f\" />\n";
+            ret = await csr.ResolveCallstacksAsync(await csr.GetListofCallStacksAsync(input, false, cts), pdbPath, false, null, false, true, false, true, false, false, null, cts);
+            Assert.IsTrue(ret.StartsWith("Unable to determine symbol information from XML frames"));
         }
 
         /// End-to-end test with XE histogram target and XML frames.