Use LINQ .Where to filter (CodeQL suggestion) (#95)

Author: arvindsh

Engine/DiaUtil.cs

@@ -74,8 +74,8 @@ internal static bool LocateandLoadPDBs(Dictionary<string, DiaUtil> _diautils, st
                         }
 
                         // if needed, make a last attempt looking for the original module name - but only amongst user-supplied symbol path folder(s)
-                        if (!foundFiles.Any()) foreach (var currPath in userSuppliedSymPath.Split(';').Where(p => Directory.Exists(p))) {
-                                if (!currPath.EndsWith(currentModule)) foundFiles = Directory.EnumerateFiles(currPath, moduleNamesMap[currentModule] + ".pdb", recurse ? SearchOption.AllDirectories : SearchOption.TopDirectoryOnly);
+                        if (!foundFiles.Any()) foreach (var currPath in userSuppliedSymPath.Split(';').Where(p => Directory.Exists(p) && !p.EndsWith(currentModule))) {
+                                foundFiles = Directory.EnumerateFiles(currPath, moduleNamesMap[currentModule] + ".pdb", recurse ? SearchOption.AllDirectories : SearchOption.TopDirectoryOnly);
                             }
 
                         if (foundFiles?.Count() == 1) {  // we need to be sure there is only 1 file which matches

Engine/ModuleInfoHelper.cs

@@ -109,10 +109,6 @@ await Task.Run(() => Parallel.ForEach(listOfCallStacks, currItem => {
                                     }
                                     lock (syms) {
                                         if (syms.TryGetValue(uniqueModuleName, out var existingEntry)) {
-                                            //if (Guid.Parse(reader.GetAttribute("guid")).ToString("N") != existingEntry.PDBGuid || int.Parse(reader.GetAttribute("age")) != existingEntry.PDBAge) {
-                                            //    anyTaskFailed = true;
-                                            //    return;
-                                            //}
                                             if (ulong.MinValue == existingEntry.CalculatedModuleBaseAddress) existingEntry.CalculatedModuleBaseAddress = calcBaseAddress;
                                         } else syms.Add(uniqueModuleName, new Symbol() { PDBName = reader.GetAttribute("pdb").ToLower(), ModuleName = moduleName, PDBAge = int.Parse(pdbAge), PDBGuid = Guid.Parse(pdbGuid).ToString("N").ToUpper(), CalculatedModuleBaseAddress = calcBaseAddress });
                                     }