Handle very large inputs

- Switch to using List<string> instead of string[] to avoid exceeding
  array dimension limits when parsing large inputs.

Author: arvindsh

Engine/DLLOrdinalHelper.cs

@@ -13,12 +13,11 @@ internal void Initialize() {
         }
 
         /// This function loads DLLs from a specified path, so that we can then build the DLL export's ordinal / address map
-        internal string[] LoadDllsIfApplicable(string[] callstackFrames, bool recurse, List<string> dllPaths) {
+        internal List<string> LoadDllsIfApplicable(List<string> callstackFrames, bool recurse, List<string> dllPaths) {
             if (dllPaths == null) return callstackFrames;
 
-            var processedFrames = new string[callstackFrames.Length];
-            for (var idx = 0; idx < callstackFrames.Length; idx++) {
-                var callstack = callstackFrames[idx];
+            var processedFrames = new List<string>(callstackFrames.Count);
+            foreach (var callstack in callstackFrames) {
                 // first we seek out distinct module names in this call stack
                 // note that such frames will only be seen in the call stack when trace flag 3656 is enabled, but there were no PDBs in the BINN folder
                 // sample frames are given below
@@ -47,7 +46,7 @@ internal string[] LoadDllsIfApplicable(string[] callstackFrames, bool recurse, L
 
                 // finally do a pattern based replace the replace method calls a delegate (ReplaceOrdinalWithRealOffset) which figures
                 // out the start address of the ordinal and then computes the actual offset
-                processedFrames[idx] = fullpattern.Replace(callstack, ReplaceOrdinalWithRealOffset);
+                processedFrames.Add(fullpattern.Replace(callstack, ReplaceOrdinalWithRealOffset));
             }
             return processedFrames;
         }

Engine/ModuleInfoHelper.cs

@@ -13,7 +13,7 @@ public async static Task<Dictionary<string, Symbol>> ParseModuleInfoAsync(List<S
             bool anyTaskFailed = false;
             await Task.Run(() => Parallel.ForEach(listOfCallStacks.Where(c => c.Callstack.Contains(",")).Select(c => c.CallstackFrames), lines => {
                 if (cts.IsCancellationRequested) return;
-                Contract.Requires(lines.Length > 0);
+                Contract.Requires(lines.Count > 0);
                 foreach (var line in lines) {
                     if (cts.IsCancellationRequested) return;
                     string moduleName = null, pdbName = null;

Engine/StackDetails.cs

@@ -24,14 +24,23 @@ public string Callstack {
             set { this._callStack = value; }
         }
 
-        public string[] CallstackFrames {
+        public List<string> CallstackFrames {
             get {
                 // sometimes we see call stacks which are arranged horizontally (this typically is seen when copy-pasting directly
                 // from the SSMS XEvent window (copying the callstack field without opening it in its own viewer)
                 // in that case, space is a valid delimiter, and we need to support that as an option
                 var delims = this._framesOnSingleLine ? new char[] { '\t', '\n' } : new char[] { '\n' };
                 if (!this._relookupSource && this._framesOnSingleLine) delims = delims.Append(' ').ToArray();
-                return this._callStack.Replace("\r", string.Empty).Split(delims);
+
+                var result = new List<string>();
+                using (var reader = new StringReader(this._callStack.Replace("\r", string.Empty))) {
+                    string line;
+                    while ((line = reader.ReadLine()) != null) {
+                        result.AddRange(line.Split(delims, StringSplitOptions.RemoveEmptyEntries));
+                    }
+                }
+
+                return result;
             }
         }
         public string Resolvedstack {

Engine/StackResolver.cs

@@ -39,23 +39,26 @@ public async Task<Tuple<int, string>> ExtractFromXELAsync(string[] xelFiles, boo
         }
 
         /// Convert virtual-address only type frames to their module+offset format
-        private string[] PreProcessVAs(string[] callStackLines, CancellationTokenSource cts) {
-            string[] retval = new string[callStackLines.Length];
-            int frameNum = 0;
+        private List<string> PreProcessVAs(List<string> callStackLines, CancellationTokenSource cts) {
+            var retval = new List<string>(callStackLines.Count);
+
             foreach (var currentFrame in callStackLines) {
                 if (cts.IsCancellationRequested) return callStackLines;
-                // let's see if this is an VA-only address
+
+                // Check if the frame is a VA-only address
                 var matchVA = rgxVAOnly.Match(currentFrame);
                 if (matchVA.Success) {
                     ulong virtAddress = Convert.ToUInt64(matchVA.Groups["vaddress"].Value, 16);
-                    retval[frameNum] = TryObtainModuleOffset(virtAddress, out string moduleName, out uint offset)
-                        ? string.Format(CultureInfo.CurrentCulture, "{0}+0x{1:X}", moduleName, offset)
-                        : currentFrame.Trim();
+                    if (TryObtainModuleOffset(virtAddress, out string moduleName, out uint offset)) {
+                        retval.Add(string.Format(CultureInfo.CurrentCulture, "{0}+0x{1:X}", moduleName, offset));
+                    } else {
+                        retval.Add(currentFrame.Trim());
+                    }
+                } else {
+                    retval.Add(currentFrame.Trim());
                 }
-                else retval[frameNum] = currentFrame.Trim();
-
-                frameNum++;
             }
+
             return retval;
         }
 
@@ -83,7 +86,7 @@ public bool IsInputVAOnly(string text) {
         }
 
         /// Runs through each of the frames in a call stack and looks up symbols for each
-        private string ResolveSymbols(Dictionary<string, DiaUtil> _diautils, Dictionary<string, string> moduleNamesMap, string[] callStackLines, string userSuppliedSymPath, string symSrvSymPath, bool searchPDBsRecursively, bool cachePDB, bool includeSourceInfo, bool relookupSource, bool includeOffsets, bool showInlineFrames, List<string> modulesToIgnore, CancellationTokenSource cts) {
+        private string ResolveSymbols(Dictionary<string, DiaUtil> _diautils, Dictionary<string, string> moduleNamesMap, List<string> callStackLines, string userSuppliedSymPath, string symSrvSymPath, bool searchPDBsRecursively, bool cachePDB, bool includeSourceInfo, bool relookupSource, bool includeOffsets, bool showInlineFrames, List<string> modulesToIgnore, CancellationTokenSource cts) {
             var finalCallstack = new StringBuilder();
             int runningFrameNum = int.MinValue;
             foreach (var iterFrame in callStackLines) {