From ef17718db7eae0662d3570616a9ba52f0d70715d Mon Sep 17 00:00:00 2001 From: Arvind Shyamsundar <16342666+arvindshmicrosoft@users.noreply.github.com> Date: Mon, 23 Mar 2026 21:52:30 -0700 Subject: [PATCH] Potential fix for code scanning alert no. 71: Constant condition Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> --- Engine/StackResolver.cs | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/Engine/StackResolver.cs b/Engine/StackResolver.cs index 902dcd6..794944d 100644 --- a/Engine/StackResolver.cs +++ b/Engine/StackResolver.cs @@ -235,11 +235,9 @@ private string ProcessFrameModuleOffset(Dictionary _diautils, D // make sure we cleanup COM allocations for the resolved sym Marshal.FinalReleaseComObject(mysym); result = (inlineFrameAndSourceInfo + symbolizedFrame + "\t" + sourceInfo).Trim(); - if (!resWasCached) { // we only need to add to cache if it was not already cached. - this.rwLockCachedSymbols.AcquireWriterLock(-1); - if (!this.cachedSymbols.ContainsKey(symKey)) this.cachedSymbols.Add(symKey, result); - this.rwLockCachedSymbols.ReleaseWriterLock(); - } + this.rwLockCachedSymbols.AcquireWriterLock(-1); + if (!this.cachedSymbols.ContainsKey(symKey)) this.cachedSymbols.Add(symKey, result); + this.rwLockCachedSymbols.ReleaseWriterLock(); } if (frameNum != int.MinValue) {