Fix tests output. Update dependencies (#36)

Author: a-tarasyuk

README.md

@@ -3,7 +3,13 @@
 [![GitHub license](https://img.shields.io/badge/license-MIT-blue.svg?style=flat-square)](https://github.com/Microsoft/SimpleRestClients/blob/master/LICENSE) [![npm version](https://img.shields.io/npm/v/simplerestclients.svg?style=flat-square)](https://www.npmjs.com/package/simplerestclients) [![npm downloads](https://img.shields.io/npm/dm/simplerestclients.svg?style=flat-square)](https://www.npmjs.com/package/simplerestclients) [![Build Status](https://img.shields.io/travis/Microsoft/SimpleRestClients/master.svg?style=flat-square)](https://travis-ci.org/Microsoft/SimpleRestClients) [![David](https://img.shields.io/david/Microsoft/SimpleRestClients.svg?style=flat-square)](https://github.com/Microsoft/SimpleRestClients)
 [![David](https://img.shields.io/david/dev/Microsoft/SimpleRestClients.svg?style=flat-square)](https://github.com/Microsoft/SimpleRestClients)
 
-A simple set of wrappers for RESTful calls.  Consists of two modules:
+> A simple set of wrappers for RESTful calls.  Consists of two modules:
+
+## Installation
+
+```shell
+npm install --save simplerestclients
+```
 
 ## SimpleWebRequest
 

package.json

@@ -19,28 +19,28 @@
     "synctasks": "^0.3.3"
   },
   "devDependencies": {
-    "@types/faker": "4.1.2",
+    "@types/faker": "4.1.3",
     "@types/jasmine": "2.8.8",
     "@types/jasmine-ajax": "3.1.37",
-    "@types/node": "10.5.1",
+    "@types/node": "10.9.4",
     "faker": "4.1.0",
-    "fork-ts-checker-webpack-plugin": "0.4.2",
-    "jasmine": "3.1.0",
-    "jasmine-core": "3.1.0",
-    "karma": "2.0.4",
+    "fork-ts-checker-webpack-plugin": "0.4.9",
+    "jasmine": "3.2.0",
+    "jasmine-core": "3.2.1",
+    "karma": "3.0.0",
     "karma-chrome-launcher": "2.2.0",
     "karma-jasmine": "1.1.2",
     "karma-jasmine-ajax": "0.1.13",
-    "karma-jasmine-html-reporter": "1.2.0",
+    "karma-jasmine-html-reporter": "1.3.1",
     "karma-sourcemap-loader": "0.3.7",
     "karma-spec-reporter": "0.0.32",
     "karma-webpack": "4.0.0-beta.0",
     "rimraf": "2.6.2",
-    "ts-loader": "4.4.2",
-    "tslint": "5.10.0",
-    "tslint-microsoft-contrib": "5.0.3",
-    "typescript": "2.9.2",
-    "webpack": "4.15.0"
+    "ts-loader": "5.1.0",
+    "tslint": "5.11.0",
+    "tslint-microsoft-contrib": "5.2.1",
+    "typescript": "3.0.3",
+    "webpack": "4.19.0"
   },
   "repository": {
     "type": "git",

src/SimpleWebRequest.ts

@@ -693,7 +693,7 @@ export class SimpleWebRequest<TBody, TOptions extends WebRequestOptions = WebReq
                 if (!body || !_.isObject(body)) {
                     // Response can be null if the responseType does not match what the server actually sends
                     // https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/responseType
-                    
+
                     // Only access responseText if responseType is "text" or "", otherwise it will throw
                     // https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/responseText
                     if ((this._xhr.responseType === 'text' || this._xhr.responseType === '') && this._xhr.responseText) {

test/SimpleWebRequest.spec.ts

@@ -1,7 +1,7 @@
 import * as faker from 'faker';
+import * as SyncTasks from 'synctasks';
 import { SimpleWebRequest, SimpleWebRequestOptions, WebErrorResponse, WebRequestPriority } from '../src/SimpleWebRequest';
 import { DETAILED_RESPONSE } from './helpers';
-import * as SyncTasks from 'synctasks';
 
 describe('SimpleWebRequest', () => {
     let catchExceptions = false;
@@ -79,32 +79,38 @@ describe('SimpleWebRequest', () => {
 
         expect(request.requestHeaders['X-Requested-With']).toEqual(headers['X-Requested-With']);
         expect(request.requestHeaders['Max-Forwards']).toEqual(headers['Max-Forwards']);
-        
+
         request.respondWith({ status });
     });
 
     it('forbids to set Accept header', () => {
+        spyOn(console, 'error');
+
         const headers = {
             'Accept': 'application/xml',
         };
         const method = 'GET';
         const url = faker.internet.url();
+        const error = `Don't set Accept with options.headers -- use it with the options.acceptType property`;
+        const request = new SimpleWebRequest<string>(url, method, {}, () => headers);
 
-        expect(
-            () => new SimpleWebRequest<string>(url, method, {}, () => headers).start()
-        ).toThrowError(`Don't set Accept with options.headers -- use it with the options.acceptType property`);
-
+        expect(() => request.start()).toThrowError(error);
+        expect(console.error).toHaveBeenCalledWith(error);
     });
 
     it('forbids to set Content-Type header', () => {
+        spyOn(console, 'error');
+
         const headers = {
             'Content-Type': 'application/xml',
         };
         const method = 'GET';
         const url = faker.internet.url();
-        expect(
-            () => new SimpleWebRequest<string>(url, method, {}, () => headers).start()
-        ).toThrowError(`Don't set Content-Type with options.headers -- use it with the options.contentType property`);
+        const error = `Don't set Content-Type with options.headers -- use it with the options.contentType property`;
+        const request = new SimpleWebRequest<string>(url, method, {}, () => headers);
+
+        expect(() => request.start()).toThrowError(error);
+        expect(console.error).toHaveBeenCalledWith(error);
     });
 
     describe('blocking', () => {
@@ -115,8 +121,9 @@ describe('SimpleWebRequest', () => {
             SimpleWebRequestOptions.MaxSimultaneousRequests = 0;
             jasmine.clock().install();
         });
+
         afterEach(() => {
-            SimpleWebRequestOptions.MaxSimultaneousRequests = maxRequests; 
+            SimpleWebRequestOptions.MaxSimultaneousRequests = maxRequests;
             jasmine.clock().uninstall();
         });
 
@@ -128,18 +135,20 @@ describe('SimpleWebRequest', () => {
             const onSuccessLow2 = jasmine.createSpy('onSuccessLow2');
             const onSuccessCritical2 = jasmine.createSpy('onSuccessCritical2');
             const status = 200;
-    
+
             new SimpleWebRequest<string>(url, method, { priority: WebRequestPriority.Low }).start().then(onSuccessLow1);
             jasmine.clock().tick(10);
+
             new SimpleWebRequest<string>(url, method, { priority: WebRequestPriority.Critical }).start().then(onSuccessCritical1);
             jasmine.clock().tick(10);
+
             new SimpleWebRequest<string>(url, method, { priority: WebRequestPriority.Low }).start().then(onSuccessLow2);
             jasmine.clock().tick(10);
-            
+
             SimpleWebRequestOptions.MaxSimultaneousRequests = 1;
             // add a new request to kick the queue
             new SimpleWebRequest<string>(url, method, { priority: WebRequestPriority.Critical }).start().then(onSuccessCritical2);
-            
+
             // only one is executed
             expect(jasmine.Ajax.requests.count()).toBe(1);
             jasmine.Ajax.requests.mostRecent().respondWith({status});
@@ -155,7 +164,7 @@ describe('SimpleWebRequest', () => {
             jasmine.Ajax.requests.mostRecent().respondWith({status});
             expect(onSuccessLow2).toHaveBeenCalled();
         });
-    
+
         it('blocks the request with custom promise', () => {
             SimpleWebRequestOptions.MaxSimultaneousRequests = 1;
             const url = faker.internet.url();
@@ -171,7 +180,7 @@ describe('SimpleWebRequest', () => {
             request.respondWith({ status: 200 });
             expect(onSuccess1).toHaveBeenCalled();
         });
-    
+
         it('after the request is unblocked, it\'s returned to the queue with correct priority', () => {
             const url = faker.internet.url();
             const method = 'GET';
@@ -188,7 +197,7 @@ describe('SimpleWebRequest', () => {
             SimpleWebRequestOptions.MaxSimultaneousRequests = 1;
             // add a new request to kick the queue
             new SimpleWebRequest<string>(url, method, { priority: WebRequestPriority.Critical }).start().then(onSuccessCritical);
-            
+
             // unblock the request
             blockDefer.resolve(void 0);
 
@@ -200,11 +209,11 @@ describe('SimpleWebRequest', () => {
             jasmine.Ajax.requests.mostRecent().respondWith({ status: 200 });
             expect(onSuccessHigh).toHaveBeenCalled();
 
-            // and the low priority one gets sent last 
+            // and the low priority one gets sent last
             jasmine.Ajax.requests.mostRecent().respondWith({ status: 200 });
             expect(onSuccessLow).toHaveBeenCalled();
         });
-        
+
         it('checks the blocked function again, once the request is on top of the queue', () => {
             const url = faker.internet.url();
             const method = 'GET';
@@ -216,13 +225,14 @@ describe('SimpleWebRequest', () => {
 
             new SimpleWebRequest<string>(url, method, { priority: WebRequestPriority.Critical }, undefined, blockSpy).start().then(onSuccessCritical);
             jasmine.clock().tick(10);
+
             new SimpleWebRequest<string>(url, method, { priority: WebRequestPriority.High }).start().then(onSuccessHigh);
             jasmine.clock().tick(10);
 
             SimpleWebRequestOptions.MaxSimultaneousRequests = 1;
             // add a new request to kick the queue
             new SimpleWebRequest<string>(url, method, { priority: WebRequestPriority.High }).start().then(onSuccessHigh2);
-            
+
             expect(blockSpy).toHaveBeenCalled();
 
             jasmine.Ajax.requests.mostRecent().respondWith({ status: 200 });
@@ -253,7 +263,7 @@ describe('SimpleWebRequest', () => {
                 expect(err.statusText).toBe('_blockRequestUntil rejected: ' + errorString);
                 done();
             });
-            
+
             blockDefer.reject(errorString);
         });
     });