Merged PR 15134783: Fix comparison with wider type in mldsa_primitives.c

This was found by CodeQL:

> Comparison with wider type at mldsa_primitives.c:792. A loop variable or comparison operand is implicitly widened, potentially causing CWE-190/197/835.

It's not an issue in practice as the max loop bound is `7*8=56` for the largest ML-DSA parameter set, and this is also checked by assertions. However, it's easy to fix the issue by changing to `UINT32`.

Related work items: #60592557

Author: mlindgren

lib/mldsa_primitives.c

@@ -779,7 +779,6 @@ SymCryptMlDsaMatrixCreate(
     SYMCRYPT_ASSERT( nRows <= SYMCRYPT_MLDSA_MATRIX_MAX_NROWS );
     SYMCRYPT_ASSERT( nCols <= SYMCRYPT_MLDSA_MATRIX_MAX_NCOLS );
     SYMCRYPT_ASSERT( cbBuffer == SYMCRYPT_INTERNAL_MLDSA_SIZEOF_MATRIX(nRows, nCols) );
-    SYMCRYPT_ASSERT( (UINT32) nRows * nCols <= UINT8_MAX );
 
     PSYMCRYPT_MLDSA_MATRIX pMatrix = (PSYMCRYPT_MLDSA_MATRIX) pbBuffer;
     SYMCRYPT_ASSERT( pMatrix != NULL );
@@ -789,7 +788,7 @@ SymCryptMlDsaMatrixCreate(
     pMatrix->cbTotalSize = cbBuffer;
 
     PBYTE pbCurrent = pbBuffer + sizeof(SYMCRYPT_MLDSA_MATRIX);
-    for(UINT8 i = 0; i < nRows * nCols; ++i)
+    for(UINT32 i = 0; i < (UINT32) nRows * nCols; ++i)
     {
         SymCryptMlDsaPolyElementCreate( pbCurrent, SYMCRYPT_INTERNAL_MLDSA_SIZEOF_POLYELEMENT );
         pbCurrent += SYMCRYPT_INTERNAL_MLDSA_SIZEOF_POLYELEMENT;