Skip to content

Commit 9b7ede6

Browse files
authored
chore: migrate SynapseML skills to Copilot path (#2559)
## Summary Move the remaining SynapseML repo skill from `.agents/skills/` to `.github/skills/` so Copilot CLI can discover all repo-versioned skills from the documented project-skill path. Add README pointers under `.agents/` for tools or agents that inspect the older convention. ## Prompting Intent The engineer asked to migrate everything to the correct Copilot CLI path and suggested keeping a generic agents pointer. The goal was to make existing skills discoverable by Copilot while avoiding future confusion about `.agents/skills`. ## Linked Sources - User request in current session: migrate everything to the correct path for Copilot CLI and keep a generic agents pointer. - Skill location reference: /home/brwals/.copilot/installed-plugins/copilot-toolkit-marketplace/common/skills/create-skill/references/REFERENCE.md - Prior merged skill PR: #2558 ## Rationale `.github/skills/<name>/` is the documented Copilot CLI project-skill location. Keeping only README pointers under `.agents/` preserves a breadcrumb for other agent conventions without leaving duplicate or stale `SKILL.md` files in a path Copilot CLI may not load.
1 parent 30cda27 commit 9b7ede6

3 files changed

Lines changed: 22 additions & 5 deletions

File tree

.agents/README.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
# Agent configuration
2+
3+
Copilot CLI discovers project skills from `.github/skills/<skill-name>/`.
4+
5+
Do not add `SKILL.md` files under `.agents/skills/`. Keep repo-versioned skills in `.github/skills/` so Copilot CLI can load them consistently.
6+
7+
This directory remains only as a compatibility pointer for agents or tools that inspect `.agents`.

.agents/skills/README.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
# Skills moved
2+
3+
Repo-versioned skills for Copilot CLI live in `.github/skills/`.
4+
5+
Use these paths instead:
6+
7+
- `.github/skills/code-review/`
8+
- `.github/skills/synapseml-local-setup/`
9+
10+
Do not add `SKILL.md` files in this directory.
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
name: code-review
3-
description: Quick review checklist for python and scala code changes before callings it done.
3+
description: Review SynapseML Python and Scala code changes. Use before finalizing PR reviews or implementation changes to check security, compatibility, style, generated code, and targeted tests.
44
---
55

66
# Code Review
@@ -21,8 +21,8 @@ Use this skill when reviewing SynapseML changes.
2121
Apply when changes touch serialization, I/O, network, or authentication code.
2222

2323
### Deserialization (CWE-502)
24-
- [ ] No raw `ObjectInputStream.readObject()` use `SafeObjectInputStream` with an allowlist
25-
- [ ] `resolveClass` allowlist validates array component types — never allowlist the `[` prefix
24+
- [ ] No raw `ObjectInputStream.readObject()`: use `SafeObjectInputStream` with an allowlist
25+
- [ ] `resolveClass` allowlist validates array component types. Never allowlist the `[` prefix
2626
directly; array handling must extract and validate the component class name
2727
- [ ] `resolveProxyClass` is overridden to block or validate dynamic proxy interfaces
2828
- [ ] Allowlist uses package-prefix matching, not blocklisting
@@ -46,7 +46,7 @@ Apply when changes modify public classes, traits, or companion objects.
4646

4747
### Binary Compatibility (JVM)
4848
- [ ] No method signature changes on existing public methods (default parameters
49-
generate synthetic bridges use explicit overloads instead)
49+
generate synthetic bridges; use explicit overloads instead)
5050
- [ ] No removed or renamed public classes, traits, or objects
5151
- [ ] Companion object `extends DefaultParamsReadable[T]` preserved if it existed
5252

@@ -61,7 +61,7 @@ Apply when changes modify public classes, traits, or companion objects.
6161
- [ ] `Wrappable` trait mixed in if the class needs a Python wrapper
6262
- [ ] `SynapseMLLogging` trait mixed in; `logClass()` called in constructor
6363
- [ ] No wildcard imports where explicit imports suffice (`java.io._` → named imports)
64-
- [ ] No RDD API usage DataFrame/Dataset only
64+
- [ ] No RDD API usage. Use DataFrame/Dataset only
6565
- [ ] Lines ≤ 120 chars, files ≤ 800 lines
6666

6767
## Python Checklist

0 commit comments

Comments
 (0)