Skip to content

fix: change event types from MouseEvent to PointerEvent #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 2 commits into from
May 14, 2025
Merged

fix: change event types from MouseEvent to PointerEvent #2016

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2adc713
fix: change event types from MouseEvent to PointerEvent
Bashamega May 7, 2025
ae29b61
-
Bashamega May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10099,7 +10099,7 @@ interface GlobalEventHandlersEventMap {
"canplay": Event;
"canplaythrough": Event;
"change": Event;
"click": MouseEvent;
"click": PointerEvent;
"close": Event;
"compositionend": CompositionEvent;
"compositionstart": CompositionEvent;
Expand Down Expand Up @@ -10244,7 +10244,7 @@ interface GlobalEventHandlers {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/click_event)
*/
onclick: ((this: GlobalEventHandlers, ev: MouseEvent) => any) | null;
onclick: ((this: GlobalEventHandlers, ev: PointerEvent) => any) | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLDialogElement/close_event) */
onclose: ((this: GlobalEventHandlers, ev: Event) => any) | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLCanvasElement/contextlost_event) */
Expand Down Expand Up @@ -30196,7 +30196,7 @@ declare var onchange: ((this: Window, ev: Event) => any) | null;
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/click_event)
*/
declare var onclick: ((this: Window, ev: MouseEvent) => any) | null;
declare var onclick: ((this: Window, ev: PointerEvent) => any) | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLDialogElement/close_event) */
declare var onclose: ((this: Window, ev: Event) => any) | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLCanvasElement/contextlost_event) */
Expand Down
6 changes: 3 additions & 3 deletions baselines/ts5.5/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10089,7 +10089,7 @@ interface GlobalEventHandlersEventMap {
"canplay": Event;
"canplaythrough": Event;
"change": Event;
"click": MouseEvent;
"click": PointerEvent;
"close": Event;
"compositionend": CompositionEvent;
"compositionstart": CompositionEvent;
Expand Down Expand Up @@ -10234,7 +10234,7 @@ interface GlobalEventHandlers {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/click_event)
*/
onclick: ((this: GlobalEventHandlers, ev: MouseEvent) => any) | null;
onclick: ((this: GlobalEventHandlers, ev: PointerEvent) => any) | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLDialogElement/close_event) */
onclose: ((this: GlobalEventHandlers, ev: Event) => any) | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLCanvasElement/contextlost_event) */
Expand Down Expand Up @@ -30174,7 +30174,7 @@ declare var onchange: ((this: Window, ev: Event) => any) | null;
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/click_event)
*/
declare var onclick: ((this: Window, ev: MouseEvent) => any) | null;
declare var onclick: ((this: Window, ev: PointerEvent) => any) | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLDialogElement/close_event) */
declare var onclose: ((this: Window, ev: Event) => any) | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLCanvasElement/contextlost_event) */
Expand Down
6 changes: 3 additions & 3 deletions baselines/ts5.6/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10099,7 +10099,7 @@ interface GlobalEventHandlersEventMap {
"canplay": Event;
"canplaythrough": Event;
"change": Event;
"click": MouseEvent;
"click": PointerEvent;
"close": Event;
"compositionend": CompositionEvent;
"compositionstart": CompositionEvent;
Expand Down Expand Up @@ -10244,7 +10244,7 @@ interface GlobalEventHandlers {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/click_event)
*/
onclick: ((this: GlobalEventHandlers, ev: MouseEvent) => any) | null;
onclick: ((this: GlobalEventHandlers, ev: PointerEvent) => any) | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLDialogElement/close_event) */
onclose: ((this: GlobalEventHandlers, ev: Event) => any) | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLCanvasElement/contextlost_event) */
Expand Down Expand Up @@ -30196,7 +30196,7 @@ declare var onchange: ((this: Window, ev: Event) => any) | null;
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/Element/click_event)
*/
declare var onclick: ((this: Window, ev: MouseEvent) => any) | null;
declare var onclick: ((this: Window, ev: PointerEvent) => any) | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLDialogElement/close_event) */
declare var onclose: ((this: Window, ev: Event) => any) | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLCanvasElement/contextlost_event) */
Expand Down
6 changes: 1 addition & 5 deletions inputfiles/addedTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
},
{
"name": "click",
"type": "MouseEvent"
"type": "PointerEvent"
},
{
"name": "compositionstart",
Expand Down Expand Up @@ -196,10 +196,6 @@
"name": "dblclick",
"type": "MouseEvent"
},
{
"name": "contextmenu",
"type": "MouseEvent"
Copy link
Copy Markdown
Collaborator

@saschanaz saschanaz May 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and auxclick should also be PointerEvent. https://w3c.github.io/pointerevents/#the-click-auxclick-and-contextmenu-events

Copy link
Copy Markdown
Contributor Author

@Bashamega Bashamega May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Copy Markdown
Collaborator

@saschanaz saschanaz May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmmm actually contextmenu and auxclick already has PointerEvent? 🤔 In that case we can remove contextmenu and auxclick here.

Copy link
Copy Markdown
Contributor Author

@Bashamega Bashamega May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, no, they were being overwritten in the overridingTypes, I have just removed them from there.

},
{
"name": "toggle",
"type": "ToggleEvent"
Expand Down