Move the generate comments function down after all the merges#2245
Move the generate comments function down after all the merges#2245github-actions[bot] merged 2 commits intomicrosoft:mainfrom
Conversation
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
saschanaz
left a comment
saschanaz
left a comment
There was a problem hiding this comment.
This way we can't override comments, but we probably won't ever do that. LGTM thus.
| * [MDN Reference](https://developer.mozilla.org/docs/Web/API/CompressionStream) | ||
| */ | ||
| interface CompressionStream extends GenericTransformStream { | ||
| /** The **`readable`** read-only property of the CompressionStream interface returns a ReadableStream. */ |
There was a problem hiding this comment.
Wow, what useless comments... Who is providing these?
There was a problem hiding this comment.
MDN, they are from MDN
There was a problem hiding this comment.
It's a shame we are wasting parsing time and memory on these comments that just restate the annotation 😞
There was a problem hiding this comment.
But some comments are useful
There was a problem hiding this comment.
Some are absolutely, I am just lamenting comments that are just:
interface Foo {
// The **`bar`** read-only property of the Foo interface returns a string
readonly bar: string;
}
|
LGTM. Yeah some comments are basically not anything more than placeholders, but we don't have a great way to filter them without adding some magic, which I don't want to. 😔 |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
3 participants
This way all the interfaces have comments, even overwritten ones.