Porting bugs caught by copilot, wow

jakebailey · jakebailey · commit 5c6162f6c73e · 2026-02-04T13:50:10.000-08:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -53893,7 +53893,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                 // Order unnamed non-reference object types by kind associated type mappers. Reverse mapped types have
                 // neither symbols nor mappers so they're ultimately ordered by unstable type IDs, but given their rarity
                 // this should be fine.
-                let c = getObjectFlags(t1) & ObjectFlags.ObjectTypeKindMask - getObjectFlags(t2) & ObjectFlags.ObjectTypeKindMask;
+                let c = (getObjectFlags(t1) & ObjectFlags.ObjectTypeKindMask) - (getObjectFlags(t2) & ObjectFlags.ObjectTypeKindMask);
                 if (c !== 0) {
                     return c;
                 }
@@ -54087,7 +54087,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
         if (t1 === t2) {
             return 0;
         }
-        if (t1.readonly === t2.readonly) {
+        if (t1.readonly !== t2.readonly) {
             return t1.readonly ? 1 : -1;
         }
         if (t1.elementFlags.length !== t2.elementFlags.length) {

Original file line number	Diff line number	Diff line change
`@@ -53893,7 +53893,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {`
`53893`	`53893`	`// Order unnamed non-reference object types by kind associated type mappers. Reverse mapped types have`
`53894`	`53894`	`// neither symbols nor mappers so they're ultimately ordered by unstable type IDs, but given their rarity`
`53895`	`53895`	`// this should be fine.`
`53896`		`- let c = getObjectFlags(t1) & ObjectFlags.ObjectTypeKindMask - getObjectFlags(t2) & ObjectFlags.ObjectTypeKindMask;`
	`53896`	`+ let c = (getObjectFlags(t1) & ObjectFlags.ObjectTypeKindMask) - (getObjectFlags(t2) & ObjectFlags.ObjectTypeKindMask);`
`53897`	`53897`	`if (c !== 0) {`
`53898`	`53898`	`return c;`
`53899`	`53899`	`}`
`@@ -54087,7 +54087,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {`
`54087`	`54087`	`if (t1 === t2) {`
`54088`	`54088`	`return 0;`
`54089`	`54089`	`}`
`54090`		`- if (t1.readonly === t2.readonly) {`
	`54090`	`+ if (t1.readonly !== t2.readonly) {`
`54091`	`54091`	`return t1.readonly ? 1 : -1;`
`54092`	`54092`	`}`
`54093`	`54093`	`if (t1.elementFlags.length !== t2.elementFlags.length) {`