Assume rootDir is the current configuration directory (#62418)

Author: sheetalkamat

src/compiler/diagnosticMessages.json

@@ -4480,6 +4480,10 @@
         "category": "Error",
         "code": 5010
     },
+    "The common source directory of '{0}' is '{1}'. The 'rootDir' setting must be explicitly set to this or another path to adjust your output's file layout.": {
+        "category": "Error",
+        "code": 5011
+    },
     "Cannot read file '{0}': {1}.": {
         "category": "Error",
         "code": 5012

src/compiler/emitter.ts

@@ -646,7 +646,7 @@ export function getCommonSourceDirectory(
         commonSourceDirectory = getNormalizedAbsolutePath(options.rootDir, currentDirectory);
         checkSourceFilesBelongToPath?.(options.rootDir);
     }
-    else if (options.composite && options.configFilePath) {
+    else if (options.configFilePath) {
         // Project compilations never infer their root from the input source paths
         commonSourceDirectory = getDirectoryPath(normalizeSlashes(options.configFilePath));
         checkSourceFilesBelongToPath?.(commonSourceDirectory);
@@ -664,6 +664,23 @@ export function getCommonSourceDirectory(
     return commonSourceDirectory;
 }
 
+/** @internal */
+export function getComputedCommonSourceDirectory(
+    emittedFiles: readonly string[],
+    currentDirectory: string,
+    getCanonicalFileName: GetCanonicalFileName,
+): string {
+    let commonSourceDirectory = computeCommonSourceDirectoryOfFilenames(emittedFiles, currentDirectory, getCanonicalFileName);
+
+    if (commonSourceDirectory && commonSourceDirectory[commonSourceDirectory.length - 1] !== directorySeparator) {
+        // Make sure directory path ends with directory separator so this string can directly
+        // used to replace with "" to get the relative path of the source file and the relative path doesn't
+        // start with / making it rooted path
+        commonSourceDirectory += directorySeparator;
+    }
+    return commonSourceDirectory;
+}
+
 /** @internal */
 export function getCommonSourceDirectoryOfConfig({ options, fileNames }: ParsedCommandLine, ignoreCase: boolean): string {
     return getCommonSourceDirectory(

src/compiler/moduleNameResolver.ts

@@ -2889,7 +2889,7 @@ function getLoadModuleFromTargetExportOrImport(extensions: Extensions, state: Mo
                 const commonSourceDirGuesses: string[] = [];
                 // A `rootDir` compiler option strongly indicates the root location
                 // A `composite` project is using project references and has it's common src dir set to `.`, so it shouldn't need to check any other locations
-                if (state.compilerOptions.rootDir || (state.compilerOptions.composite && state.compilerOptions.configFilePath)) {
+                if (state.compilerOptions.rootDir || state.compilerOptions.configFilePath) {
                     const commonDir = toAbsolutePath(getCommonSourceDirectory(state.compilerOptions, () => [], state.host.getCurrentDirectory?.() || "", getCanonicalFileName));
                     commonSourceDirGuesses.push(commonDir);
                 }

src/compiler/program.ts

@@ -109,6 +109,7 @@ import {
     GetCanonicalFileName,
     getCommonSourceDirectory as ts_getCommonSourceDirectory,
     getCommonSourceDirectoryOfConfig,
+    getComputedCommonSourceDirectory,
     getDeclarationDiagnostics as ts_getDeclarationDiagnostics,
     getDefaultLibFileName,
     getDirectoryPath,
@@ -132,6 +133,7 @@ import {
     getPackageScopeForPath,
     getPathFromPathComponents,
     getPositionOfLineAndCharacter,
+    getRelativePathFromFile,
     getResolvedModuleFromResolution,
     getResolvedTypeReferenceDirectiveFromResolution,
     getResolveJsonModule,
@@ -4254,6 +4256,35 @@ export function createProgram(_rootNamesOrOptions: readonly string[] | CreatePro
             }
         }
 
+        if (
+            !options.noEmit &&
+            !options.composite &&
+            !options.rootDir &&
+            options.configFilePath &&
+            (options.outDir || // there is --outDir specified
+                (getEmitDeclarations(options) && options.declarationDir) || // there is --declarationDir specified
+                options.outFile)
+        ) {
+            // Check if rootDir inferred changed and issue diagnostic
+            const dir = getCommonSourceDirectory();
+            const emittedFiles = mapDefined(files, file => !file.isDeclarationFile && sourceFileMayBeEmitted(file, program) ? file.fileName : undefined);
+            const dir59 = getComputedCommonSourceDirectory(emittedFiles, currentDirectory, getCanonicalFileName);
+            if (dir59 !== "" && getCanonicalFileName(dir) !== getCanonicalFileName(dir59)) {
+                // change in layout
+                createDiagnosticForOption(
+                    /*onKey*/ true,
+                    options.outFile ? "outFile" : options.outDir ? "outDir" : "declarationDir",
+                    !options.outFile && options.outDir ? "declarationDir" : undefined,
+                    chainDiagnosticMessages(
+                        chainDiagnosticMessages(/*details*/ undefined, Diagnostics.Visit_https_Colon_Slash_Slashaka_ms_Slashts6_for_migration_information),
+                        Diagnostics.The_common_source_directory_of_0_is_1_The_rootDir_setting_must_be_explicitly_set_to_this_or_another_path_to_adjust_your_output_s_file_layout,
+                        getBaseFileName(options.configFilePath),
+                        getRelativePathFromFile(options.configFilePath, dir59, getCanonicalFileName),
+                    ),
+                );
+            }
+        }
+
         if (options.checkJs && !getAllowJSCompilerOption(options)) {
             createDiagnosticForOptionName(Diagnostics.Option_0_cannot_be_specified_without_specifying_option_1, "checkJs", "allowJs");
         }

src/compiler/utilities.ts

@@ -6632,7 +6632,7 @@ export function sourceFileMayBeEmitted(sourceFile: SourceFile, host: SourceFileM
     // Json file is not emitted if outDir is not specified
     if (!options.outDir) return false;
     // Otherwise if rootDir or composite config file, we know common sourceDir and can check if file would be emitted in same location
-    if (options.rootDir || (options.composite && options.configFilePath)) {
+    if (options.rootDir || options.configFilePath) {
         const commonDir = getNormalizedAbsolutePath(getCommonSourceDirectory(options, () => [], host.getCurrentDirectory(), host.getCanonicalFileName), host.getCurrentDirectory());
         const outputPath = getSourceFilePathInNewDirWorker(sourceFile.fileName, options.outDir, host.getCurrentDirectory(), commonDir, host.getCanonicalFileName);
         if (comparePaths(sourceFile.fileName, outputPath, host.getCurrentDirectory(), !host.useCaseSensitiveFileNames()) === Comparison.EqualTo) return false;

src/testRunner/unittests/helpers/monorepoSymlinkedSiblingPackages.ts

@@ -151,6 +151,7 @@ function getMonorepoSymlinkedSiblingPackagesSysWithUnRelatedFolders(
             compilerOptions: {
                 outDir: "lib",
                 declaration: true,
+                rootDir: "src",
             },
             include: ["src/**/*.ts"],
         }),
@@ -169,6 +170,7 @@ function getMonorepoSymlinkedSiblingPackagesSysWithUnRelatedFolders(
             compilerOptions: {
                 outDir: "lib",
                 declaration: true,
+                rootDir: "src",
             },
             include: ["src/**/*.ts"],
         }),
@@ -183,6 +185,7 @@ function getMonorepoSymlinkedSiblingPackagesSysWithUnRelatedFolders(
         "/home/src/projects/b/2/b-impl/b/tsconfig.json": jsonToReadableText({
             compilerOptions: {
                 outDir: "lib",
+                rootDir: "src",
             },
             include: ["src/**/*.ts"],
         }),

src/testRunner/unittests/tsbuild/outputPaths.ts

@@ -26,7 +26,7 @@ describe("unittests:: tsbuild:: outputPaths::", () => {
             ...input,
         });
 
-        it("verify getOutputFileNames", () => {
+        it("verify getOutputFileNames " + input.subScenario, () => {
             const sys = input.sys();
             assert.deepEqual(
                 ts.getOutputFileNames(
@@ -58,7 +58,7 @@ describe("unittests:: tsbuild:: outputPaths::", () => {
                 }),
             }),
         edits,
-    }, ["/home/src/workspaces/project/dist/index.js"]);
+    }, ["/home/src/workspaces/project/dist/src/index.js"]);
 
     verify({
         subScenario: "when rootDir is not specified and is composite",

tests/baselines/reference/commonSourceDirectory.js

@@ -27,3 +27,36 @@ foo_1.x + bar_1.y;
 //// [/app/bin/index.d.ts]
 /// <reference path="../../types/bar.d.ts" preserve="true" />
 export {};
+
+
+//// [DtsFileErrors]
+
+
+/app/tsconfig.json(3,9): error TS5011: The common source directory of 'tsconfig.json' is '../.src'. The 'rootDir' setting must be explicitly set to this or another path to adjust your output's file layout.
+  Visit https://aka.ms/ts6 for migration information.
+
+
+==== /app/tsconfig.json (1 errors) ====
+    {
+        "compilerOptions": {
+            "outDir": "bin",
+            ~~~~~~~~
+!!! error TS5011: The common source directory of 'tsconfig.json' is '../.src'. The 'rootDir' setting must be explicitly set to this or another path to adjust your output's file layout.
+!!! error TS5011:   Visit https://aka.ms/ts6 for migration information.
+            "typeRoots": ["../types"],
+            "sourceMap": true,
+            "mapRoot": "myMapRoot",
+            "sourceRoot": "mySourceRoot",
+            "declaration": true
+        }
+    }
+    
+==== /app/bin/index.d.ts (0 errors) ====
+    /// <reference path="../../types/bar.d.ts" preserve="true" />
+    export {};
+    
+==== /types/bar.d.ts (0 errors) ====
+    declare module "bar" {
+        export const y = 0;
+    }
+    

tests/baselines/reference/commonSourceDirectory_dts.errors.txt

@@ -0,0 +1,25 @@
+/app/tsconfig.json(3,9): error TS5011: The common source directory of 'tsconfig.json' is './src'. The 'rootDir' setting must be explicitly set to this or another path to adjust your output's file layout.
+  Visit https://aka.ms/ts6 for migration information.
+
+
+==== /app/tsconfig.json (1 errors) ====
+    {
+        "compilerOptions": {
+            "outDir": "bin",
+            ~~~~~~~~
+!!! error TS5011: The common source directory of 'tsconfig.json' is './src'. The 'rootDir' setting must be explicitly set to this or another path to adjust your output's file layout.
+!!! error TS5011:   Visit https://aka.ms/ts6 for migration information.
+            "sourceMap": true,
+            "mapRoot": "myMapRoot",
+            "sourceRoot": "mySourceRoot",
+            "declaration": true
+        }
+    }
+    
+==== /app/lib/bar.d.ts (0 errors) ====
+    declare const y: number;
+    
+==== /app/src/index.ts (0 errors) ====
+    /// <reference path="../lib/bar.d.ts" preserve="true" />
+    export const x = y;
+    

tests/baselines/reference/commonSourceDirectory_dts.js

@@ -8,14 +8,14 @@ declare const y: number;
 export const x = y;
 
 
-//// [/app/bin/index.js]
+//// [/app/bin/src/index.js]
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.x = void 0;
 /// <reference path="../lib/bar.d.ts" preserve="true" />
 exports.x = y;
-//# sourceMappingURL=../src/myMapRoot/index.js.map
+//# sourceMappingURL=../../myMapRoot/src/index.js.map
 
-//// [/app/bin/index.d.ts]
-/// <reference path="../lib/bar.d.ts" preserve="true" />
+//// [/app/bin/src/index.d.ts]
+/// <reference path="../../lib/bar.d.ts" preserve="true" />
 export declare const x: number;