EnumLiteralExpression name is no longer an AST node, bunch of linter errors are fixed

Author: caitp

src/compiler/binder.ts

@@ -85,7 +85,6 @@ import {
     FunctionLikeDeclaration,
     GetAccessorDeclaration,
     getAssignedExpandoInitializer,
-    getAssignedName,
     getAssignmentDeclarationKind,
     getAssignmentDeclarationPropertyAccessKind,
     getCombinedModifierFlags,
@@ -158,7 +157,6 @@ import {
     isEntityNameExpression,
     isEnumConst,
     isEnumLiteralExpression,
-    isEnumTypeReference,
     isExportAssignment,
     isExportDeclaration,
     isExportsIdentifier,

src/compiler/checker.ts

@@ -47104,6 +47104,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
         const isConstEnum = isEnumConst(member.parent);
         const initializer = member.initializer!;
         const result = evaluate(initializer, member);
+        const isDecl = isEnumDeclaration(member.parent);
         if (result.value !== undefined) {
             if (isConstEnum && typeof result.value === "number" && !isFinite(result.value)) {
                 error(
@@ -47117,7 +47118,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                 error(
                     initializer,
                     Diagnostics._0_has_a_string_type_but_must_have_syntactically_recognizable_string_syntax_when_isolatedModules_is_enabled,
-                    `${idText(member.parent.name)}.${getTextOfPropertyName(member.name)}`,
+                    isDecl ? `${idText(member.parent.name)}.${getTextOfPropertyName(member.name)}` : `${member.parent.name}.${getTextOfPropertyName(member.name)}`,
                 );
             }
         }

src/compiler/parser.ts

@@ -110,7 +110,6 @@ import {
     getLeadingCommentRanges,
     getSpellingSuggestion,
     getTextOfNodeFromSourceText,
-    getTokenPosOfNode,
     HasJSDoc,
     hasJSDocNodes,
     HasModifiers,
@@ -330,7 +329,6 @@ import {
     ScriptKind,
     ScriptTarget,
     SetAccessorDeclaration,
-    setOriginalNode,
     setParent,
     setParentRecursive,
     setTextRange,
@@ -7097,7 +7095,7 @@ namespace Parser {
 
         let variableDeclaration;
         if (parseOptional(SyntaxKind.OpenParenToken)) {
-            variableDeclaration = parseVariableDeclaration() as VariableDeclaration;
+            variableDeclaration = parseVariableDeclaration();
             parseExpected(SyntaxKind.CloseParenToken);
         }
         else {
@@ -8268,7 +8266,6 @@ namespace Parser {
         // const MyEnum: enum = { name: value }
         const pos = getNodePos();
         const hasJSDoc = hasPrecedingJSDocComment();
-        const tokenIsIdentifier = isIdentifier();
         const name = parsePropertyName();
         let initializer: Expression | undefined;
 

src/compiler/transformers/ts.ts

@@ -86,7 +86,6 @@ import {
     isElementAccessExpression,
     isEntityName,
     isEnumConst,
-    isEnumMember,
     isExportAssignment,
     isExportDeclaration,
     isExportOrDefaultModifier,
@@ -170,7 +169,6 @@ import {
     setInternalEmitFlags,
     setOriginalNode,
     setParent,
-    setParentRecursive,
     setSourceMapRange,
     setSyntheticLeadingComments,
     setSyntheticTrailingComments,

src/compiler/utilities.ts

@@ -277,9 +277,7 @@ import {
     isElementAccessExpression,
     isEnumDeclaration,
     isEnumLiteralDeclaration,
-    isEnumLiteralExpression,
     isEnumMember,
-    isEnumTypeReference,
     isExportAssignment,
     isExportDeclaration,
     isExpressionStatement,

src/compiler/visitorPublic.ts

@@ -1480,11 +1480,11 @@ const visitEachChildTable: VisitEachChildTable = {
         );
     },
 
-    [SyntaxKind.EnumLiteralExpression]: function visitEachChildOfEnumDeclaration(node, visitor, context, nodesVisitor, nodeVisitor, _tokenVisitor) {
+    [SyntaxKind.EnumLiteralExpression]: function visitEachChildOfEnumDeclaration(node, visitor, context, nodesVisitor, _tokenVisitor) {
         return context.factory.updateEnumLiteralExpression(
             node,
             nodesVisitor(node.modifiers, visitor, isModifierLike),
-            Debug.checkDefined(nodeVisitor(node.name, visitor, isIdentifier)),
+            node.name,
             nodesVisitor(node.members, visitor, isEnumMember),
         );
     },

tests/baselines/reference/api/typescript.d.ts

@@ -5454,7 +5454,7 @@ declare namespace ts {
         readonly kind: SyntaxKind.EnumLiteralExpression;
         readonly parent: VariableDeclaration;
         readonly modifiers?: NodeArray<ModifierLike>;
-        readonly name: Identifier;
+        readonly name: __String;
         readonly members: NodeArray<EnumMember>;
     }
     type EnumDeclarationType = EnumDeclaration | EnumLiteralExpression;
@@ -7711,8 +7711,8 @@ declare namespace ts {
         updateTypeAliasDeclaration(node: TypeAliasDeclaration, modifiers: readonly ModifierLike[] | undefined, name: Identifier, typeParameters: readonly TypeParameterDeclaration[] | undefined, type: TypeNode): TypeAliasDeclaration;
         createEnumDeclaration(modifiers: readonly ModifierLike[] | undefined, name: string | Identifier, members: readonly EnumMember[]): EnumDeclaration;
         updateEnumDeclaration(node: EnumDeclaration, modifiers: readonly ModifierLike[] | undefined, name: Identifier, members: readonly EnumMember[]): EnumDeclaration;
-        createEnumLiteralExpression(modifiers: readonly ModifierLike[] | undefined, name: string | Identifier, members: readonly EnumMember[]): EnumLiteralExpression;
-        updateEnumLiteralExpression(node: EnumLiteralExpression, modifiers: readonly ModifierLike[] | undefined, name: Identifier, members: readonly EnumMember[]): EnumLiteralExpression;
+        createEnumLiteralExpression(modifiers: readonly ModifierLike[] | undefined, name: __String, members: readonly EnumMember[]): EnumLiteralExpression;
+        updateEnumLiteralExpression(node: EnumLiteralExpression, modifiers: readonly ModifierLike[] | undefined, name: __String, members: readonly EnumMember[]): EnumLiteralExpression;
         createModuleDeclaration(modifiers: readonly ModifierLike[] | undefined, name: ModuleName, body: ModuleBody | undefined, flags?: NodeFlags): ModuleDeclaration;
         updateModuleDeclaration(node: ModuleDeclaration, modifiers: readonly ModifierLike[] | undefined, name: ModuleName, body: ModuleBody | undefined): ModuleDeclaration;
         createModuleBlock(statements: readonly Statement[]): ModuleBlock;