Adding tests and changed property checking

Author: NamHaiBui

src/services/findAllReferences.ts

@@ -2478,7 +2478,7 @@ export namespace Core {
             cancellationToken.throwIfCancellationRequested();
             return mapDefined(getPossibleSymbolReferenceNodes(sourceFile, node.text), ref => {
                 if (isStringLiteralLike(ref) && ref.text === node.text) {
-                    if (type) {
+                    if (type && !isStringLiteralPropertyReference(node, checker)) {
                         const refType = getContextualTypeFromParentOrAncestorTypeNode(ref, checker);
                         if (type !== checker.getStringType() && (type === refType || isStringLiteralPropertyReference(ref, checker))) {
                             return nodeEntry(ref, EntryKind.StringLiteral);

tests/baselines/reference/renameStringLiteralTypes5.baseline.jsonc

@@ -1,11 +1,9 @@
 // === findRenameLocations ===
 // === /tests/cases/fourslash/renameStringLiteralTypes5.ts ===
-// declare const Att_1: "[|Att 2RENAME|]"/*RENAME*/
-// 
-// interface Case_1 {
-//   [Att_1]: string
+// type T = {
+//     <|"[|Prop 1RENAME|]": string;|>
 // }
 // 
-// declare const fnc_1: <K extends keyof Case_1>(p: K) => void
+// declare const fn: <K extends keyof T>(p: K) => void
 // 
-// fnc_1("[|Att 2RENAME|]")
+// fn("[|Prop 1RENAME|]"/*RENAME*/)

tests/baselines/reference/renameStringLiteralTypes7.baseline.jsonc

@@ -0,0 +1,11 @@
+// === findRenameLocations ===
+// === /tests/cases/fourslash/renameStringLiteralTypes7.ts ===
+// declare const Att_1: "[|Att 2RENAME|]"/*RENAME*/
+// 
+// interface Case_1 {
+//   [Att_1]: string
+// }
+// 
+// declare const fnc_1: <K extends keyof Case_1>(p: K) => void
+// 
+// fnc_1("[|Att 2RENAME|]")

tests/baselines/reference/renameStringLiteralTypes8.baseline.jsonc

@@ -0,0 +1,9 @@
+// === findRenameLocations ===
+// === /tests/cases/fourslash/renameStringLiteralTypes8.ts ===
+// type T = {
+//     <|"[|Prop 1RENAME|]"/*RENAME*/: string;|>
+// }
+// 
+// declare const fn: <K extends keyof T>(p: K) => void
+// 
+// fn("[|Prop 1RENAME|]")

tests/cases/fourslash/renameStringLiteralTypes5.ts

@@ -1,13 +1,9 @@
 /// <reference path="fourslash.ts" />
-
-////declare const Att_1: "Att 2"/**/
-////
-////interface Case_1 {
-////  [Att_1]: string
+////type T = {
+////    "Prop 1": string;
 ////}
 ////
-////declare const fnc_1: <K extends keyof Case_1>(p: K) => void
+////declare const fn: <K extends keyof T>(p: K) => void
 ////
-////fnc_1("Att 2")
-
-verify.baselineRename("", {});
+////fn("Prop 1"/**/)
+verify.baselineRename("", {});

tests/cases/fourslash/renameStringLiteralTypes7.ts

@@ -0,0 +1,13 @@
+/// <reference path="fourslash.ts" />
+
+////declare const Att_1: "Att 2"/**/
+////
+////interface Case_1 {
+////  [Att_1]: string
+////}
+////
+////declare const fnc_1: <K extends keyof Case_1>(p: K) => void
+////
+////fnc_1("Att 2")
+
+verify.baselineRename("", {});

tests/cases/fourslash/renameStringLiteralTypes8.ts

@@ -0,0 +1,9 @@
+/// <reference path="fourslash.ts" />
+////type T = {
+////    "Prop 1"/**/: string;
+////}
+////
+////declare const fn: <K extends keyof T>(p: K) => void
+////
+////fn("Prop 1")
+verify.baselineRename("", {});