Skip to content

Fix unwanted constant comparisons potentially causing bugs #61655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandersn merged 3 commits into from
May 9, 2025
Merged

Fix unwanted constant comparisons potentially causing bugs #61655

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37fd843
Fix unwanted constant comparisons potentially causing bugs
ulrichstark May 4, 2025
b03f3a6
Update fourslashImpl.ts
ulrichstark May 6, 2025
e79a531
update baseline tests
ulrichstark May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/compiler/resolutionCache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ export function canWatchAtTypes(atTypes: Path): boolean {
}

function isInDirectoryPath(dirComponents: Readonly<PathPathComponents>, fileOrDirComponents: Readonly<PathPathComponents>) {
if (fileOrDirComponents.length < fileOrDirComponents.length) return false;
if (fileOrDirComponents.length < dirComponents.length) return false;
for (let i = 0; i < dirComponents.length; i++) {
if (fileOrDirComponents[i] !== dirComponents[i]) return false;
}
Expand Down
2 changes: 1 addition & 1 deletion src/harness/fourslashImpl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2600,7 +2600,7 @@ export class TestState {
sorted.sort((q1, q2) =>
q1.marker.fileName === q1.marker.fileName
Comment thread
ulrichstark marked this conversation as resolved.
Outdated
? (q1.marker.position > q2.marker.position ? -1 : 1)
: (q1.marker.fileName > q1.marker.fileName ? 1 : -1)
: (q1.marker.fileName > q2.marker.fileName ? 1 : -1)
);
const files = new Map<string, string[]>();
let previous: T | undefined;
Expand Down