Serviceless infrastructure: LocalRepoRegistry, logon task, ProjFS boot task

Add the infrastructure that enables GVFS to operate without GVFS.Service:

LocalRepoRegistry: file-backed repo registry that replaces the service's
named-pipe registry. Wire-compatible on-disk format. SYSTEM account uses
ProgramData path for CI agents. Seed-on-first-use copies accessible
entries from system registry on first run (with TOCTOU merge safety).
FileShare.ReadWrite|Delete for multi-process concurrent access.

LogonTaskRegistration: per-user scheduled task (\GVFS\AutoMount) that
runs 'conhost --headless gvfs service --mount-all' at logon. SHA-256
hash-based drift detection to avoid unnecessary re-registration.

CLI verb fallbacks: MountVerb, UnmountVerb, ServiceVerb fall back to
LocalRepoRegistry when the GVFS.Service named pipe is unavailable.

GVFSVerb: silent-success fallback for PrjFlt FilterAttach when the
service is not available to do it.

ProjFS boot task: enable-projfs-on-all-drives.ps1 enables ProjFS and
attaches PrjFlt on all volumes at boot and on hot-plug. Embedded in
task XML via build-task-xml.ps1 with SHA-256 hash marker for drift
detection.

InProcessMount: restore exception safety net in HandleRequest that was
accidentally removed during refactoring.

39 new unit tests (23 LocalRepoRegistry + 21 LogonTaskRegistration,
minus 5 shared helpers). All 927 unit tests pass.

Assisted-by: Claude Sonnet 4.5
Assisted-by: Claude Opus 4.6
Signed-off-by: Tyrie Vella <tyrielv@gmail.com>

Author: tyrielv

.github/workflows/build.yaml

@@ -261,7 +261,7 @@ jobs:
 
     strategy:
       matrix:
-        configuration: [ Release ]
+        configuration: [ Debug, Release ]
       fail-fast: false
 
     steps:

.github/workflows/functional-tests.yaml

@@ -61,9 +61,9 @@ jobs:
 
     strategy:
       matrix:
-        configuration: [ Release ]
+        configuration: [ Debug, Release ]
         architecture: [ x86_64, arm64 ]
-        nr: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11] # 12 parallel jobs to speed up the tests
+        nr: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9] # 10 parallel jobs to speed up the tests
       fail-fast: false # most failures are flaky tests, no need to stop the other jobs from succeeding
 
     steps:
@@ -142,17 +142,6 @@ jobs:
         run-id: ${{ inputs.vfs_run_id || github.run_id }}
         github-token: ${{ secrets.vfs_token || github.token }}
 
-    - name: Download FastFetch drop
-      if: steps.skip.outputs.result != 'true'
-      continue-on-error: true
-      uses: actions/download-artifact@v8
-      with:
-        name: FastFetch_${{ matrix.configuration }}
-        path: ft
-        repository: ${{ inputs.vfs_repository || github.repository }}
-        run-id: ${{ inputs.vfs_run_id || github.run_id }}
-        github-token: ${{ secrets.vfs_token || github.token }}
-
     - name: ProjFS details (pre-install)
       if: steps.skip.outputs.result != 'true'
       shell: cmd
@@ -204,7 +193,7 @@ jobs:
       run: |
         SET PATH=C:\Program Files\VFS for Git;%PATH%
         SET GIT_TRACE2_PERF=C:\temp\git-trace2.log
-        ft\GVFS.FunctionalTests.exe /result:TestResult.xml --ci --slice=${{ matrix.nr }},12
+        ft\GVFS.FunctionalTests.exe /result:TestResult.xml --ci --slice=${{ matrix.nr }},10
 
     - name: Upload functional test results
       if: always() && steps.skip.outputs.result != 'true'

.github/workflows/upgrade-tests.yaml

@@ -26,7 +26,7 @@ jobs:
 
     strategy:
       matrix:
-        configuration: [ Release ]
+        configuration: [ Debug ]
         scenario:
           - staging-upgrade
           - clean-upgrade

AuthoringTests.md

@@ -40,9 +40,10 @@ The functional tests are built on NUnit 3, which is available as a set of NuGet
 
 #### Selecting Which Tests are Run
 
-By default, the functional tests run all tests.  There are two mutually exclusive arguments that can be passed to the functional tests to change this behavior:
+By default, the functional tests run a subset of tests as a quick smoke test for developers.  There are three mutually exclusive arguments that can be passed to the functional tests to change this behavior:
 
-- `--full-suite`: Run all configurations of all functional tests (tests all `ValidateWorkingTreeMode` values and all `FileSystemRunner` types)
+- `--full-suite`: Run all configurations of all functional tests
+- `--extra-only`: Run only those tests marked as "ExtraCoverage" (i.e. the tests that are not run by default)
 - `--windows-only`: Run only the tests marked as being Windows specific
 
 **NOTE** `Scripts\RunFunctionalTests.bat` already uses some of these arguments.  If you run the tests using `RunFunctionalTests.bat` consider locally modifying the script rather than passing these flags as arguments to the script.

GVFS/GVFS.Common/ConsoleHelper.cs

@@ -21,32 +21,6 @@ public static bool ShowStatusWhileRunning(
             bool showSpinner,
             string gvfsLogEnlistmentRoot,
             int initialDelayMs = 0)
-        {
-            return ShowStatusWhileRunning(
-                action,
-                getMessage: null,
-                message: message,
-                output,
-                showSpinner,
-                gvfsLogEnlistmentRoot,
-                initialDelayMs);
-        }
-
-        /// <summary>
-        /// Runs an action while displaying a dynamic status message with a spinner.
-        /// The <paramref name="getMessage"/> delegate is called on each spinner tick
-        /// and may return a sub-status string (e.g. "Authenticating") that is appended
-        /// to <paramref name="message"/> in parentheses. When null or returning null,
-        /// only the base message is shown.
-        /// </summary>
-        public static bool ShowStatusWhileRunning(
-            Func<bool> action,
-            Func<string> getMessage,
-            string message,
-            TextWriter output,
-            bool showSpinner,
-            string gvfsLogEnlistmentRoot,
-            int initialDelayMs = 0)
         {
             Func<ActionResult> actionResultAction =
                 () =>
@@ -56,7 +30,6 @@ public static bool ShowStatusWhileRunning(
 
             ActionResult result = ShowStatusWhileRunning(
                 actionResultAction,
-                getMessage,
                 message,
                 output,
                 showSpinner,
@@ -73,18 +46,6 @@ public static ActionResult ShowStatusWhileRunning(
             bool showSpinner,
             string gvfsLogEnlistmentRoot,
             int initialDelayMs)
-        {
-            return ShowStatusWhileRunning(action, getMessage: null, message, output, showSpinner, gvfsLogEnlistmentRoot, initialDelayMs);
-        }
-
-        public static ActionResult ShowStatusWhileRunning(
-            Func<ActionResult> action,
-            Func<string> getMessage,
-            string message,
-            TextWriter output,
-            bool showSpinner,
-            string gvfsLogEnlistmentRoot,
-            int initialDelayMs)
         {
             ActionResult result = ActionResult.Failure;
             bool initialMessageWritten = false;
@@ -106,7 +67,6 @@ public static ActionResult ShowStatusWhileRunning(
                         {
                             int retries = 0;
                             char[] waiting = { '\u2014', '\\', '|', '/' };
-                            string lastProgress = null;
 
                             while (!isComplete)
                             {
@@ -116,23 +76,7 @@ public static ActionResult ShowStatusWhileRunning(
                                 }
                                 else
                                 {
-                                    string progress = getMessage?.Invoke();
-                                    string displayMessage = !string.IsNullOrEmpty(progress)
-                                        ? $"{message} ({progress})"
-                                        : message;
-
-                                    // Clear previous line content when message shrinks
-                                    string line = $"\r{displayMessage}...{waiting[(retries / 2) % waiting.Length]}";
-                                    if (lastProgress != null && lastProgress.Length > line.Length)
-                                    {
-                                        output.Write(line + new string(' ', lastProgress.Length - line.Length));
-                                    }
-                                    else
-                                    {
-                                        output.Write(line);
-                                    }
-
-                                    lastProgress = line;
+                                    output.Write("\r{0}...{1}", message, waiting[(retries / 2) % waiting.Length]);
                                     initialMessageWritten = true;
                                     actionIsDone.WaitOne(100);
                                 }
@@ -142,16 +86,8 @@ public static ActionResult ShowStatusWhileRunning(
 
                             if (initialMessageWritten)
                             {
-                                // Clear out any trailing waiting character and sub-status
-                                string finalLine = $"\r{message}...";
-                                if (lastProgress != null && lastProgress.Length > finalLine.Length)
-                                {
-                                    output.Write(finalLine + new string(' ', lastProgress.Length - finalLine.Length) + $"\r{message}...");
-                                }
-                                else
-                                {
-                                    output.Write(finalLine);
-                                }
+                                // Clear out any trailing waiting character
+                                output.Write("\r{0}...", message);
                             }
                         });
                     spinnerThread.Start();

GVFS/GVFS.Common/Database/SqliteDatabase.cs

@@ -21,7 +21,7 @@ public static bool HasIssue(string databasePath, PhysicalFileSystem filesystem,
 
                 try
                 {
-                    string sqliteConnectionString = $"data source={databasePath};Pooling=False";
+                    string sqliteConnectionString = CreateConnectionString(databasePath);
                     using (SqliteConnection integrityConnection = new SqliteConnection(sqliteConnectionString))
                     {
                         integrityConnection.Open();

GVFS/GVFS.Common/Database/SqliteErrorCodes.cs

@@ -212,15 +212,15 @@ public static string GetNewGVFSLogFileName(
                 fileSystem: fileSystem);
         }
 
-        public static bool WaitUntilMounted(ITracer tracer, string enlistmentRoot, bool unattended, out string errorMessage, Action<string> onProgress = null)
+        public static bool WaitUntilMounted(ITracer tracer, string enlistmentRoot, bool unattended, out string errorMessage)
         {
             string pipeName = GVFSPlatform.Instance.GetNamedPipeName(enlistmentRoot);
-            return WaitUntilMounted(tracer, pipeName, enlistmentRoot, unattended, out errorMessage, onProgress);
+            return WaitUntilMounted(tracer, pipeName, enlistmentRoot, unattended, out errorMessage);
         }
 
-        public static bool WaitUntilMounted(ITracer tracer, string pipeName, string enlistmentRoot, bool unattended, out string errorMessage, Action<string> onProgress = null)
+        public static bool WaitUntilMounted(ITracer tracer, string pipeName, string enlistmentRoot, bool unattended, out string errorMessage)
         {
-            return WaitUntilMounted(tracer, pipeName, enlistmentRoot, unattended, mountProcessStatus: null, out errorMessage, onProgress);
+            return WaitUntilMounted(tracer, pipeName, enlistmentRoot, unattended, mountProcessStatus: null, out errorMessage);
         }
 
         /// <summary>
@@ -241,8 +241,7 @@ public static bool WaitUntilMounted(
             string enlistmentRoot,
             bool unattended,
             Func<MountProcessSnapshot> mountProcessStatus,
-            out string errorMessage,
-            Action<string> onProgress = null)
+            out string errorMessage)
         {
             tracer.RelatedInfo($"{nameof(WaitUntilMounted)}: Creating NamedPipeClient for pipe '{pipeName}'");
             tracer.RelatedInfo($"{nameof(WaitUntilMounted)}: Connecting to '{pipeName}'");
@@ -287,11 +286,6 @@ public static bool WaitUntilMounted(
                         }
                         else
                         {
-                            if (onProgress != null && !string.IsNullOrEmpty(getStatusResponse.MountProgress))
-                            {
-                                onProgress(getStatusResponse.MountProgress);
-                            }
-
                             tracer.RelatedInfo($"{nameof(WaitUntilMounted)}: Waiting 500ms for mount process to be ready");
                             Thread.Sleep(100);
                         }

GVFS/GVFS.Common/GVFSEnlistment.cs

@@ -3,7 +3,7 @@
 using GVFS.Common.Tracing;
 using System;
 using System.ComponentModel;
-
+using System.Diagnostics;
 using System.IO;
 using System.Threading;
 using System.Threading.Tasks;
@@ -597,10 +597,7 @@ private bool TryRebuildStatusCache()
 
         private bool TryDeleteStatusCacheFile()
         {
-            if (!this.cacheFileLock.IsHeldByCurrentThread)
-            {
-                throw new InvalidOperationException("Attempting to delete the git status cache file without the cacheFileLock");
-            }
+            Debug.Assert(this.cacheFileLock.IsHeldByCurrentThread, "Attempting to delete the git status cache file without the cacheFileLock");
 
             try
             {
@@ -638,10 +635,7 @@ private bool TryDeleteStatusCacheFile()
         /// <returns>True on success, False on failure</returns>
         private bool MoveCacheFileToFinalLocation(string tmpStatusFilePath)
         {
-            if (!this.cacheFileLock.IsHeldByCurrentThread)
-            {
-                throw new InvalidOperationException("Attempting to update the git status cache file without the cacheFileLock");
-            }
+            Debug.Assert(this.cacheFileLock.IsHeldByCurrentThread, "Attempting to update the git status cache file without the cacheFileLock");
 
             try
             {

GVFS/GVFS.Common/GitStatusCache.cs

@@ -0,0 +1,37 @@
+using System.Collections.Generic;
+
+namespace GVFS.Common
+{
+    /// <summary>
+    /// Abstracts the Windows Task Scheduler operations needed by
+    /// <see cref="LogonTaskRegistration"/>. Production callers use
+    /// <see cref="SchTasksScheduledTaskInvoker"/>; tests pass a mock so
+    /// they can exercise <see cref="LogonTaskRegistration"/>'s logic
+    /// without actually touching the Task Scheduler on the test machine.
+    /// </summary>
+    public interface IScheduledTaskInvoker
+    {
+        /// <summary>
+        /// Register the task at <paramref name="taskPath"/> from the given
+        /// XML, overwriting any existing task at that path. Returns
+        /// <c>true</c> on success.
+        /// </summary>
+        bool TryRegisterFromXml(string taskPath, string xml, out string errorMessage);
+
+        /// <summary>
+        /// Read back the registered XML for the task at
+        /// <paramref name="taskPath"/>. Returns <c>true</c> with the XML
+        /// when the task exists; returns <c>false</c> with a populated
+        /// <paramref name="errorMessage"/> when it does not.
+        /// </summary>
+        bool TryQueryXml(string taskPath, out string xml, out string errorMessage);
+
+        /// <summary>
+        /// Unregister the task at <paramref name="taskPath"/>. Returns
+        /// <c>true</c> if the task was unregistered OR was not registered
+        /// to begin with (idempotent). Returns <c>false</c> only on a hard
+        /// failure (e.g., permission denied).
+        /// </summary>
+        bool TryUnregister(string taskPath, out string errorMessage);
+    }
+}