Merge pull request #1996 from tyrielv/tyrielv/handle-diagnostic

tyrielv · web-flow · commit 7b0c70514516 · 2026-06-02T05:19:56.000-07:00
Add diagnostic logging to GetFileStreamException catch block
diff --git a/GVFS/GVFS.Platform.Windows/WindowsFileSystemVirtualizer.cs b/GVFS/GVFS.Platform.Windows/WindowsFileSystemVirtualizer.cs
@@ -981,6 +981,9 @@ private void GetFileStreamHandlerAsyncHandler(
             }
             catch (GetFileStreamException e)
             {
+                requestMetadata.Add(TracingConstants.MessageKey.InfoMessage, $"{nameof(this.GetFileStreamHandlerAsyncHandler)}: GetFileStreamException HResult 0x{e.HResult:X8}");
+                this.Context.Tracer.RelatedWarning(requestMetadata, nameof(this.GetFileStreamHandlerAsyncHandler) + "_GetFileStreamException");
+
                 this.TryCompleteCommand(commandId, (HResult)e.HResult);
                 return;
             }

Original file line number	Diff line number	Diff line change
`@@ -981,6 +981,9 @@ private void GetFileStreamHandlerAsyncHandler(`
`981`	`981`	`}`
`982`	`982`	`catch (GetFileStreamException e)`
`983`	`983`	`{`
	`984`	`+ requestMetadata.Add(TracingConstants.MessageKey.InfoMessage, $"{nameof(this.GetFileStreamHandlerAsyncHandler)}: GetFileStreamException HResult 0x{e.HResult:X8}");`
	`985`	`+ this.Context.Tracer.RelatedWarning(requestMetadata, nameof(this.GetFileStreamHandlerAsyncHandler) + "_GetFileStreamException");`
	`986`	`+`
`984`	`987`	`this.TryCompleteCommand(commandId, (HResult)e.HResult);`
`985`	`988`	`return;`
`986`	`989`	`}`