Merge pull request #2025 from tyrielv/tyrielv/drop-debug-ci

ci: drop Debug configuration from build and test matrices

Author: tyrielv

.github/workflows/build.yaml

@@ -261,7 +261,7 @@ jobs:
 
     strategy:
       matrix:
-        configuration: [ Debug, Release ]
+        configuration: [ Release ]
       fail-fast: false
 
     steps:

.github/workflows/functional-tests.yaml

@@ -61,7 +61,7 @@ jobs:
 
     strategy:
       matrix:
-        configuration: [ Debug, Release ]
+        configuration: [ Release ]
         architecture: [ x86_64, arm64 ]
         nr: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11] # 12 parallel jobs to speed up the tests
       fail-fast: false # most failures are flaky tests, no need to stop the other jobs from succeeding

.github/workflows/upgrade-tests.yaml

@@ -26,7 +26,7 @@ jobs:
 
     strategy:
       matrix:
-        configuration: [ Debug ]
+        configuration: [ Release ]
         scenario:
           - staging-upgrade
           - clean-upgrade

GVFS/GVFS.Common/GitStatusCache.cs

@@ -3,7 +3,7 @@
 using GVFS.Common.Tracing;
 using System;
 using System.ComponentModel;
-using System.Diagnostics;
+
 using System.IO;
 using System.Threading;
 using System.Threading.Tasks;
@@ -597,7 +597,10 @@ private bool TryRebuildStatusCache()
 
         private bool TryDeleteStatusCacheFile()
         {
-            Debug.Assert(this.cacheFileLock.IsHeldByCurrentThread, "Attempting to delete the git status cache file without the cacheFileLock");
+            if (!this.cacheFileLock.IsHeldByCurrentThread)
+            {
+                throw new InvalidOperationException("Attempting to delete the git status cache file without the cacheFileLock");
+            }
 
             try
             {
@@ -635,7 +638,10 @@ private bool TryDeleteStatusCacheFile()
         /// <returns>True on success, False on failure</returns>
         private bool MoveCacheFileToFinalLocation(string tmpStatusFilePath)
         {
-            Debug.Assert(this.cacheFileLock.IsHeldByCurrentThread, "Attempting to update the git status cache file without the cacheFileLock");
+            if (!this.cacheFileLock.IsHeldByCurrentThread)
+            {
+                throw new InvalidOperationException("Attempting to update the git status cache file without the cacheFileLock");
+            }
 
             try
             {

GVFS/GVFS.Common/Tracing/QueuedPipeStringWriter.cs

@@ -1,6 +1,6 @@
 using System;
 using System.Collections.Concurrent;
-using System.Diagnostics;
+
 using System.IO.Pipes;
 using System.Text;
 using System.Threading;
@@ -86,7 +86,10 @@ public void Stop()
             this.queue.CompleteAdding();
             this.writerThread.Join();
 
-            Debug.Assert(this.queue.IsCompleted, "Message queue should be empty after being stopped");
+            if (!this.queue.IsCompleted)
+            {
+                throw new InvalidOperationException("Message queue should be empty after being stopped");
+            }
         }
 
         public void Dispose()

GVFS/GVFS.UnitTests/Mock/Common/MockPhysicalGitObjects.cs

@@ -3,7 +3,8 @@
 using GVFS.Common.Git;
 using GVFS.Common.Http;
 using GVFS.Common.Tracing;
-using System.Diagnostics;
+
+using System;
 using System.IO;
 
 namespace GVFS.UnitTests.Mock.Common
@@ -26,7 +27,7 @@ public override string WriteLooseObject(Stream responseStream, string sha, bool
 
         public override string WriteTempPackFile(Stream stream)
         {
-            Debug.Assert(stream != null, "WriteTempPackFile should not receive a null stream");
+            ArgumentNullException.ThrowIfNull(stream);
 
             using (stream)
             using (StreamReader reader = new StreamReader(stream))