Logon task: machine-wide for all users; remove --no-service flag

Machine-wide logon task:
- Task uses GroupId S-1-5-4 (Interactive Users) instead of per-user SID
- Fires for all interactive users at logon
- Each user's gvfs service --mount-all reads their own LocalRepoRegistry
- Remove userSid parameter from BuildTaskXml/TryRegisterOrUpdate
- Remove per-user SID test (DifferentUser_Reregisters)

Remove --no-service from functional tests:
- Service is gone — no option to have one, flag is meaningless
- Remove NoService flag, RequiresService category
- Always skip service install/uninstall in test harness
- Reset workflow files to upstream/master

Assisted-by: Claude Sonnet 4.5
Signed-off-by: Tyrie Vella <tyrielv@gmail.com>

Author: tyrielv

.github/workflows/build.yaml

@@ -261,7 +261,7 @@ jobs:
 
     strategy:
       matrix:
-        configuration: [ Debug, Release ]
+        configuration: [ Release ]
       fail-fast: false
 
     steps:

.github/workflows/functional-tests.yaml

@@ -61,9 +61,9 @@ jobs:
 
     strategy:
       matrix:
-        configuration: [ Debug, Release ]
+        configuration: [ Release ]
         architecture: [ x86_64, arm64 ]
-        nr: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9] # 10 parallel jobs to speed up the tests
+        nr: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11] # 12 parallel jobs to speed up the tests
       fail-fast: false # most failures are flaky tests, no need to stop the other jobs from succeeding
 
     steps:
@@ -142,6 +142,17 @@ jobs:
         run-id: ${{ inputs.vfs_run_id || github.run_id }}
         github-token: ${{ secrets.vfs_token || github.token }}
 
+    - name: Download FastFetch drop
+      if: steps.skip.outputs.result != 'true'
+      continue-on-error: true
+      uses: actions/download-artifact@v8
+      with:
+        name: FastFetch_${{ matrix.configuration }}
+        path: ft
+        repository: ${{ inputs.vfs_repository || github.repository }}
+        run-id: ${{ inputs.vfs_run_id || github.run_id }}
+        github-token: ${{ secrets.vfs_token || github.token }}
+
     - name: ProjFS details (pre-install)
       if: steps.skip.outputs.result != 'true'
       shell: cmd
@@ -193,7 +204,7 @@ jobs:
       run: |
         SET PATH=C:\Program Files\VFS for Git;%PATH%
         SET GIT_TRACE2_PERF=C:\temp\git-trace2.log
-        ft\GVFS.FunctionalTests.exe /result:TestResult.xml --ci --slice=${{ matrix.nr }},10
+        ft\GVFS.FunctionalTests.exe /result:TestResult.xml --ci --slice=${{ matrix.nr }},12
 
     - name: Upload functional test results
       if: always() && steps.skip.outputs.result != 'true'

.github/workflows/upgrade-tests.yaml

@@ -26,7 +26,7 @@ jobs:
 
     strategy:
       matrix:
-        configuration: [ Debug ]
+        configuration: [ Release ]
         scenario:
           - staging-upgrade
           - clean-upgrade

GVFS/GVFS.Common/LogonTaskRegistration.cs

@@ -6,26 +6,25 @@
 namespace GVFS.Common
 {
     /// <summary>
-    /// Registers / updates / unregisters the per-user Windows scheduled task
-    /// that mounts a user's registered GVFS enlistments at logon. Replaces
+    /// Registers / updates / unregisters the machine-wide Windows scheduled task
+    /// that mounts registered GVFS enlistments at logon for each interactive user. Replaces
     /// the role of <c>GVFS.Service</c>'s session-change-driven AutoMount in
     /// the user-level install model.
     /// </summary>
     /// <remarks>
     /// <para>
-    /// The task is registered at <c>\GVFS\AutoMount</c>, scoped to a single
-    /// user (the user's SID is baked into the task's principal and trigger),
-    /// runs at user logon with the user's interactive token, and executes
-    /// <c>gvfs.exe service --mount-all</c>. The mount-all verb already
-    /// reads the user's registered repos (via <see cref="LocalRepoRegistry"/>
-    /// fallback when the service is unavailable) and mounts each one.
+    /// The task is registered at <c>\GVFS\AutoMount</c>, scoped to all
+    /// interactive users (GroupId S-1-5-4), runs at user logon with the
+    /// user's interactive token, and executes <c>gvfs.exe service --mount-all</c>.
+    /// The mount-all verb reads the user's registered repos (via <see cref="LocalRepoRegistry"/>)
+    /// and mounts each one.
     /// </para>
     /// <para>
     /// Drift detection works via a content-hash marker embedded in the
     /// task's Description field
     /// (<c>[gvfs-logon-task-hash=XXXXXXXXXXXXXXXX]</c>). The hash covers the
     /// XML template <em>with placeholders still in place</em>, so it is
-    /// stable across re-substitutions with different user SIDs or gvfs.exe
+    /// stable across re-substitutions with different gvfs.exe
     /// paths -- only template content changes (a code change to the
     /// template constant) bump the hash. <see cref="IsCurrent"/> queries
     /// the registered task XML, extracts the marker, and compares against
@@ -45,7 +44,6 @@ public class LogonTaskRegistration
         public const string FullTaskPath = @"\GVFS\AutoMount";
 
         public const string GvfsPathPlaceholder = "__GVFS_PATH__";
-        public const string UserIdPlaceholder = "__USER_ID__";
         public const string TaskHashPlaceholder = "__TASK_HASH__";
 
         public const string HashMarkerPrefix = "[gvfs-logon-task-hash=";
@@ -55,9 +53,6 @@ public class LogonTaskRegistration
         /// Task XML template. Placeholders:
         /// <list type="bullet">
         /// <item><c>__GVFS_PATH__</c> -- absolute path to gvfs.exe</item>
-        /// <item><c>__USER_ID__</c> -- the user's SID (must be the same one
-        ///   the principal runs as, so the logon trigger fires for the
-        ///   right user)</item>
         /// <item><c>__TASK_HASH__</c> -- content hash of this template,
         ///   inserted into the Description for drift detection</item>
         /// </list>
@@ -69,19 +64,17 @@ public class LogonTaskRegistration
 <Task version=""1.4"" xmlns=""http://schemas.microsoft.com/windows/2004/02/mit/task"">
   <RegistrationInfo>
     <Author>GVFS</Author>
-    <Description>Mounts the user's registered GVFS enlistments at logon. Required by VFS for Git in the user-level install model. [gvfs-logon-task-hash=__TASK_HASH__]</Description>
+    <Description>Mounts registered GVFS enlistments at logon for each interactive user. Required by VFS for Git. [gvfs-logon-task-hash=__TASK_HASH__]</Description>
     <URI>\GVFS\AutoMount</URI>
   </RegistrationInfo>
   <Triggers>
     <LogonTrigger>
       <Enabled>true</Enabled>
-      <UserId>__USER_ID__</UserId>
     </LogonTrigger>
   </Triggers>
   <Principals>
     <Principal id=""Author"">
-      <UserId>__USER_ID__</UserId>
-      <LogonType>InteractiveToken</LogonType>
+      <GroupId>S-1-5-4</GroupId>
       <RunLevel>LeastPrivilege</RunLevel>
     </Principal>
   </Principals>
@@ -145,14 +138,12 @@ public static LogonTaskRegistration CreateForCurrentPlatform(ITracer tracer)
         /// <summary>
         /// Substitute placeholders to produce a registerable task XML.
         /// </summary>
-        public static string BuildTaskXml(string gvfsExePath, string userSid)
+        public static string BuildTaskXml(string gvfsExePath)
         {
             ArgumentException.ThrowIfNullOrEmpty(gvfsExePath);
-            ArgumentException.ThrowIfNullOrEmpty(userSid);
 
             return XmlTemplate
                 .Replace(GvfsPathPlaceholder, gvfsExePath)
-                .Replace(UserIdPlaceholder, userSid)
                 .Replace(TaskHashPlaceholder, TemplateHash);
         }
 
@@ -208,31 +199,29 @@ public bool IsCurrent()
         }
 
         /// <summary>
-        /// Register the logon task with the given gvfs.exe path and user
-        /// SID, overwriting any existing registration. Idempotent: when
+        /// Register the logon task with the given gvfs.exe path,
+        /// overwriting any existing registration. Idempotent: when
         /// the registered task already matches the intended XML (same
         /// hash, same args), this is a fast no-op.
         /// </summary>
-        public bool TryRegisterOrUpdate(string gvfsExePath, string userSid, out string errorMessage)
+        public bool TryRegisterOrUpdate(string gvfsExePath, out string errorMessage)
         {
             ArgumentException.ThrowIfNullOrEmpty(gvfsExePath);
-            ArgumentException.ThrowIfNullOrEmpty(userSid);
 
             if (this.IsCurrent())
             {
                 // Still verify args are right; the hash covers the template
                 // structure but not the substituted gvfs.exe path. Re-query
                 // and check the action command.
                 if (this.invoker.TryQueryXml(FullTaskPath, out string existingXml, out _) &&
-                    existingXml.Contains(gvfsExePath, StringComparison.Ordinal) &&
-                    existingXml.Contains($"<UserId>{userSid}</UserId>", StringComparison.Ordinal))
+                    existingXml.Contains(gvfsExePath, StringComparison.Ordinal))
                 {
                     errorMessage = string.Empty;
                     return true;
                 }
             }
 
-            string xml = BuildTaskXml(gvfsExePath, userSid);
+            string xml = BuildTaskXml(gvfsExePath);
             return this.invoker.TryRegisterFromXml(FullTaskPath, xml, out errorMessage);
         }
 

GVFS/GVFS.FunctionalTests/Categories.cs

@@ -6,6 +6,5 @@ public static class Categories
         public const string FastFetch = "FastFetch";
         public const string GitCommands = "GitCommands";
         public const string NeedsReactionInCI = "NeedsReactionInCI";
-        public const string RequiresService = "RequiresService";
     }
 }

GVFS/GVFS.FunctionalTests/GVFSTestConfig.cs

@@ -18,8 +18,6 @@ public static class GVFSTestConfig
 
         public static bool IsDevMode { get; set; }
 
-        public static bool NoService { get; set; }
-
         public static string PathToGVFS
         {
             get

GVFS/GVFS.FunctionalTests/GlobalSetup.cs

@@ -18,26 +18,6 @@ public void RunBeforeAnyTests()
         [OneTimeTearDown]
         public void RunAfterAllTests()
         {
-            if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
-            {
-                if (!GVFSTestConfig.NoService)
-                {
-                    string serviceLogFolder = Path.Combine(
-                        Environment.GetFolderPath(Environment.SpecialFolder.CommonApplicationData),
-                        "GVFS",
-                        GVFSServiceProcess.TestServiceName,
-                        "Logs");
-
-                    Console.WriteLine("GVFS.Service logs at '{0}' attached below.\n\n", serviceLogFolder);
-                    foreach (string filename in TestResultsHelper.GetAllFilesInDirectory(serviceLogFolder))
-                    {
-                        TestResultsHelper.OutputFileContents(filename);
-                    }
-
-                    GVFSServiceProcess.UninstallService();
-                }
-            }
-
             PrintTestCaseStats.PrintRunTimeStats();
         }
     }

GVFS/GVFS.FunctionalTests/Program.cs

@@ -48,22 +48,11 @@ public static void Main(string[] args)
                 GVFSTestConfig.ReplaceInboxProjFS = true;
             }
 
-            if (runner.HasCustomArg("--no-service"))
-            {
-                Console.WriteLine("Running in no-service mode (user-level install model)");
-                GVFSTestConfig.NoService = true;
-            }
-
             GVFSTestConfig.LocalCacheRoot = runner.GetCustomArgWithParam("--shared-gvfs-cache-root");
 
             HashSet<string> includeCategories = new HashSet<string>();
             HashSet<string> excludeCategories = new HashSet<string>();
 
-            if (GVFSTestConfig.NoService)
-            {
-                excludeCategories.Add(Categories.RequiresService);
-            }
-
             if (runner.HasCustomArg("--full-suite"))
             {
                 Console.WriteLine("Running the full suite of tests");
@@ -162,19 +151,8 @@ private static void RunBeforeAnyTests()
                 ProjFSFilterInstaller.ReplaceInboxProjFS();
             }
 
-            if (!GVFSTestConfig.NoService)
-            {
-                Console.WriteLine("[CI-DEBUG] Installing service...");
-                Console.Out.Flush();
-                GVFSServiceProcess.InstallService();
-                Console.WriteLine("[CI-DEBUG] Service installed successfully");
-                Console.Out.Flush();
-            }
-            else
-            {
-                Console.WriteLine("[CI-DEBUG] Skipping service install (--no-service mode)");
-                Console.Out.Flush();
-            }
+            Console.WriteLine("[CI-DEBUG] Skipping service install (service removed)");
+            Console.Out.Flush();
 
             string serviceProgramDataDir = GVFSPlatform.Instance.GetSecureDataRootForGVFSComponent(
                 GVFSConstants.Service.ServiceName);

GVFS/GVFS.FunctionalTests/Tests/EnlistmentPerFixture/GVFSUpgradeReminderTests.cs

@@ -13,7 +13,6 @@ namespace GVFS.FunctionalTests.Tests.EnlistmentPerFixture
     [TestFixture]
     [NonParallelizable]
     [Category(Categories.ExtraCoverage)]
-    [Category(Categories.RequiresService)]
     public class UpgradeReminderTests : TestsWithEnlistmentPerFixture
     {
         private const string HighestAvailableVersionFileName = "HighestAvailableVersion";

GVFS/GVFS.FunctionalTests/Tests/MultiEnlistmentTests/ServiceVerbTests.cs

@@ -7,7 +7,6 @@ namespace GVFS.FunctionalTests.Tests.MultiEnlistmentTests
     [TestFixture]
     [NonParallelizable]
     [Category(Categories.ExtraCoverage)]
-    [Category(Categories.RequiresService)]
     public class ServiceVerbTests : TestsWithMultiEnlistment
     {
         private static readonly string[] EmptyRepoList = new string[] { };