Rename Kill methods to SafeKill to preserve previous naming conventions.

Author: brdeyo

VERSION

@@ -1 +1 @@
-2.1.21
+2.1.22

src/VirtualClient/VirtualClient.Actions/3DMark/ThreeDMarkExecutor.cs

@@ -175,7 +175,7 @@ private Task ExecuteWorkloadAsync(EventContext telemetryContext, CancellationTok
                 // Point 3DMark to DLC Path
                 using (IProcessProxy process = this.systemManagement.ProcessManager.CreateProcess(psexec, $"{baseArg} {this.ExecutablePath} --path={this.DLCPath}", this.psexecDir))
                 {
-                    this.CleanupTasks.Add(() => process.SafeKill());
+                    this.CleanupTasks.Add(() => process.SafeKill(this.Logger));
 
                     try
                     {
@@ -201,7 +201,7 @@ private Task ExecuteWorkloadAsync(EventContext telemetryContext, CancellationTok
                 // Lisence Registry
                 using (IProcessProxy process = this.systemManagement.ProcessManager.CreateProcess(psexec, $"{baseArg} {this.ExecutablePath} --register={this.LisenceKey}", this.psexecDir))
                 {
-                    this.CleanupTasks.Add(() => process.SafeKill());
+                    this.CleanupTasks.Add(() => process.SafeKill(this.Logger));
 
                     try
                     {
@@ -238,7 +238,7 @@ private Task ExecuteWorkloadAsync(EventContext telemetryContext, CancellationTok
 
                         using (IProcessProxy process = this.systemManagement.ProcessManager.CreateProcess(psexec, commandArguments, this.psexecDir))
                         {
-                            this.CleanupTasks.Add(() => process.SafeKill());
+                            this.CleanupTasks.Add(() => process.SafeKill(this.Logger));
 
                             try
                             {
@@ -264,7 +264,7 @@ private Task ExecuteWorkloadAsync(EventContext telemetryContext, CancellationTok
                         string commandArguments2 = $"{baseArg} {this.ExecutablePath} --in={this.OutFileName} --export=result.xml";
                         using (IProcessProxy process = this.systemManagement.ProcessManager.CreateProcess(psexec, commandArguments2, this.psexecDir))
                         {
-                            this.CleanupTasks.Add(() => process.SafeKill());
+                            this.CleanupTasks.Add(() => process.SafeKill(this.Logger));
 
                             try
                             {

src/VirtualClient/VirtualClient.Actions/7zip/Compression7zipExecutor.cs

@@ -170,7 +170,7 @@ await this.Logger.LogMessageAsync($"{nameof(Compression7zipExecutor)}.ExecutePro
                     DateTime start = DateTime.Now;
                     using (IProcessProxy process = this.systemManager.ProcessManager.CreateElevatedProcess(this.Platform, pathToExe, commandLineArguments, workingDirectory))
                     {
-                        this.CleanupTasks.Add(() => process.SafeKill());
+                        this.CleanupTasks.Add(() => process.SafeKill(this.Logger));
                         await process.StartAndWaitAsync(cancellationToken)
                             .ConfigureAwait(false);
 

src/VirtualClient/VirtualClient.Actions/ASPNET/AspNetBenchExecutor.cs

@@ -227,10 +227,10 @@ private async Task ExecuteCommandAsync(string pathToExe, string commandLineArgum
                 {
                     if (isServer)
                     {
-                        this.killServer = () => process.SafeKill();
+                        this.killServer = () => process.SafeKill(this.Logger);
                     }
 
-                    this.CleanupTasks.Add(() => process.SafeKill());
+                    this.CleanupTasks.Add(() => process.SafeKill(this.Logger));
                     await process.StartAndWaitAsync(cancellationToken).ConfigureAwait(false);
 
                     if (!cancellationToken.IsCancellationRequested)

src/VirtualClient/VirtualClient.Actions/CtsTraffic/CtsTrafficServerExecutor.cs

@@ -134,7 +134,7 @@ await this.Logger.LogMessageAsync($"{this.TypeName}.ExecuteWorkload", relatedCon
 
                     process = processManager.CreateProcess(command, commandArguments, workingDirectory);
 
-                    this.CleanupTasks.Add(() => process.SafeKill());
+                    this.CleanupTasks.Add(() => process.SafeKill(this.Logger));
                     this.Logger.LogTraceMessage($"Executing: {command} {commandArguments}".Trim(), relatedContext);
 
                     if (!process.Start())

src/VirtualClient/VirtualClient.Actions/DCGMI/DCGMIExecutor.cs

@@ -267,7 +267,7 @@ await this.Logger.LogMessageAsync($"{typeof(TExecutor).Name}.ExecuteProcess", te
                 {
                     using (IProcessProxy process = this.systemManagement.ProcessManager.CreateElevatedProcess(this.Platform, command, null, workingDirectory))
                     {
-                        this.CleanupTasks.Add(() => process.SafeKill());
+                        this.CleanupTasks.Add(() => process.SafeKill(this.Logger));
                         process.RedirectStandardOutput = true;
                         await process.StartAndWaitAsync(cancellationToken).ConfigureAwait(false);
 

src/VirtualClient/VirtualClient.Actions/DXMicrobenchmarks/DXFLOPSExecutor.cs

@@ -144,7 +144,7 @@ private Task ExecuteWorkloadAsync(EventContext telemetryContext, CancellationTok
                     string cmdargs = $"--num_loops 1 --num_loops_in_shader {this.ShaderIterations} --thread_num_per_block {this.ThreadsPerBlock} --num_data_elements {this.NumDataElements} {(this.Precision == "f16" ? "--f16 1" : "--f32 1")}";
                     using (IProcessProxy process = this.systemManagement.ProcessManager.CreateProcess(this.ExecutablePath, cmdargs))
                     {
-                        this.CleanupTasks.Add(() => process.SafeKill());
+                        this.CleanupTasks.Add(() => process.SafeKill(this.Logger));
                         process.RedirectStandardOutput = true;
                         try
                         {

src/VirtualClient/VirtualClient.Actions/DeathStarBench/DeathStarBenchExecutor.cs

@@ -415,7 +415,7 @@ await this.Logger.LogMessageAsync($"{this.TypeName}.ExecuteProcess", telemetryCo
                 {
                     using (IProcessProxy process = this.SystemManager.ProcessManager.CreateElevatedProcess(this.Platform, command, null, workingDirectory))
                     {
-                        this.CleanupTasks.Add(() => process.SafeKill());
+                        this.CleanupTasks.Add(() => process.SafeKill(this.Logger));
                         await process.StartAndWaitAsync(cancellationToken)
                             .ConfigureAwait();
 

src/VirtualClient/VirtualClient.Actions/Examples/ClientServer/ExampleClientExecutor.cs

@@ -261,7 +261,7 @@ private Task ExecuteWorkloadAsync(IPAddress serverIpAddress, EventContext teleme
                 // We create a operating system process to host the executing workload, start it and wait for it to exit.
                 using (IProcessProxy workloadProcess = this.ProcessManager.CreateProcess(this.WorkloadExecutablePath, commandArguments, this.WorkloadPackage.Path))
                 {
-                    this.CleanupTasks.Add(() => workloadProcess.SafeKill());
+                    this.CleanupTasks.Add(() => workloadProcess.SafeKill(this.Logger));
 
                     await workloadProcess.StartAndWaitAsync(cancellationToken)
                         .ConfigureAwait(false);

src/VirtualClient/VirtualClient.Actions/Examples/ClientServer/ExampleReverseProxyExecutor.cs

@@ -198,7 +198,7 @@ private async Task StartWebServerAsync(IEnumerable<IPAddress> serverIpAddresses,
                     throw new WorkloadException($"The API reverse proxy workload did not start as expected.", ErrorReason.WorkloadFailed);
                 }
 
-                this.CleanupTasks.Add(() => webHostProcess.SafeKill());
+                this.CleanupTasks.Add(() => webHostProcess.SafeKill(this.Logger));
 
                 // Notify clients that the reverse proxy server is online.
                 Item<State> serverOnline = new Item<State>(ExampleClientServerExecutor.ServerReadyState, new State());