Skip to content

Commit 0b16547

Browse files
rudraptpsinghRudra Pratap SIngh
andauthored
Add send/receive suffix to full-duplex log file names (#710)
In full-duplex mode, both send and receive processes were logged with the same tool name 'NTttcp', resulting in log files that were only distinguishable by timestamp. This makes it hard to identify which log belongs to the sender vs receiver. Pass 'NTttcp-Send' and 'NTttcp-Receive' as the tool name to LogProcessDetailsAsync so log files are named: <timestamp>-ntttcp_tcp_4k_buffer_t1-send.log <timestamp>-ntttcp_tcp_4k_buffer_t1-receive.log Co-authored-by: Rudra Pratap SIngh <rudrasingh@microsoft.com>
1 parent a8bd5b7 commit 0b16547

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

  • src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/NTttcp

src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/NTttcp/NTttcpExecutor.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -504,7 +504,7 @@ await this.ProcessStartRetryPolicy.ExecuteAsync(async () =>
504504
await this.LogProcessDetailsAsync(
505505
sendProcess,
506506
relatedContext,
507-
"NTttcp",
507+
"NTttcp-Send",
508508
results: new KeyValuePair<string, string>(this.SendResultsPath, sendResults));
509509

510510
this.CaptureDirectionalMetrics(
@@ -518,7 +518,7 @@ await this.LogProcessDetailsAsync(
518518
}
519519
else
520520
{
521-
await this.LogProcessDetailsAsync(sendProcess, relatedContext, "NTttcp");
521+
await this.LogProcessDetailsAsync(sendProcess, relatedContext, "NTttcp-Send");
522522
this.Logger.LogMessage($"{this.TypeName}.FullDuplexSendFailed", LogLevel.Warning, relatedContext);
523523
}
524524

@@ -531,7 +531,7 @@ await this.LogProcessDetailsAsync(
531531
await this.LogProcessDetailsAsync(
532532
receiveProcess,
533533
relatedContext,
534-
"NTttcp",
534+
"NTttcp-Receive",
535535
results: new KeyValuePair<string, string>(this.ReceiveResultsPath, receiveResults));
536536

537537
this.CaptureDirectionalMetrics(
@@ -545,7 +545,7 @@ await this.LogProcessDetailsAsync(
545545
}
546546
else
547547
{
548-
await this.LogProcessDetailsAsync(receiveProcess, relatedContext, "NTttcp");
548+
await this.LogProcessDetailsAsync(receiveProcess, relatedContext, "NTttcp-Receive");
549549
this.Logger.LogMessage($"{this.TypeName}.FullDuplexReceiveFailed", LogLevel.Warning, relatedContext);
550550
}
551551

0 commit comments

Comments
 (0)