Skip to content

Commit 668c720

Browse files
authored
Fix NTTTCP to use the NoSync parameter on both sides (#587)
* NTTTCP must use the NoSync parameter on both sides when running on Linux and Windows * bump version to 2.1.40
1 parent 67b4a03 commit 668c720

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2.1.39
1+
2.1.40

src/VirtualClient/VirtualClient.Actions/Network/NetworkingWorkload/NTttcp/NTttcpExecutor.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -454,7 +454,7 @@ private string GetWindowsSpecificCommandLine()
454454
$"-p {this.Port} " +
455455
$"-xml {this.ResultsPath} " +
456456
$"{(this.Protocol.ToLowerInvariant() == "udp" ? "-u" : string.Empty)} " +
457-
$"{((this.IsInClientRole && this.NoSyncEnabled == true) ? "-ns" : string.Empty)} " +
457+
$"{(this.NoSyncEnabled == true ? "-ns" : string.Empty)} " +
458458
$"{(this.IsInClientRole ? $"-nic {clientIPAddress}" : string.Empty)}".Trim();
459459
}
460460

@@ -475,7 +475,7 @@ private string GetLinuxSpecificCommandLine()
475475
$"{((this.IsInServerRole && this.ReceiverMultiClientMode == true) ? "-M" : string.Empty)} " +
476476
$"{((this.IsInClientRole && this.ThreadsPerServerPort != null) ? $"-n {this.ThreadsPerServerPort}" : string.Empty)} " +
477477
$"{((this.IsInClientRole && this.ConnectionsPerThread != null) ? $"-l {this.ConnectionsPerThread}" : string.Empty)} " +
478-
$"{((this.IsInClientRole && this.NoSyncEnabled == true) ? "-N" : string.Empty)} " +
478+
$"{(this.NoSyncEnabled == true ? "-N" : string.Empty)} " +
479479
$"{((this.DevInterruptsDifferentiator != null) ? $"--show-dev-interrupts {this.DevInterruptsDifferentiator}" : string.Empty)}".Trim();
480480
}
481481
}

0 commit comments

Comments
 (0)