From fa4e61906953b662634b27ab27fe52dc746028a8 Mon Sep 17 00:00:00 2001 From: saibulusu Date: Mon, 28 Jul 2025 17:07:01 -0700 Subject: [PATCH 1/7] Fixing ExecuteCommandTheResolvedPackagePathExpressionsWhenExecutingCommandsOnUnixSystems. --- .../VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/VirtualClient/VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs b/src/VirtualClient/VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs index d67a542dc6..1b5ac4c96c 100644 --- a/src/VirtualClient/VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs +++ b/src/VirtualClient/VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs @@ -467,7 +467,7 @@ public async Task ExecuteCommandTheResolvedPackagePathExpressionsWhenExecutingCo [Test] public async Task ExecuteCommandTheResolvedPackagePathExpressionsWhenExecutingCommandsOnUnixSystems() { - this.SetupDefaults(PlatformID.Win32NT); + this.SetupDefaults(PlatformID.Unix); string packagePath = this.mockFixture.GetPackagePath("anypackage"); // The package MUST exist on the system. From b8fc173bded80e861da51ecc6dfdec7869ca5e78 Mon Sep 17 00:00:00 2001 From: saibulusu Date: Mon, 28 Jul 2025 17:32:29 -0700 Subject: [PATCH 2/7] Debugging ExecuteCommandTheResolvedPackagePathExpressionsWhenExecutingCommandsOnWindowsSystems. --- .../VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/VirtualClient/VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs b/src/VirtualClient/VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs index 1b5ac4c96c..aee60e98de 100644 --- a/src/VirtualClient/VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs +++ b/src/VirtualClient/VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs @@ -452,6 +452,7 @@ public async Task ExecuteCommandTheResolvedPackagePathExpressionsWhenExecutingCo { this.mockFixture.ProcessManager.OnProcessCreated = (process) => { + Console.WriteLine(process.FullCommand()); expectedCommands.Remove(process.FullCommand()); Assert.AreEqual(packagePath, process.StartInfo.WorkingDirectory); confirmed = true; From 112e1ed5cf5e14c9beefec6850463a9e57ec994c Mon Sep 17 00:00:00 2001 From: saibulusu Date: Mon, 28 Jul 2025 20:31:08 -0700 Subject: [PATCH 3/7] Debugging ExecuteCommandTheResolvedPackagePathExpressionsWhenExecutingCommandsOnWindowsSystems. --- .../VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/VirtualClient/VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs b/src/VirtualClient/VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs index aee60e98de..008366efde 100644 --- a/src/VirtualClient/VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs +++ b/src/VirtualClient/VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs @@ -455,6 +455,7 @@ public async Task ExecuteCommandTheResolvedPackagePathExpressionsWhenExecutingCo Console.WriteLine(process.FullCommand()); expectedCommands.Remove(process.FullCommand()); Assert.AreEqual(packagePath, process.StartInfo.WorkingDirectory); + Console.WriteLine(process.StartInfo.WorkingDirectory); confirmed = true; }; From 177495896e7b10d2c905dcea6a378431286c037d Mon Sep 17 00:00:00 2001 From: saibulusu Date: Mon, 28 Jul 2025 20:45:08 -0700 Subject: [PATCH 4/7] Debugging ExecuteCommandTheResolvedPackagePathExpressionsWhenExecutingCommandsOnWindowsSystems. --- .../VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/VirtualClient/VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs b/src/VirtualClient/VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs index 008366efde..96baefefcf 100644 --- a/src/VirtualClient/VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs +++ b/src/VirtualClient/VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs @@ -456,6 +456,8 @@ public async Task ExecuteCommandTheResolvedPackagePathExpressionsWhenExecutingCo expectedCommands.Remove(process.FullCommand()); Assert.AreEqual(packagePath, process.StartInfo.WorkingDirectory); Console.WriteLine(process.StartInfo.WorkingDirectory); + Console.WriteLine(process.StartInfo.FileName); + Console.WriteLine(process.StartInfo.Arguments); confirmed = true; }; From 3736e64aa41a37dda51f785327158875349c8d7b Mon Sep 17 00:00:00 2001 From: saibulusu Date: Tue, 29 Jul 2025 01:08:34 -0700 Subject: [PATCH 5/7] Printing full command in GetCommandsToExecute. --- .../ExecuteCommandTests.cs | 8 ++++---- .../VirtualClient.Dependencies/ExecuteCommand.cs | 1 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/VirtualClient/VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs b/src/VirtualClient/VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs index 96baefefcf..b1901d59a5 100644 --- a/src/VirtualClient/VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs +++ b/src/VirtualClient/VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs @@ -452,12 +452,12 @@ public async Task ExecuteCommandTheResolvedPackagePathExpressionsWhenExecutingCo { this.mockFixture.ProcessManager.OnProcessCreated = (process) => { - Console.WriteLine(process.FullCommand()); + // Console.WriteLine(process.FullCommand()); expectedCommands.Remove(process.FullCommand()); Assert.AreEqual(packagePath, process.StartInfo.WorkingDirectory); - Console.WriteLine(process.StartInfo.WorkingDirectory); - Console.WriteLine(process.StartInfo.FileName); - Console.WriteLine(process.StartInfo.Arguments); + // Console.WriteLine(process.StartInfo.WorkingDirectory); + // Console.WriteLine(process.StartInfo.FileName); + // Console.WriteLine(process.StartInfo.Arguments); confirmed = true; }; diff --git a/src/VirtualClient/VirtualClient.Dependencies/ExecuteCommand.cs b/src/VirtualClient/VirtualClient.Dependencies/ExecuteCommand.cs index a4357a0e4f..e5e59f2158 100644 --- a/src/VirtualClient/VirtualClient.Dependencies/ExecuteCommand.cs +++ b/src/VirtualClient/VirtualClient.Dependencies/ExecuteCommand.cs @@ -212,6 +212,7 @@ private IEnumerable GetCommandsToExecute() } else { + Console.WriteLine($"Command: {fullCommand}"); commandsToExecute.Add(fullCommand); } } From d3d47057c3a9173c31de8f585210f372e80c75d2 Mon Sep 17 00:00:00 2001 From: saibulusu Date: Tue, 29 Jul 2025 12:45:25 -0700 Subject: [PATCH 6/7] Adding platform win. --- .../ExecuteCommandTests.cs | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/VirtualClient/VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs b/src/VirtualClient/VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs index b1901d59a5..2dbab9e503 100644 --- a/src/VirtualClient/VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs +++ b/src/VirtualClient/VirtualClient.Dependencies.UnitTests/ExecuteCommandTests.cs @@ -428,6 +428,7 @@ public async Task ExecuteCommandResolvesPackagePathExpressionsOnInitializationIn } [Test] + [Platform("Win")] public async Task ExecuteCommandTheResolvedPackagePathExpressionsWhenExecutingCommandsOnWindowsSystems() { this.SetupDefaults(PlatformID.Win32NT); @@ -452,12 +453,8 @@ public async Task ExecuteCommandTheResolvedPackagePathExpressionsWhenExecutingCo { this.mockFixture.ProcessManager.OnProcessCreated = (process) => { - // Console.WriteLine(process.FullCommand()); expectedCommands.Remove(process.FullCommand()); Assert.AreEqual(packagePath, process.StartInfo.WorkingDirectory); - // Console.WriteLine(process.StartInfo.WorkingDirectory); - // Console.WriteLine(process.StartInfo.FileName); - // Console.WriteLine(process.StartInfo.Arguments); confirmed = true; }; From 6ff1e18252077c13debdd4d98f9d4c39d05884b9 Mon Sep 17 00:00:00 2001 From: saibulusu Date: Tue, 29 Jul 2025 12:50:37 -0700 Subject: [PATCH 7/7] Removing unnecessary line. --- src/VirtualClient/VirtualClient.Dependencies/ExecuteCommand.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/VirtualClient/VirtualClient.Dependencies/ExecuteCommand.cs b/src/VirtualClient/VirtualClient.Dependencies/ExecuteCommand.cs index 64da73ebfa..7105278f7e 100644 --- a/src/VirtualClient/VirtualClient.Dependencies/ExecuteCommand.cs +++ b/src/VirtualClient/VirtualClient.Dependencies/ExecuteCommand.cs @@ -201,7 +201,6 @@ private IEnumerable GetCommandsToExecute() } else { - Console.WriteLine($"Command: {fullCommand}"); commandsToExecute.Add(fullCommand); } }