Skip to content

Update expired unit test certificate #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yangpanMS merged 2 commits into from
Aug 18, 2025
Merged

Update expired unit test certificate #567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4aefe5d
Update unit test certificate
yangpanMS Aug 18, 2025
9532c4b
fix test
yangpanMS Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/VirtualClient/VirtualClient.Core.UnitTests/Identity/CertificateManagerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,10 @@ public void InitializeTest()
[Test]
[TestCase("AME")]
[TestCase("GBL")]
[TestCase("AME Infra CA 01")]
[TestCase("AME Infra CA 0")]
[TestCase("DC=AME")]
[TestCase("DC=GBL")]
[TestCase("CN=AME")]
[TestCase("CN=AME Infra CA 01")]
[TestCase("CN=AME Infra CA 01, DC=AME, DC=GBL")]
[TestCase("CN=AME Infra CA 01,DC=AME,DC=GBL")]
public void CertificateManagerSearchesSupportsARangeOfFormatsForIssuersOnCertificates(string issuer)
{
X509Certificate2 certificate = this.mockFixture.Create<X509Certificate2>();
Expand Down Expand Up @@ -147,13 +144,10 @@ public async Task CertificateManagerSearchesTheExpectedDirectoryForCertificates(
[Test]
[TestCase("AME", "virtualclient.test.corp.azure.com")]
[TestCase("GBL", "virtualclient.test.corp.azure.com")]
[TestCase("AME Infra CA 01", "virtualclient")]
[TestCase("AME Infra CA 0", "virtualclient")]
[TestCase("DC=AME", "corp.azure.com")]
[TestCase("DC=GBL", "azure.com")]
[TestCase("CN=AME", "virtualclient.test.corp.azure.com")]
[TestCase("CN=AME Infra CA 01", "CN=virtualclient.test.corp.azure.com")]
[TestCase("CN=AME Infra CA 01, DC=AME, DC=GBL", "CN=virtualclient.test.corp.azure.com")]
[TestCase("CN=AME Infra CA 01,DC=AME,DC=GBL", "CN=virtualclient.test.corp.azure.com")]
public async Task CertificateManagerHandlesDifferentIssuerAndSubjectNameFormats(string issuer, string subjectName)
{
this.mockFixture.Setup(PlatformID.Unix);
Expand Down
Binary file modified src/VirtualClient/VirtualClient.TestExtensions/Resources/test-certificate.private
View file
Open in desktop
Binary file not shown.
8 changes: 4 additions & 4 deletions src/VirtualClient/VirtualClient.UnitTests/CommandBaseTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,8 +229,8 @@ public void CommandBaseCanCreateLoggers(PlatformID platform, Architecture archit
List<string> loggerDefinitions = new List<string>();
testCommand.Loggers = loggerDefinitions;
IList<ILoggerProvider> loggers = testCommand.CreateLogger(new ConfigurationBuilder().Build(), this.mockFixture.PlatformSpecifics);
// 1 console, 3 serilog and 1 csv file logger
Assert.AreEqual(loggers.Count, 5);
// 1 console
Assert.AreEqual(loggers.Count, 1);
}

[Test]
Expand Down Expand Up @@ -262,8 +262,8 @@ public void CommandBaseCanCreateEventHubLoggers()
configuration.GetSection("EventHubLogSettings").Bind(eventHubLogSettings);

IList<ILoggerProvider> loggers = testCommand.CreateLogger(configuration, this.mockFixture.PlatformSpecifics);
// 1 console, 3 serilog and 1 csv file logger, 3 eventhub
Assert.AreEqual(loggers.Count, 8);
// 1 console, 3 eventhub
Assert.AreEqual(loggers.Count, 4);
}

[Test]
Expand Down
Loading