Don't kill the test process during cleanup (#40503)

Author: OneBlue

test/windows/Common.cpp

@@ -70,7 +70,6 @@ std::wstring g_testDistroPath;
 std::wstring g_testDataPath;
 bool g_fastTestRun = false; // True when test.bat was invoked with -f
 static wil::unique_mta_usage_cookie g_mtaCookie;
-static wil::unique_handle g_processJob;
 
 std::pair<wil::unique_handle, wil::unique_handle> CreateSubprocessPipe(bool inheritRead, bool inheritWrite, DWORD bufferSize, _In_opt_ SECURITY_ATTRIBUTES* sa)
 {
@@ -1980,13 +1979,15 @@ Return Value:
     THROW_IF_FAILED(CoIncrementMTAUsage(&g_mtaCookie));
 
     // Assign a job object to the current process to ensure that we don't leak processes on failure.
-    g_processJob.reset(CreateJobObjectW(nullptr, nullptr));
-    THROW_LAST_ERROR_IF(!g_processJob);
+    // N.B. When the job object is closed, all processes associated with the job will be terminated.
+    // Because of that, we're purposefully leaking this job object so we don't kill the test process on cleanup.
+    auto job = CreateJobObjectW(nullptr, nullptr);
+    THROW_LAST_ERROR_IF(!job);
 
     JOBOBJECT_EXTENDED_LIMIT_INFORMATION jobInfo{};
     jobInfo.BasicLimitInformation.LimitFlags = JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE;
-    THROW_IF_WIN32_BOOL_FALSE(SetInformationJobObject(g_processJob.get(), JobObjectExtendedLimitInformation, &jobInfo, sizeof(jobInfo)));
-    THROW_IF_WIN32_BOOL_FALSE(AssignProcessToJobObject(g_processJob.get(), GetCurrentProcess()));
+    THROW_IF_WIN32_BOOL_FALSE(SetInformationJobObject(job, JobObjectExtendedLimitInformation, &jobInfo, sizeof(jobInfo)));
+    THROW_IF_WIN32_BOOL_FALSE(AssignProcessToJobObject(job, GetCurrentProcess()));
 
 // Don't crash for unknown exceptions (makes debugging testpasses harder)
 #ifndef _DEBUG