Skip to content

Commit 84ff9ae

Browse files
Xianwei Zhaogregkh
authored andcommitted
irqchip/meson-gpio: Use the correct register in meson_s4_gpio_irq_set_type()
commit 5363b67ac8ebcc3e227dbf59fc8061949109841d upstream. meson_s4_gpio_irq_set_type() uses the both-edge trigger register for configuring level type and single edge mode interrupts, which is not correct. Use REG_EDGE_POL instead. Fixes: bbd6fcc ("irqchip: Add support for Amlogic A4 and A5 SoCs") Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com> Signed-off-by: Thomas Gleixner <tglx@kernel.org> Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20260508-a9-gpio-irqchip-v1-1-9dc5f3e022e0@amlogic.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 5b0756b commit 84ff9ae

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

drivers/irqchip/irq-meson-gpio.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -404,8 +404,7 @@ static int meson_s4_gpio_irq_set_type(struct meson_gpio_irq_controller *ctl,
404404
if (type & (IRQ_TYPE_EDGE_RISING | IRQ_TYPE_EDGE_FALLING))
405405
val |= BIT(ctl->params->edge_single_offset + idx);
406406

407-
meson_gpio_irq_update_bits(ctl, params->edge_pol_reg,
408-
BIT(idx) | BIT(12 + idx), val);
407+
meson_gpio_irq_update_bits(ctl, REG_EDGE_POL, BIT(idx) | BIT(12 + idx), val);
409408
return 0;
410409
};
411410

0 commit comments

Comments
 (0)