Skip to content

Fix FlipView LocalizedControlType for accessibility compliance #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 4 commits into from
Closed

Fix FlipView LocalizedControlType for accessibility compliance #1996

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
567be18
Initial plan
Copilot Jul 30, 2025
709e89b
Add LocalizedControlType to FlipView controls for accessibility
Copilot Jul 30, 2025
3df03a8
Add comprehensive tests for FlipView LocalizedControlType accessibility
Copilot Jul 30, 2025
9bb8b0f
Remove tests and LocalizedControlType from XAML code snippets per fee…
Copilot Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions WinUIGallery/Samples/ControlPages/FlipViewPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
ExampleHeight="Auto"
HeaderText="A simple FlipView with items declared inline.">
<controls:ControlExample.Example>
<FlipView Height="270" MaxWidth="400">
<FlipView Height="270" MaxWidth="400" AutomationProperties.LocalizedControlType="FlipView">
<Image AutomationProperties.Name="Cliff" Source="ms-appx:///Assets/SampleMedia/cliff.jpg" />
<Image AutomationProperties.Name="Grapes" Source="ms-appx:///Assets/SampleMedia/grapes.jpg" />
<Image AutomationProperties.Name="Rainier" Source="ms-appx:///Assets/SampleMedia/rainier.jpg" />
Expand All @@ -49,6 +49,7 @@
MaxWidth="400"
BorderBrush="Black"
BorderThickness="1"
AutomationProperties.LocalizedControlType="FlipView"
ItemsSource="{x:Bind Items, Mode=OneWay}">
<FlipView.ItemTemplate>
<DataTemplate x:DataType="models:ControlInfoDataItem">
Expand Down Expand Up @@ -98,7 +99,7 @@
</controls:ControlExample>
<controls:ControlExample x:Name="Example3" HeaderText="Vertical FlipView">
<controls:ControlExample.Example>
<FlipView Height="270" MaxWidth="400">
<FlipView Height="270" MaxWidth="400" AutomationProperties.LocalizedControlType="FlipView">
<Image AutomationProperties.Name="Cliff" Source="ms-appx:///Assets/SampleMedia/cliff.jpg" />
<Image AutomationProperties.Name="Grapes" Source="ms-appx:///Assets/SampleMedia/grapes.jpg" />
<Image AutomationProperties.Name="Rainier" Source="ms-appx:///Assets/SampleMedia/rainier.jpg" />
Expand All @@ -124,7 +125,7 @@
&lt;VirtualizingStackPanel Orientation="Vertical"/&gt;
&lt;/ItemsPanelTemplate&gt;
&lt;/FlipView.ItemsPanel&gt;
&lt;FlipView&gt;
&lt;/FlipView&gt;
</x:String>
</controls:ControlExample.Xaml>
</controls:ControlExample>
Expand Down