Skip to content

Fix DropDownButton content update on menu item selection #2089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
Closed

Fix DropDownButton content update on menu item selection #2089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13c02c0
Initial plan
Copilot Dec 18, 2025
394fee7
Add click handlers to update DropDownButton content on selection
Copilot Dec 18, 2025
540327c
Address code review: Add type validation for Tag property
Copilot Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions WinUIGallery/Samples/ControlPages/DropDownButtonPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@
<StackPanel>
<controls:ControlExample HeaderText="Simple DropDownButton" XamlSource="Buttons/DropDown/DropDownButton_Simple.txt">
<StackPanel x:Name="Control1" Orientation="Horizontal">
<DropDownButton Content="Email">
<DropDownButton x:Name="EmailDropDownButton" Content="Email">
<DropDownButton.Flyout>
<MenuFlyout Placement="BottomEdgeAlignedLeft">
<MenuFlyoutItem Text="Send" />
<MenuFlyoutItem Text="Reply" />
<MenuFlyoutItem Text="Reply All" />
<MenuFlyoutItem Text="Send" Click="EmailMenuItem_Click" />
<MenuFlyoutItem Text="Reply" Click="EmailMenuItem_Click" />
<MenuFlyoutItem Text="Reply All" Click="EmailMenuItem_Click" />
</MenuFlyout>
</DropDownButton.Flyout>
</DropDownButton>
Expand All @@ -24,23 +24,26 @@

<controls:ControlExample HeaderText="DropDownButton with Icons" XamlSource="Buttons/DropDown/DropDownButton_Icon.txt">
<StackPanel x:Name="Control2" Orientation="Horizontal">
<DropDownButton AutomationProperties.Name="Email">
<DropDownButton x:Name="EmailIconDropDownButton" AutomationProperties.Name="Email">
<DropDownButton.Content>
<FontIcon Glyph="&#xE715;" />
<StackPanel Orientation="Horizontal" Spacing="8">
<FontIcon x:Name="EmailIcon" Glyph="&#xE715;" />
<TextBlock x:Name="EmailIconText" Text="Email" />
</StackPanel>
</DropDownButton.Content>
<DropDownButton.Flyout>
<MenuFlyout Placement="BottomEdgeAlignedLeft">
<MenuFlyoutItem Text="Send">
<MenuFlyoutItem Text="Send" Click="EmailIconMenuItem_Click" Tag="&#xE725;">
<MenuFlyoutItem.Icon>
<FontIcon Glyph="&#xE725;" />
</MenuFlyoutItem.Icon>
</MenuFlyoutItem>
<MenuFlyoutItem Text="Reply">
<MenuFlyoutItem Text="Reply" Click="EmailIconMenuItem_Click" Tag="&#xE8CA;">
<MenuFlyoutItem.Icon>
<FontIcon Glyph="&#xE8CA;" />
</MenuFlyoutItem.Icon>
</MenuFlyoutItem>
<MenuFlyoutItem Text="Reply All">
<MenuFlyoutItem Text="Reply All" Click="EmailIconMenuItem_Click" Tag="&#xE8C2;">
<MenuFlyoutItem.Icon>
<FontIcon Glyph="&#xE8C2;" />
</MenuFlyoutItem.Icon>
Expand Down
23 changes: 23 additions & 0 deletions WinUIGallery/Samples/ControlPages/DropDownButtonPage.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

using Microsoft.UI.Xaml;
using Microsoft.UI.Xaml.Controls;

namespace WinUIGallery.ControlPages;
Expand All @@ -11,4 +12,26 @@ public DropDownButtonPage()
{
this.InitializeComponent();
}

private void EmailMenuItem_Click(object sender, RoutedEventArgs e)
{
var menuItem = sender as MenuFlyoutItem;
if (menuItem != null)
{
EmailDropDownButton.Content = menuItem.Text;
}
}

private void EmailIconMenuItem_Click(object sender, RoutedEventArgs e)
{
var menuItem = sender as MenuFlyoutItem;
if (menuItem != null)
{
if (menuItem.Tag is string glyph)
{
EmailIcon.Glyph = glyph;
}
EmailIconText.Text = menuItem.Text;
}
}
}
13 changes: 8 additions & 5 deletions WinUIGallery/Samples/SampleCode/Buttons/DropDown/DropDownButton_Icon.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,23 @@
<DropDownButton AutomationProperties.Name="Email">
<DropDownButton x:Name="EmailIconDropDownButton" AutomationProperties.Name="Email">
<DropDownButton.Content>
<FontIcon Glyph="&#xE715;"/>
<StackPanel Orientation="Horizontal" Spacing="8">
<FontIcon x:Name="EmailIcon" Glyph="&#xE715;"/>
<TextBlock x:Name="EmailIconText" Text="Email"/>
</StackPanel>
</DropDownButton.Content>
<DropDownButton.Flyout>
<MenuFlyout Placement="Bottom">
<MenuFlyoutItem Text="Send">
<MenuFlyoutItem Text="Send" Click="EmailIconMenuItem_Click" Tag="&#xE725;">
<MenuFlyoutItem.Icon>
<FontIcon Glyph="&#xE725;"/>
</MenuFlyoutItem.Icon>
</MenuFlyoutItem>
<MenuFlyoutItem Text="Reply">
<MenuFlyoutItem Text="Reply" Click="EmailIconMenuItem_Click" Tag="&#xE8CA;">
<MenuFlyoutItem.Icon>
<FontIcon Glyph="&#xE8CA;"/>
</MenuFlyoutItem.Icon>
</MenuFlyoutItem>
<MenuFlyoutItem Text="Reply All">
<MenuFlyoutItem Text="Reply All" Click="EmailIconMenuItem_Click" Tag="&#xE8C2;">
<MenuFlyoutItem.Icon>
<FontIcon Glyph="&#xE8C2;"/>
</MenuFlyoutItem.Icon>
Expand Down
8 changes: 4 additions & 4 deletions WinUIGallery/Samples/SampleCode/Buttons/DropDown/DropDownButton_Simple.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<DropDownButton Content="Email">
<DropDownButton x:Name="EmailDropDownButton" Content="Email">
<DropDownButton.Flyout>
<MenuFlyout Placement="Bottom">
<MenuFlyoutItem Text="Send"/>
<MenuFlyoutItem Text="Reply"/>
<MenuFlyoutItem Text="Reply All"/>
<MenuFlyoutItem Text="Send" Click="EmailMenuItem_Click"/>
<MenuFlyoutItem Text="Reply" Click="EmailMenuItem_Click"/>
<MenuFlyoutItem Text="Reply All" Click="EmailMenuItem_Click"/>
</MenuFlyout>
</DropDownButton.Flyout>
</DropDownButton>