Skip to content

Commit 51b87dd

Browse files
committed
Remove empty "Semmle-specific notes" sections.
1 parent 6ac9d3a commit 51b87dd

50 files changed

Lines changed: 47 additions & 203 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

src/drivers/apps/queries/experimental/UnsafeCallInGlobalInit/UnsafeCallInGlobalInit.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,8 @@ DLLMain function
4545
return TRUE; // Successful DLL_PROCESS_ATTACH.
4646
}
4747
}
48+
4849
```
4950
50-
## Semmle-specific notes
51-
52-
53-
5451
## References
5552
* [ C28637 ](https://learn.microsoft.com/en-us/windows-hardware/drivers/devtest/28637-calling-function-in-a-global-initializer-is-unsafe)

src/drivers/apps/queries/experimental/UnsafeCallInGlobalInit/UnsafeCallInGlobalInit.qhelp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,6 @@
5151
}]]>
5252
</sample>
5353
</example>
54-
<semmleNotes>
55-
<p>
56-
57-
</p>
58-
</semmleNotes>
5954
<references>
6055
<li>
6156
<a href="https://learn.microsoft.com/en-us/windows-hardware/drivers/devtest/28637-calling-function-in-a-global-initializer-is-unsafe">
Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
# Annotation syntax error
2+
A syntax error in the annotations was found for the property in the function.
3+
4+
5+
## Recommendation
6+
This warning indicates an error in the annotations, not in the code that is being analyzed.
7+
8+
9+
## Example
10+
_IRQL_saves_global_ not applied to entire function
11+
12+
```c
13+
14+
// FAIL
15+
VOID test1(
16+
_IRQL_saves_global_(OldIrql, *Irql) PKIRQL Irql)
17+
{
18+
// ...
19+
;
20+
}
21+
}
22+
23+
```
24+
_Kernel_clear_do_init_ not used with either "yes" or "no"
25+
26+
```c
27+
28+
// FAIL
29+
_Function_class_(DRIVER_ADD_DEVICE)
30+
_IRQL_requires_(PASSIVE_LEVEL)
31+
_IRQL_requires_same_
32+
_Kernel_clear_do_init_(IRP_MJ_CREATE)
33+
NTSTATUS
34+
test4(
35+
_In_ PDRIVER_OBJECT DriverObject,
36+
_In_ PDEVICE_OBJECT PhysicalDeviceObject)
37+
38+
{
39+
; // do nothing
40+
}
41+
}
42+
43+
```
44+
45+
## References
46+
* [ C28266 ](https://learn.microsoft.com/en-us/windows-hardware/drivers/devtest/28266-function-property-syntax-error)

src/drivers/general/queries/AnnotationSyntax/AnnotationSyntax.qhelp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,6 @@
4444
}]]>
4545
</sample>
4646
</example>
47-
<semmleNotes>
48-
<p>
49-
</p>
50-
</semmleNotes>
5147
<references>
5248
<li>
5349
<a href="https://learn.microsoft.com/en-us/windows-hardware/drivers/devtest/28266-function-property-syntax-error">

src/drivers/general/queries/FloatHardwareStateProtection/FloatHardwareStateProtection.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,5 @@ Function that uses float with protected floating-point hardware state
3636
3737
```
3838

39-
## Semmle-specific notes
40-
41-
42-
4339
## References
4440
* [ Warning C28110 ](https://learn.microsoft.com/en-us/windows-hardware/drivers/devtest/28110-floating-point-hardware-protect)

src/drivers/general/queries/FloatHardwareStateProtection/FloatHardwareStateProtection.qhelp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,6 @@
3838
}]]>
3939
</sample>
4040
</example>
41-
<semmleNotes>
42-
<p>
43-
</p>
44-
</semmleNotes>
4541
<references>
4642
<li>
4743
<a href="https://learn.microsoft.com/en-us/windows-hardware/drivers/devtest/28110-floating-point-hardware-protect">

src/drivers/general/queries/ImportantFunctionCallOptimizedOut/ImportantFunctionCallOptimizedOut.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,5 @@ Using SecureZeroMemory or RtlSecureZeroMemory will prevent the compiler from opt
3939
4040
```
4141

42-
## Semmle-specific notes
43-
44-
45-
4642
## References
4743
* [ C28625 ](https://learn.microsoft.com/en-us/windows-hardware/drivers/devtest/28625-sensitive-data-may-be-retained)

src/drivers/general/queries/ImportantFunctionCallOptimizedOut/ImportantFunctionCallOptimizedOut.qhelp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,6 @@
4444
}]]>
4545
</sample>
4646
</example>
47-
<semmleNotes>
48-
<p>
49-
</p>
50-
</semmleNotes>
5147
<references>
5248
<li>
5349
<a href="https://learn.microsoft.com/en-us/windows-hardware/drivers/devtest/28625-sensitive-data-may-be-retained">

src/drivers/general/queries/ImproperNotOperatorOnZero/ImproperNotOperatorOnZero.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,5 @@ Returning !0 instead of a proper error code.
1919
2020
```
2121
22-
## Semmle-specific notes
23-
24-
25-
2622
## References
2723
* [ C28650 ](https://learn.microsoft.com/en-us/windows-hardware/drivers/devtest/28650-generic-value-is-not-treated-as-failure)

src/drivers/general/queries/ImproperNotOperatorOnZero/ImproperNotOperatorOnZero.qhelp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,6 @@
2323
}]]>
2424
</sample>
2525
</example>
26-
<semmleNotes>
27-
<p>
28-
</p>
29-
</semmleNotes>
3026
<references>
3127
<li>
3228
<a href="https://learn.microsoft.com/en-us/windows-hardware/drivers/devtest/28650-generic-value-is-not-treated-as-failure">

0 commit comments

Comments
 (0)