Map suppression names for irql-function-not-annotated#191
Merged
Conversation
As noted at github/codeql#20611 the suppression query doesn't currently accept the warning code for query `irql-function-not-annotated`. Two related pieces of feedback-- 1. The help page at https://learn.microsoft.com/en-us/windows-hardware/drivers/devtest/static-tools-and-codeql?tabs=whcp%2Clatest#suppressing-codeql-results uses incorrect syntax `#pragma(suppress:the-rule-id-here)` -- should be `#pragma prefast(suppress:the-rule-id-here)` or `#pragma warning(suppress:the-rule-id-here)` 2. The regex used to recognise these pragmas is quite brittle; consider accepting spaces between `prefast` or `warning` and the parenthesis, so as to recognise e.g. `#pragma warning (suppress:the-rule-id-here)` Signed-off-by: Chris Smowton <smowton@github.com>
Collaborator
|
I appreciate the fix here as well as the call-outs about the regex and the documentation. I'll open a bug on our end. |
NateD-MSFT
approved these changes
Oct 28, 2025
Collaborator
|
Failures in pipelines are not related to this PR. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted at github/codeql#20611 the suppression query doesn't currently accept the warning code for query
irql-function-not-annotated.Two related pieces of feedback--
The help page at https://learn.microsoft.com/en-us/windows-hardware/drivers/devtest/static-tools-and-codeql?tabs=whcp%2Clatest#suppressing-codeql-results uses incorrect syntax
#pragma(suppress:the-rule-id-here)-- should be#pragma prefast(suppress:the-rule-id-here)or#pragma warning(suppress:the-rule-id-here)The regex used to recognise these pragmas is quite brittle; consider accepting spaces between
prefastorwarningand the parenthesis, so as to recognise e.g.#pragma warning (suppress:the-rule-id-here)Checklist for Pull Requests
@versioncomment in the file header.codeql database createandcodeql database analyzehave completed successfully.