[Development RI] Improve IRQL queries and bump to 1.8.2#203
Merged
Conversation
FI from main to development branch
FI from main to development
* Make IRQLTooLow's behavior consistent with IRQLTooHigh * Bump IrqlTooLow query version
* Make IRQLTooLow's behavior consistent with IRQLTooHigh * Bump IrqlTooLow query version * Improve output message for IrqlSet queries * Clean baseline for IrqlSetTooLow * Bump QLPack to 1.8.2 * Revert "Bump QLPack to 1.8.2" This reverts commit cce7b9c.
There was a problem hiding this comment.
Pull request overview
This PR updates the Windows drivers CodeQL pack to improve IRQL query correctness/clarity (per #199/#201) and bumps the pack version to 1.8.2.
Changes:
- Bump
microsoft/windows-driversqlpack version from1.8.1to1.8.2. - Update
IrqlTooLowto use the max estimated predecessor IRQL and bump query version tov3. - Improve diagnostic messaging for
IrqlSetTooLow/IrqlSetTooHighand refresh associated SARIF/test baselines.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/qlpack.yml | Pack version bump to 1.8.2. |
| src/drivers/general/queries/IrqlTooLow/IrqlTooLow.ql | Adjusts IRQL comparison to use max(...) and bumps query version. |
| src/drivers/general/queries/IrqlSetTooLow/IrqlSetTooLow.ql | Rewords result message to clarify “annotated function constraint vs statement effect”. |
| src/drivers/general/queries/IrqlSetTooHigh/IrqlSetTooHigh.ql | Rewords result message similarly for “set too high”. |
| src/drivers/general/queries/IrqlSetTooLow/IrqlSetTooLow.sarif | Updated expected SARIF output reflecting new messaging/tool metadata. |
| src/drivers/general/queries/IrqlSetTooHigh/IrqlSetTooHigh.sarif | Updated expected SARIF output reflecting new messaging/tool metadata. |
| src/drivers/test/diff/IrqlSetTooLow.sarif | Updates unit test diff expectations for IrqlSetTooLow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jacob-ronstadt
approved these changes
Jan 23, 2026
Collaborator
Author
|
Failed pipelines are due to known issues with our CI test pipelines (see #197). Running test commands locally does not show errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RI our development branch which has fixes for the following two issues related to our IRQL queries, based off internal feedback:
#199
#201
This bumps our query pack version to 1.8.2.
Checklist for Pull Requests
@versioncomment in the file header.codeql database createandcodeql database analyzehave completed successfully.