fix: nightly CI failures + workaround RUSTFLAGS cargo-make leak (#49)

## Changes

### 1. Fix nightly clippy + rustfmt failures

Edits to pass new nightly `clippy::unnecessary_trailing_comma`
[lint](https://rust-lang.github.io/rust-clippy/master/index.html?search=clippy%3A%3Aunnecessary_trailing_comma#unnecessary_trailing_comma)
and nightly rustfmt import reordering.

- Remove 4 unnecessary trailing commas in `format!`/`println!` macros
(`general/echo/kmdf/exe/src/main.rs`)
- Reorder underscore-prefixed imports to match nightly rustfmt sorting
(`device.rs`, `queue.rs`, `driver.rs`)

**Failed CI run:**
https://github.com/microsoft/Windows-rust-driver-samples/actions/runs/22519532366

### 2. Workaround RUSTFLAGS leaking into cargo-make/cargo-wdk builds

Unset `RUSTFLAGS` for `cargo make`, `cargo wdk install`, and `cargo wdk
build` steps in `build.yaml`. This prevents `-D warnings` from leaking
into `rust-script` compilation of `wdk-build` (which is treated as a
path dependency via symlink, bypassing cargo's `--cap-lints allow`).

Temporary workaround until microsoft/windows-drivers-rs#629 is merged
and a new `wdk-build` is published.

Author: wmmc88

.github/workflows/build.yaml

@@ -107,7 +107,13 @@ jobs:
           tool: cargo-make
 
       - name: Build and Package Sample Drivers
-        run: cargo make default +${{ matrix.rust_toolchain }} --locked --profile ${{ matrix.cargo_profile }} --target ${{ matrix.target_triple.name }}
+        # Unset RUSTFLAGS for cargo-make to work around RUSTFLAGS leaking into
+        # rust-script compilation of wdk-build (path dep via symlink defeats
+        # --cap-lints). Upstream fix: microsoft/windows-drivers-rs#629
+        run: |
+          $env:RUSTFLAGS = $null
+          cargo make default +${{ matrix.rust_toolchain }} --locked --profile ${{ matrix.cargo_profile }} --target ${{ matrix.target_triple.name }}
+        shell: pwsh
 
       # Steps to use cargo-wdk to build and package drivers
       - name: Install cargo-wdk binary

general/echo/kmdf/driver/DriverSync/src/device.rs

@@ -4,6 +4,8 @@
 use wdk::{nt_success, paged_code, println};
 use wdk_sys::{
     call_unsafe_wdf_function_binding,
+    _WDF_EXECUTION_LEVEL,
+    _WDF_SYNCHRONIZATION_SCOPE,
     NTSTATUS,
     STATUS_SUCCESS,
     WDFDEVICE,
@@ -13,8 +15,6 @@ use wdk_sys::{
     WDF_NO_HANDLE,
     WDF_OBJECT_ATTRIBUTES,
     WDF_PNPPOWER_EVENT_CALLBACKS,
-    _WDF_EXECUTION_LEVEL,
-    _WDF_SYNCHRONIZATION_SCOPE,
 };
 
 use crate::{

general/echo/kmdf/driver/DriverSync/src/queue.rs

@@ -7,6 +7,10 @@ use wdk::{nt_success, paged_code, println, wdf};
 use wdk_sys::{
     call_unsafe_wdf_function_binding,
     ntddk::{ExAllocatePool2, ExFreePool},
+    _WDF_EXECUTION_LEVEL,
+    _WDF_IO_QUEUE_DISPATCH_TYPE,
+    _WDF_SYNCHRONIZATION_SCOPE,
+    _WDF_TRI_STATE,
     NTSTATUS,
     POOL_FLAG_NON_PAGED,
     SIZE_T,
@@ -25,10 +29,6 @@ use wdk_sys::{
     WDF_NO_HANDLE,
     WDF_OBJECT_ATTRIBUTES,
     WDF_TIMER_CONFIG,
-    _WDF_EXECUTION_LEVEL,
-    _WDF_IO_QUEUE_DISPATCH_TYPE,
-    _WDF_SYNCHRONIZATION_SCOPE,
-    _WDF_TRI_STATE,
 };
 
 use crate::{

general/echo/kmdf/exe/src/main.rs

@@ -413,7 +413,7 @@ fn async_io_work(io_type: u32) -> Result<(), Box<dyn Error>> {
                 // - Memory safety: Returns u32 value (no pointer dereferences)
                 let error = unsafe { GetLastError() };
                 if error != ERROR_IO_PENDING {
-                    return Err(format!("{i}th Read failed {error}",).into());
+                    return Err(format!("{i}th Read failed {error}").into());
                 }
             }
         } else {
@@ -488,7 +488,7 @@ fn async_io_work(io_type: u32) -> Result<(), Box<dyn Error>> {
         }
 
         if io_type == READER_TYPE {
-            println!("Number of bytes read by request number {i} is {number_of_bytes_transferred}",);
+            println!("Number of bytes read by request number {i} is {number_of_bytes_transferred}");
 
             if globals.limited_loops {
                 remaining_requests_to_receive -= 1;
@@ -539,7 +539,7 @@ fn async_io_work(io_type: u32) -> Result<(), Box<dyn Error>> {
             }
         } else {
             println!(
-                "Number of bytes written by request number {i} is {number_of_bytes_transferred}",
+                "Number of bytes written by request number {i} is {number_of_bytes_transferred}"
             );
 
             if globals.limited_loops {
@@ -636,7 +636,7 @@ fn get_device_path(interface_guid: &Uuid) -> Result<(), Box<dyn Error>> {
 
     if config_ret != DeviceAndDriverInstallation::CR_SUCCESS {
         return Err(
-            format!("Error 0x{config_ret:08X} retrieving device interface list size.",).into(),
+            format!("Error 0x{config_ret:08X} retrieving device interface list size.").into(),
         );
     }
 

tools/dv/kmdf/fail_driver_pool_leak/src/driver.rs

@@ -5,6 +5,8 @@ use wdk::{nt_success, paged_code, println};
 use wdk_sys::{
     call_unsafe_wdf_function_binding,
     ntddk::ExAllocatePool2,
+    _WDF_EXECUTION_LEVEL,
+    _WDF_SYNCHRONIZATION_SCOPE,
     DRIVER_OBJECT,
     NTSTATUS,
     PCUNICODE_STRING,
@@ -19,8 +21,6 @@ use wdk_sys::{
     WDF_NO_HANDLE,
     WDF_NO_OBJECT_ATTRIBUTES,
     WDF_OBJECT_ATTRIBUTES,
-    _WDF_EXECUTION_LEVEL,
-    _WDF_SYNCHRONIZATION_SCOPE,
 };
 
 use crate::{GLOBAL_BUFFER, GUID_DEVINTERFACE};