fix: re-enable tests on cdylib crates#39
Merged
wmmc88 merged 1 commit intoNov 20, 2025
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request re-enables unit tests for cdylib driver crates by removing the exclusion of tests in two Cargo.toml files.
- Removed the "test = false" setting and corresponding comment from tools/dv/kmdf/fail_driver_pool_leak/Cargo.toml.
- Removed the "test = false" setting and corresponding comment from general/echo/kmdf/driver/DriverSync/Cargo.toml.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| general/echo/kmdf/driver/DriverSync/Cargo.toml | Removed test exclusion for the cdylib crate. |
| tools/dv/kmdf/fail_driver_pool_leak/Cargo.toml | Removed test exclusion for the cdylib crate. |
Comments suppressed due to low confidence (2)
tools/dv/kmdf/fail_driver_pool_leak/Cargo.toml:13
- The removal of 'test = false' re-enables tests; please ensure that the current linker configuration safely handles unit tests for this cdylib crate, given the previous concerns referenced in the comment.
-test = false
general/echo/kmdf/driver/DriverSync/Cargo.toml:12
- With tests re-enabled for this cdylib crate, verify that any issues with linker arguments noted in the removed comment are adequately addressed in your testing or build configuration.
-test = false
gurry
approved these changes
Jun 10, 2025
leon-xd
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to microsoft/windows-drivers-rs#327
This pull request removes the exclusion of unit tests from the root driver crates in two
Cargo.tomlfiles. This change allows unit tests to be included, despite the previous concern about linker arguments being passed to them.Changes to
Cargo.tomlfiles:general/echo/kmdf/driver/DriverSync/Cargo.toml: Removed the line excluding unit tests (test = false) from the root driver crate.tools/dv/kmdf/fail_driver_pool_leak/Cargo.toml: Removed the line excluding unit tests (test = false) from the root driver crate.