refactor: remove magic numbers#64
Merged
Alan632 merged 12 commits intoJul 20, 2026
Merged
Conversation
wmmc88
requested changes
Jun 17, 2026
added 5 commits
June 17, 2026 09:47
…s into function scope as appropriate,
wmmc88
previously approved these changes
Jun 24, 2026
- revert unnecessary const's to literals w/improved comments
ayodejiige
reviewed
Jun 24, 2026
Signed-off-by: Alan632 <aln.noda7@gmail.com>
wmmc88
approved these changes
Jul 16, 2026
ayodejiige
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Decompose magic numbers into
const's adding relevant documentation.