Skip to content

Commit 6e81dc6

Browse files
mahabayanaCopilot
andauthored
Bug Bash - removing ep_policy option DISABLE (#635)
Remove the DISABLE option from ep_policy in both C# and C++ ArgumentParser. Unknown policies now default to DEFAULT instead of DISABLE. Updated READMEs accordingly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent a1f17bc commit 6e81dc6

4 files changed

Lines changed: 8 additions & 14 deletions

File tree

Samples/WindowsML/Shared/cpp/ArgumentParser.cpp

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,10 @@ namespace Shared
6565
{
6666
options.ep_policy = OrtExecutionProviderDevicePolicy_DEFAULT;
6767
}
68-
else if (policy_str == L"DISABLE")
69-
{
70-
options.ep_policy = std::nullopt;
71-
}
7268
else
7369
{
74-
std::wcout << L"Unknown EP policy: " << policy_str << L", using default (DISABLE)\n";
70+
std::wcout << L"Unknown EP policy: " << policy_str << L", using default (DEFAULT)\n";
71+
options.ep_policy = OrtExecutionProviderDevicePolicy_DEFAULT;
7572
}
7673
}
7774
else if (arguments[i] == L"--perf_mode" && i + 1 < arguments.size())
@@ -183,7 +180,7 @@ namespace Shared
183180
{
184181
std::wcout << L"Usage: Application.exe [options]\n"
185182
<< L"Options:\n"
186-
<< L" --ep_policy <policy> Set execution provider selection policy (NPU, CPU, GPU, DEFAULT, DISABLE)\n"
183+
<< L" --ep_policy <policy> Set execution provider selection policy (NPU, CPU, GPU, DEFAULT)\n"
187184
<< L" --ep_name <name> Explicit execution provider name (mutually exclusive with --ep_policy)\n"
188185
<< L" --device_type <type> Device type for OpenVINOExecutionProvider (NPU, GPU, CPU) when multiple present\n"
189186
<< L" --perf_mode <mode> Set EP performance mode (MAX_PERFORMANCE, MAX_EFFICIENCY, DEFAULT)\n"

Samples/WindowsML/Shared/cs/ArgumentParser.cs

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -75,12 +75,9 @@ public static Options ParseOptions(string[] args)
7575
case "DEFAULT":
7676
options.EpPolicy = ExecutionProviderDevicePolicy.DEFAULT;
7777
break;
78-
case "DISABLE":
79-
options.EpPolicy = null;
80-
break;
8178
default:
82-
Console.WriteLine($"Unknown EP policy: {policyStr}, using default (DISABLE)");
83-
options.EpPolicy = null;
79+
Console.WriteLine($"Unknown EP policy: {policyStr}, using default (DEFAULT)");
80+
options.EpPolicy = ExecutionProviderDevicePolicy.DEFAULT;
8481
break;
8582
}
8683
}
@@ -213,7 +210,7 @@ public static Options ParseOptions(string[] args)
213210
public static void PrintHelp()
214211
{
215212
Console.WriteLine("Options:");
216-
Console.WriteLine(" --ep_policy <policy> Set execution provider policy (NPU, CPU, GPU, DEFAULT, DISABLE)");
213+
Console.WriteLine(" --ep_policy <policy> Set execution provider policy (NPU, CPU, GPU, DEFAULT)");
217214
Console.WriteLine(" --ep_name <name> Explicit execution provider name (mutually exclusive with --ep_policy)");
218215
Console.WriteLine(" --device_type <type> Optional hardware device type to use when EP supports multiple (e.g. CPU, GPU, NPU)");
219216
Console.WriteLine(" --perf_mode <mode> Set EP performance mode (MAX_PERFORMANCE, MAX_EFFICIENCY, DEFAULT)");

Samples/WindowsML/cpp/CppConsoleDesktop/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ This sample demonstrates how to use ONNX Runtime in a C++ desktop application, f
1111
```
1212
CppConsoleDesktop.exe [options]
1313
Options:
14-
--ep_policy <policy> Set execution provider policy (NPU, CPU, GPU, DEFAULT, DISABLE). Default: DISABLE
14+
--ep_policy <policy> Set execution provider policy (NPU, CPU, GPU, DEFAULT). Default: DEFAULT
1515
--compile Compile the model
1616
--download Download required packages
1717
--model <path> Path to input ONNX model (default: SqueezeNet.onnx in executable directory)

Samples/WindowsML/cs/CSharpConsoleDesktop/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ This sample demonstrates how to use ONNX Runtime in a C# desktop application, fo
1111
```shell
1212
CSharpConsoleDesktop.exe [options]
1313
Options:
14-
--ep_policy <policy> Set execution provider policy (NPU, CPU, GPU, DEFAULT, DISABLE). Default: DISABLE
14+
--ep_policy <policy> Set execution provider policy (NPU, CPU, GPU, DEFAULT). Default: DEFAULT
1515
--compile Compile the model
1616
--download Download required packages
1717
--model <path> Path to input ONNX model (default: SqueezeNet.onnx in executable directory)

0 commit comments

Comments
 (0)