Skip to content

Commit c4f767f

Browse files
Python: Make lab pyright-only on source (drop source mypy)
Lab was the last package still running mypy on its source code, requiring mypy-only `# type: ignore` comments that pyright (the sole source checker everywhere else) flags as unnecessary. Align lab with the rest of the monorepo: - Remove the lab source mypy poe tasks (mypy-gaia/lightning/tau2) and the now-dead strict [tool.mypy] config block. - Drop the 'Run lab mypy' CI step; lab source is type-checked by pyright only. Lab tests remain covered by the workspace test-typing fan-out (mypy, pyrefly, ty, zuban, pyright over tests using the relaxed root config). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent cc3db3b commit c4f767f

2 files changed

Lines changed: 0 additions & 33 deletions

File tree

.github/workflows/python-lab-tests.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,6 @@ jobs:
9292
- name: Run lab type checking
9393
run: cd packages/lab && uv run poe pyright
9494

95-
- name: Run lab mypy
96-
run: cd packages/lab && uv run poe mypy
97-
9895
# Surface failing tests
9996
- name: Surface failing tests
10097
if: always()

python/packages/lab/pyproject.toml

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -126,43 +126,13 @@ extends = "../../pyproject.toml"
126126
include = ["gaia/agent_framework_lab_gaia", "lightning/agent_framework_lab_lightning", "tau2/agent_framework_lab_tau2"]
127127
exclude = ['gaia/tests', 'lightning/tests', 'tau2/tests', 'namespace', '**/samples']
128128

129-
[tool.mypy]
130-
plugins = ['pydantic.mypy']
131-
strict = true
132-
python_version = "3.10"
133-
ignore_missing_imports = true
134-
disallow_untyped_defs = true
135-
no_implicit_optional = true
136-
check_untyped_defs = true
137-
warn_return_any = true
138-
show_error_codes = true
139-
warn_unused_ignores = false
140-
disallow_incomplete_defs = true
141-
disallow_untyped_decorators = true
142-
143129
[tool.bandit]
144130
targets = ["agent_framework_lab_gaia", "agent_framework_lab_lightning", "agent_framework_lab_tau2"]
145131
exclude_dirs = ["gaia/tests", "lightning/tests", "tau2/tests"]
146132

147133
[tool.poe]
148134
include = "../../shared_tasks.toml"
149135

150-
[tool.poe.tasks.mypy-gaia]
151-
help = "Run MyPy for the lab GAIA package."
152-
cmd = "mypy --config-file $POE_ROOT/pyproject.toml gaia/agent_framework_lab_gaia"
153-
154-
[tool.poe.tasks.mypy-lightning]
155-
help = "Run MyPy for the lab Lightning package."
156-
cmd = "mypy --config-file $POE_ROOT/pyproject.toml lightning/agent_framework_lab_lightning"
157-
158-
[tool.poe.tasks.mypy-tau2]
159-
help = "Run MyPy for the lab Tau2 package."
160-
cmd = "mypy --config-file $POE_ROOT/pyproject.toml tau2/agent_framework_lab_tau2"
161-
162-
[tool.poe.tasks.mypy]
163-
help = "Run MyPy across all lab subpackages."
164-
sequence = ["mypy-gaia", "mypy-lightning", "mypy-tau2"]
165-
166136
[tool.poe.tasks.test]
167137
help = "Run the default lab unit test suite."
168138
cmd = 'pytest -m "not integration and not resource_intensive" --cov-report=term-missing:skip-covered --junitxml=test-results.xml'

0 commit comments

Comments
 (0)